[Tan Kang Liang] iP #308
Open
[Tan Kang Liang] iP #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rishi5154
reviewed
Sep 3, 2020
| * @param input Input from user. | ||
| */ | ||
| private void listByDueDate(String input) { | ||
| Optional<LocalDate> optionalDate; |
Rishi5154
reviewed
Sep 3, 2020
src/main/java/duck/Duck.java
Outdated
|
|
||
| /** | ||
| * Receives input continuously until "bye" command is given. | ||
| * Main loop of the bot. |
There was a problem hiding this comment.
JavaDocs can be updated to account for the return type of String[] this time
There was a problem hiding this comment.
Thanks for pointing that out!
Rishi5154
reviewed
Sep 3, 2020
| /** | ||
| * LocalStorage makes use of Serializable objects to write to a local file. | ||
| */ | ||
| public class LocalStorage implements Storage { |
There was a problem hiding this comment.
Really neat exemplification of abstraction with interfaces for Storage implemented by main class LocalStorage!
Rishi5154
reviewed
Sep 3, 2020
| private List<Task> tasks; | ||
|
|
||
| public TaskList() { | ||
| this.tasks = new ArrayList<Task>(); |
There was a problem hiding this comment.
this. can be removed for better readability
There was a problem hiding this comment.
Thanks! I'll remove all the uses that don't disambiguate anything.
Rishi5154
reviewed
Sep 3, 2020
| */ | ||
| public String[] getStatusesByDate(Optional<LocalDate> optionalDate) { | ||
|
|
||
| return this.tasks.stream() |
There was a problem hiding this comment.
Awesome use of streams & FP to filter out the tasks with dates!
Rishi5154
reviewed
Sep 3, 2020
Add assertion for date in TaskWithDate
Fix code quality
Add lambda expressions
Update streams to use method call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.