[Yao Yuan] iP #310
[Yao Yuan] iP #310
Conversation
| try { | ||
| ui.sayBye(); | ||
| storage.writeToFile(list); | ||
| // to get out of loop and terminate the program |
There was a problem hiding this comment.
Is it better if an empty line is placed to separate the code above the comment and the comment?
|
|
||
| public class ByeCommand extends Command { | ||
|
|
||
| ByeCommand(String str) { |
There was a problem hiding this comment.
Is it better if the access of the constructor is specified?
| protected boolean isExit = false; | ||
|
|
||
| /** | ||
| * Creates a command. |
There was a problem hiding this comment.
Is it better if an empty line is placed separate the description and the param explanation?
| this.str = str; | ||
| } | ||
|
|
||
| // different command class will have different execute implementation |
There was a problem hiding this comment.
Is it better to use a more formal java doc to explain the method?
| private String time; | ||
|
|
||
| /** | ||
| * Creates a deadline task. |
There was a problem hiding this comment.
Is it better if we can have an empty line to separate the description and the @param?
| super(description, isDone); | ||
| } | ||
|
|
||
| public String toString() { |
There was a problem hiding this comment.
Is it better if the @OverRide can be specified?
| */ | ||
| public class EventCommand extends Command { | ||
|
|
||
| EventCommand(String str) { |
There was a problem hiding this comment.
Is it better if you specify the access?
src/main/java/Storage.java
Outdated
| import java.util.List; | ||
| import java.util.Scanner; | ||
|
|
||
| // deals with loading tasks from the file and saving tasks in the file |
There was a problem hiding this comment.
Is it better to have a formal java doc?
| isDone = true; | ||
| } | ||
|
|
||
| public String toString() { |
There was a problem hiding this comment.
Is it better if the @OverRide can be specified?
| super(description, isDone); | ||
| } | ||
|
|
||
| public String toString() { |
There was a problem hiding this comment.
Is it better if the @OverRide can be specified?
src/main/java/Command.java
Outdated
| @@ -1,5 +1,8 @@ | |||
| import java.io.IOException; | |||
|
|
|||
| /** | |||
| * Represents a command to be executed. | |||
| */ | |||
| public abstract class Command { | |||
| String str; | |||
There was a problem hiding this comment.
Could have better names for your variables. I have no idea what str does just from the name. Or maybe you could add a comment to explain what it does...?
src/main/java/DeleteCommand.java
Outdated
| /** | ||
| * Represents a delete command from a user | ||
| * which will lead to the deletion of a task in the task list. | ||
| */ | ||
| public class DeleteCommand extends Command{ |
src/main/java/DoneCommand.java
Outdated
| @@ -1,9 +1,19 @@ | |||
| /** | |||
| * Represents a done command. | |||
| */ | |||
| public class DoneCommand extends Command{ | |||
src/main/java/Event.java
Outdated
| @@ -1,3 +1,6 @@ | |||
| /** | |||
| * Represents a event task. | |||
| */ | |||
| public class Event extends Task{ | |||
src/main/java/EventCommand.java
Outdated
| @@ -2,6 +2,9 @@ | |||
| import java.time.format.DateTimeFormatter; | |||
| import java.time.format.DateTimeParseException; | |||
|
|
|||
| /** | |||
| * Represents a event command from a user. | |||
| */ | |||
| public class EventCommand extends Command{ | |||
src/main/java/ListCommand.java
Outdated
|
|
||
| /** | ||
| * Represents a list command from a user. | ||
| */ | ||
| public class ListCommand extends Command{ |
There was a problem hiding this comment.
Another space you forgot to add here.
src/main/java/Ui.java
Outdated
| // deals with interactions with the user | ||
| /** | ||
| * Deals with interactions with the user. | ||
| */ | ||
| public class Ui { | ||
| private Scanner sc; | ||
| private String line = "_________________________________________________________________"; |
There was a problem hiding this comment.
This seems like a constant. Might wanna add 'final' to it as well.
Branch a assertions
Improve code quality
Branch bcd extension
Merge branch 'master' into branch-A-CodeQuality
Exit program after saying bye
No description provided.