Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tan Jia Wei Joe] iP #335

Open
wants to merge 59 commits into
base: master
Choose a base branch
from
Open

Conversation

tjwjoe
Copy link

@tjwjoe tjwjoe commented Aug 24, 2020

No description provided.

Copy link

@justweihong justweihong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall code quality seems rather good! Keep it up! Just some minor suggestions that you can consider.

src/main/java/duke/Parser.java Show resolved Hide resolved
* Initialise the MainWindow.
*/
@FXML
public void initialize() {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a suggestion but you can also consider the short form "init".

src/main/java/tasks/Task.java Outdated Show resolved Hide resolved
src/main/java/commands/DeleteCommand.java Outdated Show resolved Hide resolved
src/main/java/commands/ExitCommand.java Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants