[Xu ZhiZhi] iP #336
Open
[Xu ZhiZhi] iP #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhizhizhizhizhi
force-pushed
the
master
branch
from
bd6fbeb
to
74f6376
Compare
zhizhizhizhizhi
force-pushed
the
master
branch
from
74f6376
to
b71a498
Compare
gsmoon97
reviewed
Sep 1, 2020
| } else { | ||
| throw new DukeException(DukeException.IGNORE); | ||
| } | ||
| } else if (task.length > 0 && task[0].equals("todo")){ |
There was a problem hiding this comment.
Shouldn't the 'if condition' and the 'following {' be separated by a single whitespace?
src/main/java/TaskList/Storage.java
Outdated
| import java.io.IOException; | ||
| import java.util.ArrayList; | ||
|
|
||
| import Tasks.*; |
There was a problem hiding this comment.
Perhaps the relevant Task libraries could be listed and imported explicitly instead of using a wildcard import?
ngmarcus
reviewed
Sep 1, 2020
| import TaskList.TaskList; | ||
|
|
||
| public class FindCommand extends Command { | ||
| private String searchText; |
There was a problem hiding this comment.
Perhaps userInput would be a more suitable variable name than searchText?
| return (completed ? "[✓]" : "[✗]") + " " + name; | ||
| } | ||
|
|
||
| public enum Type { |
There was a problem hiding this comment.
I like your suitable use of enum here!
| this.type = type; | ||
| } | ||
|
|
||
| public enum CommandType { |
src/main/java/DukeComponent/Ui.java
Outdated
| return s; | ||
| } | ||
|
|
||
| public static String welcomeMessage() { |
There was a problem hiding this comment.
Should the method be named more accurately with a verb, perhaps getWelcomeMessage()?
src/main/java/DukeComponent/Ui.java
Outdated
| return print("Try again! Date format should be yyyy-mm-dd."); | ||
| } | ||
|
|
||
| public static String exitMessage() { |
There was a problem hiding this comment.
Should the method be named more accurately with a verb, perhaps getExitMessage()?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.