[Tan Xuan Zhi] iP #344

xxzz-tt · 2020-08-25T03:31:15Z

No description provided.

Remerge

Remerge level-8

Add branch level-8 back

tengjianling

Pretty good job except that some methods can be split into different methods to become shorter. Good job!

tengjianling · 2020-08-31T15:18:35Z

src/main/java/Chat.java

@@ -0,0 +1,10 @@
+
+enum Chat {


Should the enum instances be fully capitalized?

Enums are constants so perhaps it is fine to be fully capitalised.

tengjianling · 2020-08-31T15:21:30Z

src/main/java/Chatbot.java

@@ -0,0 +1,145 @@
+import java.io.*;


Maybe list out the imports explicitly instead of using .*?

tengjianling · 2020-08-31T15:23:02Z

src/main/java/Chatbot.java

+import java.util.ArrayList;
+import java.util.List;
+import java.util.Scanner;
+import java.time.LocalDateTime;
+import java.time.format.FormatStyle;
+import java.util.ArrayList;
+import java.util.List;
+import java.time.LocalDate;
+import java.time.format.DateTimeFormatter;
+import java.time.temporal.ChronoUnit;


Maybe arrange the imports in lexicology order?

tengjianling · 2020-08-31T15:25:57Z

src/main/java/Chatbot.java

+        System.out.println(line);
+        System.out.println("Got it. I've added this task:");
+        System.out.println(t.printTask());
+        System.out.println("Now you have " + list.size() + (list.size() > 1 ? " tasks" : " task") + " on the list");


Maybe split this line into different lines for better readability?

tengjianling · 2020-08-31T15:26:26Z

src/main/java/Chatbot.java

+                case "bye":
+                    exit();
+                    return false;
+//            break;


Did you forget to remove this line?

tengjianling · 2020-08-31T15:28:01Z

src/main/java/Chatbot.java

+        System.out.println(line);
+    }
+
+    public boolean chat(String s) throws IncorrectInputException, IOException {


Maybe extract the components in this method into different methods? There is a lot of information in just 1 method.

tengjianling · 2020-08-31T15:30:19Z

src/main/java/Duke.java

+    public static void main(String[] args) throws IOException, IncorrectInputException {
+        new Duke("src/main/java/tasklist.txt").run();
+    }
+//    public static void main(String[] args) {


Remember to delete this if you're not using it in your code!

tengjianling · 2020-08-31T15:38:27Z

src/main/java/Parser.java

+     * @throws IOException
+     * @throws IncorrectInputException
+     */
+    public void parse(String s) throws IOException, IncorrectInputException {


Maybe extract out some parts of this method to shorten it? This method may become even longer as more functions of the application is added later on.

tengjianling · 2020-08-31T15:39:25Z

src/main/java/Storage.java

@@ -0,0 +1,84 @@
+import java.io.*;


Maybe explicitly importing each line rather than using .* would be clearer?

Perhaps you may avoid the usage of * in import statements because it will help you and other developers easily understand the code base when all the classes have been grouped in packages.

tengjianling · 2020-08-31T15:40:20Z

src/main/java/Task.java

@@ -0,0 +1,45 @@
+public class Task {
+
+    private boolean completed;


Maybe changed the naming of this variable to isCompleted?

Enter JavaDoc

Enforce coding standard

Refactor L9

marcustw

Good job! Overall code follows good Code Quality examples from the textbook, except for some methods may be too long. Well done.

marcustw · 2020-09-01T07:41:34Z

src/main/java/Chat.java

@@ -0,0 +1,10 @@
+
+enum Chat {


Enums are constants so perhaps it is fine to be fully capitalised.

marcustw · 2020-09-01T07:42:33Z

src/main/java/Chatbot.java

@@ -0,0 +1,145 @@
+import java.io.*;


Perhaps you may avoid the usage of * in import statements because it will help you and other developers easily understand the code base when all the classes have been grouped in packages.

marcustw · 2020-09-01T07:43:48Z

src/main/java/Chatbot.java

+import java.time.temporal.ChronoUnit;
+
+public class Chatbot {
+    public String line = "____________________________________________________________";


Perhaps the variable line can be final, with capitalised variable name as a constant?

marcustw · 2020-09-01T07:45:01Z

src/main/java/Chatbot.java

+        System.out.println(t.printTask());
+        System.out.println("Now you have " + list.size() + (list.size() > 1 ? " tasks" : " task") + " on the list");
+        System.out.println(line);
+    }


Maybe you can leave a line between methods? (between line 30 and line 31)

marcustw · 2020-09-01T07:45:54Z

src/main/java/Chatbot.java

+                    System.out.println("Nice! I've marked this task as done:");
+                    System.out.println(t.printTask());
+                    System.out.println(line);
+


Perhaps this empty space at line 80 can be removed?

marcustw · 2020-09-01T07:48:58Z

src/main/java/Main.java

+        bot.greeting();
+
+
+        while (sc.hasNext() && bot.chat(sc.nextLine())) {


Perhaps bot.chat(sc.nextLine()) can be added under the while loop instead of the conditional cases to make the while loop clearer?

marcustw · 2020-09-01T07:51:36Z

src/main/java/Parser.java

+     * @throws IOException
+     * @throws IncorrectInputException
+     */
+    public void parse(String s) throws IOException, IncorrectInputException {


Perhaps as Jian Ling mentioned, you can extract out the methods and break the long chunk of code down into smaller methods to make this method cleaner?

marcustw · 2020-09-01T07:56:50Z

src/main/java/Storage.java

@@ -0,0 +1,84 @@
+import java.io.*;


Perhaps you may avoid the usage of * in import statements because it will help you and other developers easily understand the code base when all the classes have been grouped in packages.

marcustw · 2020-09-01T08:02:14Z

src/main/java/Task.java

+    }
+
+    /**
+     * Mark the task as completed


Perhaps the description of javadocs can start with "Marks" instead of "Mark"?

Adds gradle support

ramenmen

Overall I don't think I saw many coding standard violations! Nice code!!

ramenmen · 2020-09-01T12:09:05Z

src/main/java/Chatbot.java

@@ -0,0 +1,145 @@
+import java.io.*;


Maybe imports can be listed explicitly?

ramenmen · 2020-09-01T12:14:40Z

src/main/java/Chatbot.java

+            switch (firstWord) {
+                case "bye":
+                    exit();
+                    return false;


Maybe you could add a line break after each case to increase readability?

ramenmen · 2020-09-01T12:18:47Z

src/main/java/Parser.java

+
+    /**
+     * Parse users' commands and respond to them.
+     * @param s


Should a line be left between the description and @param?

ramenmen · 2020-09-01T12:20:44Z

src/main/java/Task.java

+        return "[" + this.getStatusIcon() + "] " + this.name;
+    }
+
+    public int completedAsNumber() {


Maybe this method name could be written as a verb, like convertCompletedToNumber or something?

Merge GUI into master

Add assertion statements

Improve code quality

damithc and others added 24 commits July 23, 2020 23:27

Add Gradle support

3b19ba1

Level-1

5bcfac2

Level-2

a2105a5

Level-3

9ccffca

Level-4

838d6bb

A-TextUiTesting

1efa827

Handle Exceptions Level-5

2755c2f

Add delete Level-6

e7fb234

A-Enums

992d97d

Save Tasks Level-7

36503ee

Add date time Level-8

bb6b55f

Resolve merge conflicts in Chatbox

278de99

Use more OOP A-MoreOOP

bfc8589

Add JUnit Tests

611b20c

Create JAR file

684ebf1

Add JavaDoc comments

84acddf

Follow the Coding Standard

c3e942a

Find

c2042a9

Refactors

27066fc

Refactors code

18a4c82

Merge branch 'branch-Level-7'

bbe416d

Remerge

Merge branch 'branch-Level-8'

f434ece

Remerge level-8

Refactor level-8

220a8ca

Merge branch 'branch-Level-8'

aa07726

Add branch level-8 back

tengjianling reviewed Aug 31, 2020

View reviewed changes

xxzz-tt added 5 commits September 1, 2020 00:22

Implement JavaDoc

4e1567c

Finalise Coding Standard

174c1c5

Refactor Level 9

077a10d

Merge branch 'branch-A-JavaDoc'

6636b85

Enter JavaDoc

Merge branch 'branch-A-CodingStandard'

1fe40b6

Enforce coding standard

Merge branch 'branch-Level-9'

472be7b

Refactor L9

marcustw reviewed Sep 1, 2020

View reviewed changes

xxzz-tt added 3 commits September 1, 2020 18:34

Merge branch 'add-gradle-support'

158ae73

Adds gradle support

Set up gradle to run unit tests

43a133c

Add checkstyle

da08d5b

ramenmen reviewed Sep 1, 2020

View reviewed changes

xxzz-tt and others added 16 commits September 1, 2020 22:46

Add GUI to Duke

4b3a7e3

Merge branch 'branch-Level-10'

bad327d

Merge GUI into master

GUI update

3f0bb3e

Add assertion statements

d01dcd4

Improve code quality

e9a070e

Merge pull request #1 from xxzz-tt/branch-A-Assertions

2b9f35a

Add assertion statements

Merge branch 'master' into branch-A-CodeQuality

c7313be

Merge pull request #2 from xxzz-tt/branch-A-CodeQuality

810ecbe

Improve code quality

Extension to include friends

c611477

Polish GUI and code

6aa62ac

Add user guide

1859519

Debug find friend command

b468f91

Edit UG

319bef1

Fix code style

36a0322

Adhere to checkstyle

7f6230f

Fix checkstyle

af41dbd

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Tan Xuan Zhi] iP #344

[Tan Xuan Zhi] iP #344

xxzz-tt commented Aug 25, 2020

tengjianling left a comment

tengjianling Aug 31, 2020

marcustw Sep 1, 2020

tengjianling Aug 31, 2020

tengjianling Aug 31, 2020

tengjianling Aug 31, 2020

tengjianling Aug 31, 2020

tengjianling Aug 31, 2020

tengjianling Aug 31, 2020

tengjianling Aug 31, 2020

tengjianling Aug 31, 2020

marcustw Sep 1, 2020

tengjianling Aug 31, 2020

marcustw left a comment

marcustw Sep 1, 2020

marcustw Sep 1, 2020

marcustw Sep 1, 2020

marcustw Sep 1, 2020

marcustw Sep 1, 2020

marcustw Sep 1, 2020

marcustw Sep 1, 2020

marcustw Sep 1, 2020

marcustw Sep 1, 2020

ramenmen left a comment

ramenmen Sep 1, 2020

ramenmen Sep 1, 2020

ramenmen Sep 1, 2020

ramenmen Sep 1, 2020

		@@ -0,0 +1,45 @@
		public class Task {

		private boolean completed;

		bot.greeting();


		while (sc.hasNext() && bot.chat(sc.nextLine())) {

[Tan Xuan Zhi] iP #344

Are you sure you want to change the base?

[Tan Xuan Zhi] iP #344

Conversation

xxzz-tt commented Aug 25, 2020

tengjianling left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

marcustw left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ramenmen left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment