[Toh Xuan Ning Jeanne] iP #398
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Data is not persistent and flushes on each run. This is not ideal for long term usage of this task manager. Let's make the data persistent by saving and loading the tasks to and from a "saved-tasks.txt" file. Let's also introduce OOP practices by creating a Storage class to handle this.
The dates in deadlines are stored as Strings. Storing dates as Strings is less ideal as it does not allow for sorting, etc. Let's store deadline dates as a java.time.LocalDate instead.
jmleong666
reviewed
Aug 31, 2020
jmleong666
reviewed
Aug 31, 2020
jmleong666
reviewed
Aug 31, 2020
Comment on lines
21
to
22
| return "deadline " + this.description + " /by " + this.by + System.lineSeparator() | ||
| + this.isDone + System.lineSeparator(); |
There was a problem hiding this comment.
Should the wrapped line be indented 8 spaces relative to the parent line (line 20) rather than the previous line (line 21)? I've noticed the same issue in other parts of the code as well. (See Java coding standard -> Layout)
There was a problem hiding this comment.
Hmm, I thought that line 21 would be considered the parent line of line 22? I've seen the part of Java coding standard that you've pointed out, and I get that you're referring to the second example of:
if (isReady) {
setText("Long line split"
+ "into two parts.");
}
However, I've also looked at parts outside of that example which seems to suggest the parent line is the line above. E.g.
method(param1,
object.method()
.method2(),
param3);
I will further check with my TA regarding this and let you know the outcome! :) Thanks for pointing it out though!
jmleong666
reviewed
Aug 31, 2020
jmleong666
reviewed
Aug 31, 2020
Add Assertions
Improve Code Quality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.