[Chen Xingjian] iP #402
Open
[Chen Xingjian] iP #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* master: UPDATE UI # Conflicts: # src/main/java/Duke.java
* branch-Level-8: Level-8 UPDATE Duke.class file # Conflicts: # src/main/java/Command.java # src/main/java/Duke.java
* branch-A-JavaDoc: A-JavaDoc
* branch-A-CodingStandard: A-CodingStandard # Conflicts: # src/main/java/Duke/Command/DeleteCommand.java # src/main/java/Duke/Parser.java # src/main/java/Duke/Task.java # src/main/java/Duke/TaskList.java
* branch-A-CheckStyle: A-CheckStyle
* branch-A-CheckStyle: Update Ui
* branch-A-Gradle: Update build.gradle checkstyle
* branch-GUI: Update Main Setup Launcher and Main java class GUI Test setup # Conflicts: # src/main/java/duke/DialogBox.java # src/main/java/duke/Duke.java # src/main/java/duke/Launcher.java # src/main/java/duke/Main.java # src/main/java/duke/Tester.java
WeiJie96
reviewed
Sep 3, 2020
|
|
||
| /** | ||
| * Creates a DateAndTime object | ||
| * @param date String representing date |
There was a problem hiding this comment.
Should there be a newline after the description?
| * @param date String representing date | ||
| * @param time String representing time | ||
| * @throws InvalidDateTimeException | ||
| */ |
There was a problem hiding this comment.
Should there be a description to say when the exception would be thrown?
|
|
||
| /** | ||
| * Represents date and time object | ||
| */ |
There was a problem hiding this comment.
Should there be a full stop after the description
|
|
||
| /** | ||
| * An example of a custom control using FXML. | ||
| * This control represents a dialog box consisting of an ImageView to represent the speaker's face and a label |
There was a problem hiding this comment.
Should this line be one more indented by one more space? Perhaps we can align the second "" of the "/**" line with the "" of the subsequent lines
A-Assertions
A-CodeQuality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.