[Wu Zeying] iP #428
Open
[Wu Zeying] iP #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
load Duke.txt when duke starts and add in the new task into the Duke.txt.
Able to store previous list to the file duke.txt.
Store date as LocalDate and allow date conversion from yyyy-mm-dd format to MMM dd yyyy format,
* branch-Level-8: Add level 8 Store date as LocalDate and allow date conversion from yyyy-mm-dd format to MMM dd yyyy format, # Conflicts: # src/main/java/Deadline.java
# Conflicts: # data/duke.txt # src/main/java/Deadline.java # src/main/java/Duke.java # src/main/java/Event.java # src/main/java/UserInput.java
Allow user to create a new duke.txt if it does not exist at the first place.
New classes Parser(interpret user command), Storage(create file and store data), TaskList(list of tasks) and ui(response to users) are implemented.
All except Duke.java are in duke package now.
Junit to test the output of Todo and Deadline classes
Updates some of the coding styles especially switch and case
Able to search a single keyword and find the matching tasks in the TaskList.
* origin/add-gradle-support: Add Gradle support
teekoksiang
reviewed
Sep 2, 2020
pengxiangg
reviewed
Sep 2, 2020
| * | ||
| * @return a TaskList with tasks stored in the txt file. | ||
| */ | ||
| public TaskList load() { |
There was a problem hiding this comment.
Perhaps a couple of line breaks in this function will improve readability?
There was a problem hiding this comment.
I tried line break but 2103 style check alerts unnecessary line break tho.
Line matches the illegal pattern 'Trailing whitespace'. (16:0) [Regexp]
teekoksiang
reviewed
Sep 2, 2020
yan-soon
reviewed
Sep 3, 2020
yan-soon
reviewed
Sep 3, 2020
…command is not out of scope.
…he user command is not out of scope." This reverts commit 76c9eec.
* 'branch-A-Assertions' of https://github.com/zeying99/ip: Try to re-PR
* branch-A-CodeQuality: Make the happy path more obvious # Conflicts: # src/main/java/duke/Parser.java
This reverts commit 37fcc83.
* 'master' of https://github.com/zeying99/ip: Add javadoc for findMatchingTask
…matches the item only partially.
* 'branch-A-stream' of https://github.com/zeying99/ip: no message merging pr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.