[Daniel Adi.] iP #433
[Daniel Adi.] iP #433
Conversation
src/main/java/TaskManager.java
Outdated
| this.taskList = new ArrayList<Task>(); | ||
| } | ||
|
|
||
| public void parseCommand(String command) throws DukeException { |
There was a problem hiding this comment.
The parseCommand is very clean and neat!
src/main/java/TaskManager.java
Outdated
| int delIndex = Integer.parseInt(temp[1]) - 1; | ||
| deleteTask(delIndex);; | ||
| } else if (command.startsWith("deadline")) { | ||
| if (command.length() <= 9){ |
There was a problem hiding this comment.
Perhaps command.strip() could be used to remove the empty spaces after "deadline"? Was thinking how the code will work if someone input "deadline "
There was a problem hiding this comment.
If someone input "deadline ", which has a length of 9, a DukeException is thrown. Nonetheless, this code is now deprecated and I have pushed a new version.
src/main/java/Deadline.java
Outdated
| @@ -0,0 +1,14 @@ | |||
| public class Deadline extends Task { | |||
There was a problem hiding this comment.
You could consider packaging the code to improve readability
There was a problem hiding this comment.
Noted. Currently working on packaging.
src/main/java/TaskManager.java
Outdated
| @@ -0,0 +1,90 @@ | |||
| import java.util.ArrayList; | |||
|
|
|||
| public class TaskManager { | |||
There was a problem hiding this comment.
Probably one thing you could consider could be to extend ArrayList from taskManager to reduce the amount of code needed to be written
There was a problem hiding this comment.
Do you mind elaborating further on this?
src/main/java/TaskManager.java
Outdated
| this.taskList = new ArrayList<Task>(); | ||
| } | ||
|
|
||
| public void parseCommand(String command) throws DukeException { |
There was a problem hiding this comment.
The parser can possibly be placed in its own class to aid with the parsing of the dateTime objects when they start coming in
There was a problem hiding this comment.
Yup, I just refactored the parser into its own class in my latest version.
src/main/java/TaskManager.java
Outdated
| } | ||
| } | ||
|
|
||
| public void addNewDeadline(String task) throws DukeException { |
There was a problem hiding this comment.
Please consider writing javadocs to aid people reading your code
There was a problem hiding this comment.
Point noted. Currently in the process of adding Javadocs.
src/main/java/ToDo.java
Outdated
| @Override | ||
| public String toString() { | ||
| return "[T]" + super.toString(); | ||
| } |
There was a problem hiding this comment.
Good use of overloading the toString method
src/main/java/TaskManager.java
Outdated
| addNewEvent(command.substring(6)); | ||
| } else if (command.startsWith("todo")) { | ||
| if (command.length() <= 5){ | ||
| throw new DukeException("The description of a todo cannot be empty!"); |
There was a problem hiding this comment.
You could probably consider creating custom exceptions.
There was a problem hiding this comment.
Hmm that has not crossed my mind before. Will consider it for the next version.
src/main/java/TaskManager.java
Outdated
| System.out.println("The following task has been removed: \n" + toDeleteTask); | ||
| } | ||
|
|
||
| public void printList() { |
There was a problem hiding this comment.
One thing to consider here would be that you could override your toString method to save time and code later on
Add assertions
Code quality
No description provided.