[Ngoh Wei Yue] iP #65
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change class Data to Storage for better readability Add classes: * Ui: to interact with users * Parser: to make sense of user inputs * Command and *Command: to extract out commands logic
Automate project builds using Gradle and allow Gradle to run unit test.
Deadline and Event extends Task class that does not have a LocalDateTime attribute. This causes excessive code duplication in checkIfSameDate() in the RetrieveCommand class. Let's, * create a new abstract class called TimedTask that extends Task and contain a LocalDateTime attirbute * extend Deadline and Event class from TimedTask * update checkIfSameDate() in RetrieveCommand class Using polymorphism reduces code duplication and allow the program to be easily expandable.
Adding of different type of Task is done seperately, resulting in code duplication. Unifying the adding of Task improves the code quality. Let's, * create a new AddTaskCommand to replace AddTodoCommand, AddDeadlineCommand and AddEventCommand * update the parser method to return only AddTaskCommand * update test methods
Display a list of commands that Duke can understand.
ParseAddTask does not take into account if there is missing description or date/time. ParseAddTask returns error message asking to input date/time if either description/dateTime is missing. Let's, * Update the error message to a more general one by asking user to input both description and date/time if either one is missing by adding InvalidTaskContentException * Remove NoTaskDateTimeException * Add NoTaskDate for invalid RetrieveCommand
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.