[Sim Jia Ming] iP #316

SimJM · 2022-02-01T17:24:26Z

Duke frees your mind of having to remember things you need to do. It's,

text-based
easy to learn
~~FAST~~ SUPER FAST to use
All you need to do is,

download it from here.
double-click it.
add your tasks.
let it manage your tasks for you 💯

its FREE

tasklist:

done
not done

Here's the main method:

public class Main {
   public static void main(String[] args) {
       Application.launch(MainApp.class, args);
   }
}

tyanhan

Good job overall, I did not notice any basic styling errors. You can improve your code by breaking down long parts into separate functions. All the best!

tyanhan · 2022-02-02T15:11:58Z

src/main/java/Deadline.java

+    }
+
+    @Override
+    String getSym() {


I would opt for a more intuitive name rather than sym.

I would opt for a more intuitive name rather than sym.

Maybe you can change it to a more descriptive name such as symbol?

tyanhan · 2022-02-02T15:13:15Z

src/main/java/Duke.java

+            String phrase = sc.nextLine();
+            System.out.println(DASH);
+
+            if (phrase.equals("list")) {


Perhaps you can consider using a switch statement instead?

The code here is pretty long, but you will get to break it down later as you progress with the iP. Consider doing the printing in separate functions and get your switch statement to invoke those print functions instead.

tyanhan · 2022-02-02T15:15:28Z

src/main/java/Duke.java

+                        String noOfTask = String.format("Now you have %d tasks in the list.", arrlst.size());
+                        System.out.println(noOfTask);
+                    }
+                } catch (ArrayIndexOutOfBoundsException aioobe) { // echo


You can consider changing the parameter name to just e instead.

yongler

LGTM! Just some minor nits to fix

yongler · 2022-02-03T05:31:51Z

src/main/java/Task.java

@@ -0,0 +1,45 @@
+public class Task {


It is possible to change Task to an abstract class?

yongler · 2022-02-03T05:33:04Z

src/main/java/Action.java

@@ -0,0 +1,35 @@
+import java.util.ArrayList;
+
+public class Action {


Looks clean!

yongler · 2022-02-03T05:33:51Z

src/main/java/Deadline.java

+    }
+
+    @Override
+    String getSym() {


I would opt for a more intuitive name rather than sym.

Maybe you can change it to a more descriptive name such as symbol?

yongler · 2022-02-03T05:34:54Z

src/main/java/Duke.java

-        System.out.println("Hello from\n" + logo);
+        Scanner sc = new Scanner(System.in);
+        ArrayList<Task> arrlst = new ArrayList<>();
+        String DASH = "____________________________________________________________";


This works too, but UI can be separated into a class for cleanliess

jetrz

Generally clean code, well documented, styled, and easy to understand. Only minor nitpicks in terms of documentation and code logic here and there. Well done!

jetrz · 2022-02-03T09:37:11Z

src/main/java/Task.java

+    public Task(String description) {
+        this.description = description;
+        this.isDone = false;
+        this.sym = " ";
+    }
+
+    public Task(String description, String sym) {
+        this.description = description;
+        this.isDone = false;
+        this.sym = sym;
+    }
+
+    public String getStatusIcon() {
+        return (isDone ? "X" : " "); // mark done task with X
+    }
+
+    public void markAsDone() {
+        this.isDone = true;
+        System.out.println("Nice! I've marked this task as done:");
+        String output = String.format(" [%s][%s] %s", this.sym, this.getStatusIcon(), this.description);
+        System.out.println(output);
+    }
+
+    public void markAsNotDone() {
+        this.isDone = false;
+        System.out.println("OK, I've marked this task as not done yet:");
+        String output = String.format("  [%s] %s", this.getStatusIcon(), this.description);
+        System.out.println(output);
+    }
+
+    String getSym() {
+        return this.sym;
+    }
+
+    @Override
+    public String toString() {
+        return String.format("added: %s", description);
+    }


Could use some javadocs documentation as Task is the parent class.

jetrz · 2022-02-03T09:39:05Z

src/main/java/Duke.java

+                        for (int i = 1; i < arrWords.length; i++) {
+                            if (arrWords[i].equals("/at")) {
+                                for (int j = i + 1; j < arrWords.length; j++) {
+                                    dayAndTime = dayAndTime + " " + arrWords[j];
+                                }
+                                break;
+                            } else {
+                                remainingWords = remainingWords + " " + arrWords[i];
+                            }
+                        }


Could use comments in places like these to explain what the code is doing (i.e. splitting up the user input) as it may not be apparent on first sight.

jetrz · 2022-02-03T09:40:21Z

src/main/java/Action.java

+    void showList(ArrayList<Task> arrlst) {
+        System.out.println("Here are the tasks in your list:");
+        for (int i =  0; i < arrlst.size(); i++) {
+            String output = String.format("%d.[%s][%s]%s\n", i + 1, arrlst.get(i).sym,
+                                             arrlst.get(i).getStatusIcon(), arrlst.get(i).description);
+            System.out.println(output);
+        }
+    }


Could use a javadocs documentation.

jetrz · 2022-02-03T09:45:59Z

src/main/java/Event.java

+    @Override
+    String getSym() {
+        return this.sym;
+    }


May I check what is the purpose of this override? Same with deadline and todo classes. Seems redundant as the getSym() in Task is the same.

KwanHW · 2022-02-03T17:48:21Z

src/main/java/Task.java

@@ -0,0 +1,45 @@
+public class Task {
+    protected String description;


While protected may appear sufficient, these attributes can still be accessible by other functions once you start putting them into packages. Consider changing your attributes to private

KwanHW · 2022-02-03T17:52:00Z

src/main/java/Task.java

+
+    @Override
+    public String toString() {
+        return String.format("added: %s", description);


I think you should change your toString() method to print out the sym, isDone and description instead of this message. This can reduce code duplication in your children classes as I observed that they are using attributes in Task to form the string.

KwanHW · 2022-02-03T17:57:20Z

src/main/java/Task.java

+        System.out.println(output);
+    }
+
+    String getSym() {


Missing public keyword at function signature

KwanHW · 2022-02-03T18:00:28Z

Good effort overall.

Some improvements to consider:

Possible use of enums for sym
Naming of variables (as mentioned by your classmates)
Code duplication / Abstraction Task.toString()
Double check your function signature headers throughout your project

This reverts commit 832f67b.

This reverts commit 507c6a3.

# Conflicts: # src/main/java/duke/Parser.java

…ent the GUI

Assert that isDone must be false to get " " from getStatusIcon() method.

Add update into help function

damithc and others added 10 commits July 29, 2021 20:30

Add Gradle support

d839859

Level1. Greet,Echo,Exit

6b8c2f2

add Action class

778d1e0

Level-2: added readBook(), returnBook()

8009280

Level-3: Mark as Done. Added Task class

8fa8a55

Level-4: todo, deadline, event

3357573

A-TextUiTesting

f2fabf0

Level-5 Handle Errors

a210a0f

Level-6 delete

8a7ee50

A-Enums

a51d3f3

SimJM changed the title ~~Sim Jia~~ Sim Jia Ming iP Feb 1, 2022

SimJM changed the title ~~Sim Jia Ming iP~~ [Sim Jia Ming] iP Feb 1, 2022

tyanhan reviewed Feb 2, 2022

View reviewed changes

yongler approved these changes Feb 3, 2022

View reviewed changes

jetrz reviewed Feb 3, 2022

View reviewed changes

KwanHW reviewed Feb 3, 2022

View reviewed changes

src/main/java/Task.java Outdated

System.out.println(output);

}

String getSym() {

Copy link

KwanHW Feb 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing public keyword at function signature

SimJM added 11 commits February 6, 2022 15:37

refactor code (add TaskBank, Parser, User class)

5b8561d

Level-7 Save

3d7329e

minor edits

5dcf7b0

incomplete branch

6b65fea

Add LocalDate and format date

4ab3dac

implement date format

832f67b

Revert "implement date format"

507c6a3

This reverts commit 832f67b.

Revert "Revert "implement date format""

7f7f081

This reverts commit 507c6a3.

Level 8 - add date format

b8d7f64

A-MoreOOP - Ui class

70d14c8

A-Packages: organize classes into duke package

8695409

SimJM and others added 30 commits February 16, 2022 17:51

Merge branch 'branch-A-CodingStandard'

dee52c7

Merge branch 'branch-Level-9'

e1ccf9d

# Conflicts: # src/main/java/duke/Parser.java

Merge commit 'd8398594b7bc43da5eb865321c5a50cec4b3923d'

3c83a87

A-CheckStyle - edit coding style violations

a018811

Level-10 GUI - add a GUI to Duke. Use the JavaFX technology to implem…

fe06e8f

…ent the GUI

A-Varargs - not applicable

b3a9390

Add assertion

53330a6

Assert that isDone must be false to get " " from getStatusIcon() method.

Improve code quality

8cfee6f

Merge branch 'branch-A-CodeQuality'

4aaed72

C-update - easily edit description of the Task

25c776d

Improve the GUI

807bab5

Improve GUI

ba460f1

Edit on code quality

ae805b1

Add update into help function

70a7cf8

Merge branch 'master' into branch-C-update

b5a30d2

Merge pull request #2 from SimJM/branch-C-update

6992122

Add update into help function

tidy up code

9e89a02

Set theme jekyll-theme-merlot

f56ff47

upload Ui.png

9181b89

Merge branch 'master' of https://github.com/SimJM/ip

a914019

Update README.md

046d881

Update README.md

000f5a1

Add exception handling in parser

8ed816b

Add exception handling

b7ec4fe

Add output

09593f8

Update README

98566a3

Update README.md

d232468

Update README.md

4352935

Update README.md

f3191a8

Update README.md

3bc0613

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Sim Jia Ming] iP #316

[Sim Jia Ming] iP #316

SimJM commented Feb 1, 2022 •

edited

tyanhan left a comment

tyanhan Feb 2, 2022

yongler Feb 3, 2022

tyanhan Feb 2, 2022

tyanhan Feb 2, 2022

tyanhan Feb 2, 2022

yongler left a comment

yongler Feb 3, 2022

yongler Feb 3, 2022

yongler Feb 3, 2022

yongler Feb 3, 2022

jetrz left a comment

jetrz Feb 3, 2022

jetrz Feb 3, 2022

jetrz Feb 3, 2022

jetrz Feb 3, 2022

KwanHW Feb 3, 2022 •

edited

KwanHW Feb 3, 2022

KwanHW Feb 3, 2022

KwanHW commented Feb 3, 2022

		@@ -0,0 +1,35 @@
		import java.util.ArrayList;

		public class Action {

		@@ -0,0 +1,45 @@
		public class Task {
		protected String description;

[Sim Jia Ming] iP #316

Are you sure you want to change the base?

[Sim Jia Ming] iP #316

Conversation

SimJM commented Feb 1, 2022 • edited

tyanhan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yongler left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jetrz left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

KwanHW Feb 3, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

KwanHW commented Feb 3, 2022

SimJM commented Feb 1, 2022 •

edited

KwanHW Feb 3, 2022 •

edited