Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overzealous Phone Number Validation #5779

Open
nus-pe-bot opened this issue Nov 11, 2022 · 1 comment
Open

Overzealous Phone Number Validation #5779

nus-pe-bot opened this issue Nov 11, 2022 · 1 comment

Comments

@nus-pe-bot
Copy link

nus-pe-bot commented Nov 11, 2022

image.png

As the target user is "tech leads" and not "teach leads based for companies based in Singapore", the validation of only 8 digits long phone number is inappropriate, as numbers from other parts of the world do not consist of exactly 8 digits


[original: nus-cs2103-AY2223S1/pe-interim#5772] [original labels: severity.Medium type.FunctionalityBug]
@TJun-Jie
Copy link
Contributor

Team's Response

As of right now, it is rather difficult to implement a differentiation of phone number by countries. It is possible to have 2 same phone number from 2 different countries so for now, we restrict it to just Singapore phone numbers. In future implementation, we will implement country code tagging to the phone number to fix this issue.

Duplicate status (if any):

--

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants