[Jarrett0203] iP #10

Jarrett0203 · 2023-01-17T10:17:01Z

Fate Eggplant Assistant (FEA)

"The Archer class really is made up of archers!" -- Rin Tohsaka (source)

FEA lets you focus on defeating lostbelts by having Mash remember things you need to do. It's,

text-based
easy to learn
~~FAST~~ SUPER FAST to use

All you need to do is,

Download it from here.
Find the latest version and install fea.jar.
Add your tasks.
Let Mash manage your tasks for you 😉

And it is FREE!

Features:

Managing tasks
Managing deadlines (coming soon)
Reminders (coming soon)

If you are a Java programmer, you can use it to practice Java too. Here's the main method:

public class Duke {
   public static void main(String[] args) { 
      Application.launch(Fea.class, args);
   }
}

This is to add assertions for FEA in the unlikely event that data file gets corrupted when updating tasks.

Refactoring code to make it more readable for others.

pangrwa

Overall, I like the structure of your code and is very readable. However, I think you can improve on certain aspects of code quality. For an example, there are a couple of methods that have quite deep nesting. Keep it up!

pangrwa · 2023-02-03T10:16:38Z

src/main/java/fea/commands/AddCommand.java

+            }
+        default:
+            throw new InvalidInputException(INVALID_UNKNOWN);
+        }


Perhaps for this method you might want to consider separating parts of the logic into another method to avoid this rather long method, so that it's easier to debug.

pangrwa · 2023-02-03T10:17:46Z

src/main/java/fea/commands/AddCommand.java

+    private static final String INVALID_DEADLINE_FORMAT = "The deadline must be in the format:"
+        + " deadline <task> /by <date>, <task> and <date> cannot be empty.";
+    private static final String INVALID_EVENT_FORMAT = "The event must be in the format:"
+        + " event <task> /from <date> /to <date>, <task> and <date> cannot be empty.";
+    private static final String INVALID_DATE_FORMAT =
+            "Dates must be in the format: dd/mm/yyyy HHmm (e.g. 12/12/2023 1800)";
+    private static final String INVALID_UNKNOWN = "I'm sorry, but I don't know what that means.";
+    private static final String END_BEFORE_START = "The start date must be before the end date.";
+    private static final String FULL_LIST = "List is full!";


The use of constant string lines is great and really thoughtful! It does help to abstract your code.

pangrwa · 2023-02-03T10:18:27Z

src/main/java/fea/commands/DeleteCommand.java

+    public String execute(TaskList tasks, Ui ui, Storage storage) throws FeaException {
+        try {
+            int taskNum = Integer.parseInt(fullCommand.substring(7));
+            if (taskNum > tasks.size() || taskNum < 1) {


Maybe you could consider abstracting the boolean expression to avoid complicated expressions.

pangrwa · 2023-02-03T10:19:01Z

src/main/java/fea/parser/Parser.java

+        String lowercaseCommand = fullCommand.toLowerCase();
+        Command command;
+        if (lowercaseCommand.equals("bye")) {
+            command = new ByeCommand();
+        } else if (lowercaseCommand.equals("list")) {
+            command = new ListCommand();
+        } else if (lowercaseCommand.startsWith("todo")) {
+            command = new AddCommand('T', fullCommand);
+        } else if (lowercaseCommand.startsWith("deadline")) {
+            command = new AddCommand('D', fullCommand);
+        } else if (lowercaseCommand.startsWith("event")) {
+            command = new AddCommand('E', fullCommand);
+        } else if (lowercaseCommand.startsWith("delete")) {
+            command = new DeleteCommand(fullCommand);
+        } else if (lowercaseCommand.contains("mark")) {
+            command = new MarkCommand(!lowercaseCommand.startsWith("unmark"), fullCommand);
+        } else if (lowercaseCommand.startsWith("find")) {
+            command = new FindCommand(fullCommand);


Very neat and readable!

pangrwa · 2023-02-03T10:19:52Z

src/main/java/fea/storage/Storage.java

+                checkTaskFormat(args[0], args[1]);
+                switch (args[0]) {
+                case "T":
+                    Todo newTodo = new Todo(args[2]);
+                    if (args[1].equals("1")) {
+                        newTodo.toggleMark();
+                    }
+                    loadedList.add(newTodo);
+                    break;
+                case "D":
+                    Deadline newDeadline = new Deadline(args[2], LocalDateTime.parse(args[3], formatter));
+                    if (args[1].equals("1")) {
+                        newDeadline.toggleMark();
+                    }
+                    loadedList.add(newDeadline);
+                    break;
+                case "E":
+                    Event newEvent = new Event(args[2], LocalDateTime.parse(args[3], formatter),
+                            LocalDateTime.parse(args[4], formatter));
+                    if (args[1].equals("1")) {
+                        newEvent.toggleMark();
+                    }
+                    loadedList.add(newEvent);
+                    break;
+                default:
+                    break;
+                }
+            }


Seems like there is quite a deep nesting here. Might want to consider abstracting some parts out.

Douglch

The code overall is really neat, liked the use of constant naming and how you separated the command classes. Good job! 👍

Douglch · 2023-02-04T03:03:22Z

src/main/java/fea/commands/InvalidCommand.java

+ * InvalidCommand class that implements the Command interface.
+ */
+
+public class InvalidCommand implements Command {


Perhaps this could be refactored to the exception package instead?

Douglch · 2023-02-04T03:20:23Z

src/main/java/fea/storage/Storage.java

+
+        try (FileWriter fileWriter = new FileWriter(file)) {
+            for (Task task : tasks) {
+                int mark = task.getMark().equals('X') ? 1 : 0;


If I'm not wrong, using instanceof is usually a bad practice as it misses out on OOP design, maybe you could try creating/using the respective task class's functions to do the checks instead?

Other that that, very clean way of saving tasks

Douglch · 2023-02-04T03:24:41Z

src/main/java/fea/ui/Ui.java

+    /**
+     * Prints task when it is added or removed.
+     *
+     * @param task     The task to be printed.


Think there's unnecessary white space between task and The

Douglch · 2023-02-04T03:26:36Z

src/main/java/fea/ui/Ui.java

+     * @return String The string of the task to be marked.
+     */
+    public String printMarkTask(Task task, boolean toMark) {
+        StringBuilder message = new StringBuilder();


Perhaps you would want to create one instance of StringBuilder for the entire class, then calling sb.setLength(0) at the start to clear the string builder, instead of creating multiple instances?

glyfy

Good job overall

glyfy · 2023-02-05T11:17:31Z

src/main/java/fea/commands/AddCommand.java

+        if (tasks.size() >= 100) {
+            throw new ListException(FULL_LIST);
+        }
+        switch (taskType) {


I like the use of switch statement here for efficiency!

glyfy · 2023-02-05T11:18:25Z

src/main/java/fea/commands/DeleteCommand.java

+    public String execute(TaskList tasks, Ui ui, Storage storage) throws FeaException {
+        try {
+            int taskNum = Integer.parseInt(fullCommand.substring(7));
+            if (taskNum > tasks.size() || taskNum < 1) {


Maybe you can change the logic to avoid complicated expressions?

damithc and others added 22 commits July 31, 2022 17:20

Add Gradle support

556af3f

finished level 1

d2d0000

finished level 2

7d0d57d

finished level 3

eb4f2ff

finished level 4

dcd64f9

finished A-TextUiTesting

923f3c7

finished level 5

8aae9d7

finished level 6

8a72c84

finished level 7

3f1d107

finished level 8

9883725

Merge branch 'branch-Level-7'

e92d0b2

Merge branch 'branch-Level-8'

d4ef9c6

finish A-MoreOOP

da09cff

finish A-Packages

5d5cada

Merge remote-tracking branch 'origin/add-gradle-support'

9ddfe0d

Finish A-Gradle

e19134c

Finish A-JUnit

5adbfe2

Change mainClassName for A-Jar

51a4e6f

Finish A-JavaDoc

14f6a10

Finish A-CodingStandard

5499a62

Finish Level-9

9f6c521

Merge remote-tracking branch 'origin/branch-A-JavaDoc'

bba1a15

Jarrett0203 force-pushed the master branch from e814c6f to bba1a15 Compare January 22, 2023 14:21

Jarrett0203 added 7 commits January 22, 2023 22:37

Merge branch 'branch-A-CodingStandard'

828019b

Merge branch 'branch-Level-9'

f8ee032

Fix some JavaDocs spacing

c02dece

update README.md

a38ba81

Finish Level-10

f0abed3

Merge branch 'branch-Level-10'

67ff550

Remove text-ui-test folder as GUI is implemented

c29733d

Jarrett0203 added 9 commits January 31, 2023 10:28

Finish A-Assertions

b28f83f

This is to add assertions for FEA in the unlikely event that data file gets corrupted when updating tasks.

Merge pull request #1 from Jarrett0203/branch-A-Assertions

9af50e0

Finish A-CodeQuality

84c2de5

Refactoring code to make it more readable for others.

Merge branch 'master' into branch-A-CodeQuality

f5947af

Merge pull request #2 from Jarrett0203/branch-A-CodeQuality

8d2540d

Finish A-CI

9e9ebbe

Fix checkstyle errors

660dd03

Merge pull request #3 from Jarrett0203/branch-A-CI

aaea45a

Fix previous merge conflict issues with A-CodingQuality

ed0a5c8

pangrwa reviewed Feb 3, 2023

View reviewed changes

Douglch reviewed Feb 4, 2023

View reviewed changes

francisyzy mentioned this pull request Feb 4, 2023

Branch a varargs #393

Closed

glyfy reviewed Feb 5, 2023

View reviewed changes

Jarrett0203 added 7 commits February 6, 2023 21:40

Finish B-Reminders

95856a9

Update README.md

ceb0fd9

Update README.md

9e205ee

Finish A-UserGuide

3b71592

Merge branch 'master' of https://github.com/Jarrett0203/ip

eb20c03

Fix unsupported profile pictures on linux

4b1109c

Fix missing dependencies for linux

f881258

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Jarrett0203] iP #10

[Jarrett0203] iP #10

Jarrett0203 commented Jan 17, 2023 •

edited

pangrwa left a comment

pangrwa Feb 3, 2023

pangrwa Feb 3, 2023

pangrwa Feb 3, 2023

pangrwa Feb 3, 2023

pangrwa Feb 3, 2023

Douglch left a comment

Douglch Feb 4, 2023

Douglch Feb 4, 2023

Douglch Feb 4, 2023

Douglch Feb 4, 2023

Douglch Feb 4, 2023

glyfy left a comment

glyfy Feb 5, 2023

glyfy Feb 5, 2023

[Jarrett0203] iP #10

Are you sure you want to change the base?

[Jarrett0203] iP #10

Conversation

Jarrett0203 commented Jan 17, 2023 • edited

Fate Eggplant Assistant (FEA)

pangrwa left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Douglch left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

glyfy left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Jarrett0203 commented Jan 17, 2023 •

edited