[wongyx] iP #112

wongyx · 2023-01-23T03:18:29Z

Duke

Duke helps you to keep track of upcoming tasks that you might have. It's

text-based
~~easy~~ VERY EASY to use

You just need to

Download it from here
Run the ip.jar file
Add some task in
Let Duke keep track of all your task easily

And it is FREE

Features include:

Managing tasks
Reminders (coming soon) 🚧

Here's the main method of Duke:

public static void main(String[] args) {
    new Duke("data/tasks.txt").run();
}

This file contains backend data for the program Files containing backend data should not be on the repo, hence it is deleted

Most of the code is written under main. Extracting closely related code into classes and placing them into packages improves the code quality. Let's create multiple classes to deal with related parts of the code and package them together.

Mark, Unmark and Delete Commands do not save after execution. This commits fixes these issues.

glozxi

Maybe change code to follow the coding standard, but overall I like it.

glozxi · 2023-02-01T08:15:39Z

src/main/java/duke/Parser.java

+        throws TaskNoDescriptionException, NotEnoughArgumentsException, DateTimeParseException {
+        String info = fullCommand.substring(8).trim();
+        if (info.isEmpty()) {
+            throw(new TaskNoDescriptionException("OOPS!!! The description of a deadline cannot be empty."));


I have noticed that you put parentheses around new thrown exceptions. I don't think that is against the coding standards, but perhaps leave a space between throw and (. This is because throw is a Java reserved word, so should be followed by a white space.

glozxi · 2023-02-01T08:20:07Z

src/main/java/duke/Parser.java

+    public static Command parse(String fullCommand) {
+        String[] commandParts = fullCommand.split(" ", 2);
+        String commandHeader = commandParts[0];
+        switch (commandHeader) {


You might want to unindent switch cases.

glozxi · 2023-02-01T08:24:29Z

src/main/java/duke/commands/AddCommand.java

@@ -0,0 +1,28 @@
+package duke.commands;
+
+/** This is a command to add a task to Duke


Can put /** on separate line

glozxi · 2023-02-01T08:28:54Z

src/main/java/duke/Parser.java

+import java.time.format.DateTimeParseException;
+
+/**
+ * This is a class responsible for parsing the inputs given by user


Perhaps put punctuation behind each parameter description. I have noticed this in other places too.

glozxi · 2023-02-01T08:30:29Z

src/main/java/duke/tasks/Event.java

+    public Event(String description, LocalDate from, LocalDate to, boolean isDone) {
+        super(description, isDone);
+        this.from = from;
+        this.to= to;


Maybe a space around the =?

glozxi · 2023-02-01T08:33:47Z

src/main/java/duke/commands/Command.java

+    public abstract boolean isExit();
+
+    public abstract String execute(TaskList taskList, Ui ui, Storage storage);
+}


I like how you used OOP for the commands.

glozxi · 2023-02-01T08:35:50Z

src/main/java/duke/Parser.java

+    public static Command parse(String fullCommand) {
+        String[] commandParts = fullCommand.split(" ", 2);
+        String commandHeader = commandParts[0];
+        switch (commandHeader) {


Perhaps you could think about using enums for the command types?

pkwangjoo · 2023-02-04T16:18:48Z

src/main/java/duke/Parser.java

+    public static Command parse(String fullCommand) {
+        String[] commandParts = fullCommand.split(" ", 2);
+        String commandHeader = commandParts[0];
+        switch (commandHeader) {


Perhaps you could unindent switch cases?

pkwangjoo · 2023-02-04T16:23:15Z

src/test/java/duke/ParserTest.java

+        Command c = Parser.parse("deadline grocery /by 19/10/2023");
+        LocalDate date = LocalDate.parse("19/10/2023", DateTimeFormatter.ofPattern("d/MM/yyyy"));
+        AddDeadlineCommand test = new AddDeadlineCommand("grocery", date);
+        //AddTodoCommand test = new AddTodoCommand("grocery");


Perhaps unused code can be deleted

pkwangjoo · 2023-02-04T16:25:02Z

src/main/java/duke/tasks/Todo.java

+        }
+
+        Todo t = (Todo) o;
+        if (this.description.equals(t.description)) {


A minor nit but perhaps this boolean value could be returned directly.

pkwangjoo · 2023-02-04T16:28:25Z

src/main/java/duke/TaskList.java

+     */
+    public TaskList(ArrayList<Task> tasks) {
+        this.tasks = tasks;
+        this.counter = tasks.size();


Maybe you could name counter as size for clearer naming?

Code has some parts that does not follow coding standards. Changing the code to follow coding standards will help improve readability and quality of the code.

Improve code quality

Add assertions

damithc and others added 11 commits July 31, 2022 17:20

Add Gradle support

556af3f

Added Level-1

a76b9e1

Added Level-2

5976f37

Added Level-3

ea3d39c

Added Level-4

9c9b900

Added A-TextUiTesting

a9ef489

Added Level-5

634216d

Added Level-6

6ce91c7

Add Level-7

b89736a

Add Level-8

bb6dcf4

Merge Level-7 and Level-8

10b63f0

wongyx force-pushed the master branch from a33abb7 to 10b63f0 Compare January 24, 2023 10:20

wongyx and others added 14 commits January 24, 2023 18:30

Delete data file

6d321e6

This file contains backend data for the program Files containing backend data should not be on the repo, hence it is deleted

Add multiple classes and package

fd6f6cb

Most of the code is written under main. Extracting closely related code into classes and placing them into packages improves the code quality. Let's create multiple classes to deal with related parts of the code and package them together.

Merge branch 'master' of https://github.com/wongyx/ip

d81c064

Merge branch 'add-gradle-support'

9d454c1

Add gradle support for running Duke

424decb

Add JUnit test for some classes

474e791

Add javadocs to most classes

3d7fe56

Add feature for finding tasks

1cbf6ee

Merge branch 'branch-Level-9'

c616f9c

Change code to comply with coding standards

c2d8c2f

Merge branch 'branch-A-CodingStandard'

9d5c6a4

Merge JavaDoc, CodingStandard and Level-9

01ad0c8

Fix an issue where data is not properly saved

ef5d951

Mark, Unmark and Delete Commands do not save after execution. This commits fixes these issues.

Add GUI to Duke

7b36f2c

glozxi reviewed Feb 1, 2023

View reviewed changes

pkwangjoo reviewed Feb 4, 2023

View reviewed changes

wongyx added 2 commits February 5, 2023 12:10

Improve code quality

8547313

Code has some parts that does not follow coding standards. Changing the code to follow coding standards will help improve readability and quality of the code.

Add assertions

2715fc2

wongyx and others added 7 commits February 5, 2023 12:32

Merge pull request #2 from wongyx/branch-A-CodeQuality

0adfd02

Improve code quality

Merge branch 'master' into branch-A-Assertions

a83c99f

Merge pull request #1 from wongyx/branch-A-Assertions

6a89e33

Add assertions

Add feature to reject duplicated tasks

67ca66f

Fix a bug where user can mark invalid task

1db7ebf

Update user guide and Ui.png

21142ee

Release v0.2

111ec20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[wongyx] iP #112

[wongyx] iP #112

wongyx commented Jan 23, 2023 •

edited

glozxi left a comment

glozxi Feb 1, 2023

glozxi Feb 1, 2023

glozxi Feb 1, 2023

glozxi Feb 1, 2023

glozxi Feb 1, 2023

glozxi Feb 1, 2023

glozxi Feb 1, 2023

pkwangjoo Feb 4, 2023

pkwangjoo Feb 4, 2023

pkwangjoo Feb 4, 2023

pkwangjoo Feb 4, 2023

		@@ -0,0 +1,28 @@
		package duke.commands;

		/** This is a command to add a task to Duke

[wongyx] iP #112

Are you sure you want to change the base?

[wongyx] iP #112

Conversation

wongyx commented Jan 23, 2023 • edited

Duke

glozxi left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wongyx commented Jan 23, 2023 •

edited