[Irminrics] iP #12
Open
[Irminrics] iP #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details: Dude is using LocalDateTime for task details
Details: Added validation to Dude's deletion task
Conflicts to be resolved in the next commit: Event.java, Dude.java
He is now lacking validations for commands and will be fixed soon.
amoonguss1
reviewed
Feb 2, 2023
Comment on lines
26
to
28
| public enum CommandType { | ||
| LIST, MARK, UNMARK, TODO, DEADLINE, EVENT, DELETE, FIND, BYE | ||
| } |
There was a problem hiding this comment.
I like how you used enums to ensure type safety of the commands.
| * @param command Command input provided by user. | ||
| * @throws DudeException If command is not valid. | ||
| */ | ||
| public static void validate(CommandType commandType, String command) throws DudeException { |
There was a problem hiding this comment.
I think this is a smart way to handle the input exceptions!
src/main/java/dude/Dude.java
Outdated
Comment on lines
37
to
39
| /** | ||
| * Runs Dude program. | ||
| */ |
There was a problem hiding this comment.
I feel like this could be a bit more descriptive.
| /** | ||
| * Handles the entire dude program | ||
| */ | ||
| public class Dude { |
Dude has no assertions Assertions are used to define assumptions about the program state so that the runtime can verify them. Let's add assertions to check for functions preconditions/parameter This ensures that the inputs for functions are validated and ensured for correctness
Add assertions
Dude has no usage of guard clause Guard clause helps to keep the main/happy path unindented Let's add guard clause to the execute function in MarkCommand and UnmarkCommand This deals with unusual conditions as soon as they are detected so that the reader does not have to remember them for long
Improve Code Quality
Users of Dude are unable to undo their previous command. This is a quality of life feature which allows them to undo mistakes. Let's add a feature which saves the previous state of task list for the users to undo upon a new command.
Add undo feature
…d Unmark commands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dude
Dude frees your mind of having to remember things you need to do. It's,
All you need to do is,
And it is FREE!
Features:
If you are a Java programmer, you can use it to practice Java too. Here's the
mainmethod: