[cydtseng] iP #136
Open
[cydtseng] iP #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/main/java/Deadline.java # src/main/java/Duke.java # src/main/java/Event.java
# Conflicts: # src/main/java/duke/Deadline.java # src/main/java/duke/Duke.java # src/main/java/duke/DukeException.java # src/main/java/duke/Event.java # src/main/java/duke/Todo.java # src/main/java/duke/Ui.java
|
|
||
| public static void saveTasksToFile(ArrayList<Task> taskList) { | ||
| try { | ||
| String toWrite = ""; |
There was a problem hiding this comment.
A little pedantic, but it might be better to use a noun for this String, such as tasksToWrite
src/test/java/ParserTest.java
Outdated
| public void testParseByeCommand(){ | ||
| Assertions.assertTrue(parser.isByeCommand("bye")); | ||
| Assertions.assertTrue(parser.isByeCommand("bye ")); | ||
| Assertions.assertTrue(parser.isByeCommand(" bye")); |
There was a problem hiding this comment.
It's great that you're testing these edge cases!
| public class Parser { | ||
| private final Stage stage; | ||
|
|
||
| public enum CmdType { |
There was a problem hiding this comment.
enum constants should be in SCREAMING_SNAKE_CASE
src/main/java/duke/Parser.java
Outdated
| return userInput.split(" ")[0].equals(CmdType.find.name()); | ||
| } | ||
|
|
||
| public String parseCommandWithResponse(String userInput) { |
There was a problem hiding this comment.
This method seems way too long. As a suggestion, perhaps you could break your method up into handleByeCommand, handleMarkCommand etc so it's easier to debug.
For now, assertions have been added to the DialogBox class and the Storage class. The assertions are to check assumptions of non null imageviews and dialogbox labels as well as storage file directory and saved task file existence. This was referenced in enabling assertions https://se-education.org/guides/tutorials/intellijUsefulSettings.html
Update project with assertions enabled for intellij and gradle
Refactor some code that does not adhere to SLAP
Add help command to show all possible command formats for users
colors and fonts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duke Project
The Duke Project is a chatbot based todo list with the following features
How to run:
Interactivity progress:
Entry point
mainof Duke program.