[9fc70c892] iP #142
Open
[9fc70c892] iP #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lay them back to the user when requested.
Added Add, List for Level 2 (Note : No sanitization and checks if index is possible or not)
…ndled and breaking switch cases into functions, potentially creating a 'taskmaster' class.
…res rework of input handling. Also current input allows missing description provided /by is present i.e. `deadline /by string`.
…ushback. This req overhaul.
Added functionality as required by Level-7.
Minimum handling of datetime has been added. Expect merge conflict with other branches due to changing child classes of TaskMaster input.
# Conflicts: # src/main/java/Deadline.java # src/main/java/Event.java # src/main/java/TaskMaster.java
Incomplete, however, this is primary commit.
Broke code due to parser.
Fixed errors due to refactor. See issues for improvable items.
Completion of Minimal criteria for A-Gradle, less style check
Minimal auto testing of two methods to fulfill A-JUnit
Commit to mark that JavaDocs were added previously in previous weeks. Yet to standardize and fill all.
Level-7 Required auto loading upon startup, this was not added in for that particular tag.
This reverts commit 894f944.
Added auto load functionality that was missing during Level-7 Push
# Conflicts: # src/main/java/core/DukeIO.java
# Conflicts: # src/main/java/core/DukeIO.java
Greetings wrongly fed into getResponse.
jerome-neo
reviewed
Feb 2, 2023
There was a problem hiding this comment.
Your code looks really neat and readable. To summarise, the names of methods are in camelCase, abbreviations of acronyms were not uppercased when used as part of a name, booleans of labels sound like boolean, brackets in Egyptian style, correct white spacing and every class is part of some package.
Made changes to code based on PR comments provided by other students to improve code quality
Added B-Reminder. Reads all deadline and gets the one with the latest deadline. Works with multiple deadlines of the same time.
Test for Add Increments as PR
Fixed remove to fix issue posted on github. Realized that date formatting is not correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waffles
🧇 An alternative to Duke. 🧇
Are you looking for task manager that is:
Waffles got you covered.
Features:
Download:
If you are a Java programmer, you can experiment or add on to our Source Code!