-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mandykqh] iP #143
Open
mandykqh
wants to merge
60
commits into
nus-cs2103-AY2223S2:master
Choose a base branch
from
mandykqh:master
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[mandykqh] iP #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b4c03d7.
# Conflicts: # src/main/java/genie/Storage.java # src/main/java/genie/TaskList.java # src/main/java/genie/Ui.java
# Conflicts: # src/main/java/genie/task/Task.java
The application boots up a blank window that waits for user's input. Receiving Genie's greeting first gives a more 'complete' appearance and ensures that the application has started successfully. Follows weak SLAP principle as there is no abstraction of the greeting message due to FXML load exception when done so.
There are assumptions in the values passed in methods that are not defined. Assertions are used to define these assumptions. Assertion failure can help detect bugs in the code at runtime.
Some code does not follow good code quality. Refactor the code to improve code quality, such as minimizing complicated expressions, magic numbers, renaming variables, following SLAP principle, etc. This helps to maximize readability for other readers too.
Implement A-Assertions
# Conflicts: # src/main/java/genie/command/AddCommand.java # src/main/java/genie/main/Parser.java # src/main/java/genie/main/TaskList.java
Implement A-CodeQuality
New users using the app are not familiar with the commands to use. Adding a "help" command allows users to familiarize themselves with the commands. The help message is also shown when Genie first launches. First-time users are immediately given guidance, and new users are given guidance at any point of time using the "help" command.
Contents of .txt file disappears after reading. Users with existing saved data cannot view their list when launching the app. Showing the list upon launching the app serves as a refresher for existing users. When there're no contents in the .txt file, assume that the user is new and shows the help message instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Genie
GeniePro frees your mind of having to remember things you need to do. It's,
FASTSUPER FAST to usedownload the most recent release of genie.jar from here.
And it is FREE!
Features:
If you are a Java programmer, here's the
main
method that launches Genie: