-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Zxun2] iP #15
Open
Zxun2
wants to merge
78
commits into
nus-cs2103-AY2223S2:master
Choose a base branch
from
Zxun2:master
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Zxun2] iP #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/main/java/entities/Deadline.java # src/main/java/entities/Event.java # src/main/java/entities/Task.java
There are several methods throughout the codebase with internal invariants that were assumed but not checked. Adding assertions verifies the assumptions made about the program state so that the runtime can verify them. As a step towards ensuring code correctness in production, let's add assertions into the codebase where necessary.
There are several code quality violations throughout the codebase. In some cases, there are code duplication. Improving the code quality allows for greater understandability and readability. As a step towards increased readability, let's add fix the obvious violations and extract duplicate code blocks into separate methods.
Add A-Assertions
# Conflicts: # src/main/java/duke/storage/Storage.java
Add A-CodeQuality
# Conflicts: # src/main/java/duke/entities/TaskList.java # src/main/java/duke/storage/Storage.java
Add A-Streams
Add Github Workflow
A manual process is required to undo a command that was accidentally entered in. For example, if the user adds a task, and decides he wants to undo it, he/she would need to manually enter a delete command and specifies the task to be deleted. The same can be said for mark and unmark commands. With undo, this entire process can be reduced to a single keyword, "undo". The undo operation is enabled by keeping track of the last 10 changes. When the undo command is entered, the most recent changed state is popped and replaces the current state. With these changes, it allows for version control to take place as well. User can now checkout to a specified version number and save accordingly. Let's implement the undo function to improve the user experience and enhance the quality of the application.
Add C-Undo and Version Control
- Update error message for invalid format - Improve error handling for list command - Update header comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DukePro
DukePro frees your mind of having to remember things you need to do. It's,
FASTSUPER FAST to useAll you need to do is,
And it is FREE!
Features:
If you Java programmer, you can use it to practice Java too. Here's the
main
method: