[axmszr] iP #153
Open
[axmszr] iP #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed name to Cbot (should I change the .java file name too?)
ToDo class to maintain list Duke modified
Task class, as suggested by website Added some error catching and stuff for commands
No idea how it got here oops.
Made Command an enum, and the corresponding changes to Cbot
Already had some, just made the no-input case more explicit Didn't use exceptions
Not much change! Just added one Command and one in the switch
Add Filter, Before, After and Sort commands
* branch-Level-7: Add Level 7 functionality # Conflicts: # src/main/java/Cbot.java # src/main/java/Command.java # src/main/java/Deadline.java # src/main/java/Event.java # src/main/java/TaskList.java
Add done/undone options to Filter
Add custom exceptions
Struggle a bit Clean up Command
Clean up import statements Parser: slightly modify task symbol use
Modify slightly for Java 11 standards
Run JUnit tests with Gradle
Add some QoL stuff by allowing not-all-lower case
Improve Code Quality
Use Streams
Add C-MassOps allowance for MARK, UNMARK and DELETE/REMOVE
Branch BCD Extension
Streamline text extraction a bit.
With the recent change to text parsing, it is more likely for assertions to be violated. This is especially true for the runCommand functions, where we want to ensure only the correct Commands are accessing them. Let's clarify the assert messages of the runCommand functions. If we remove ambiguity from which is which, it will be easier to debug.
The Command class code is ridiculously long, and a little messy. It is difficult to find the start of the static runCommand functions, for example. Splitting up these sections into their own classes will neaten things up and improve readability. Let's, * extract ThrowingBiFunction from Command into its own .java file * extract the static runCommand methods into a separate class CommandFunction * re-package all these Command-related classes (as well as the InputExceptions) into cbot.command This refactoring will make the code more navigable and make it easier to add more features in the future.
Task: fix grammar in editDisc JavaDoc; TaskList: remove dead code;
CommandFunction: assert correct Command type; Slightly modify how inputs processed to enable the above.
Add final increments
… of closing immediately.
Allow the user to see the farewell message
Add UI.png.
docs/README: change Usage heading to Commands
docs/README: update accordingly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cbot
Upgrade your to-do list, today.
Is speaking too much of a hassle? Does your voice-recognition not recognize your voice? Really wish you could go back to the ol' typing days?
Well, here's the solution you need! Meet Cbot, your very own text-based chatbot secretary.
With Cbot, you can:
Ace your university modulesCbot is easy to learn, and easy to use.
Try it now here1!
Footnotes
Sorry, try this instead. ↩