[panavdua] iP #158

panavdua · 2023-01-24T03:15:16Z

Panav ChatBot

"Chatbots will be your new best friends." - Christine Crandell (Forbes)

Panav frees your mind of having to remember things you need to do and doubles your productivity. It's,

text-based
easy to learn
SUPER FAST to use

All you need to do is,

download it from here.
double-click it.
add your tasks.
let it manage your tasks for you 👍

The best part is that it is completely FREE

Features:

Managing todos, deadlines, and events
Managing reminders (coming soon)

If you are a Java programmer, you can use it to practice Java too! Here's the main method:

public class Main {
    public static void main(String[] args) {
        Application.launch(MainApp.class, args);
    }
}

# Conflicts: # src/main/java/panav/command/DeleteCommand.java # src/main/java/panav/command/ExitCommand.java # src/main/java/panav/command/ListCommand.java # src/main/java/panav/exception/DukeException.java # src/main/java/panav/exception/InvalidInputException.java # src/main/java/panav/exception/InvalidNumberException.java # src/main/java/panav/exception/ToDoDescriptionException.java # src/main/java/panav/task/Deadline.java # src/main/java/panav/task/Event.java # src/main/java/panav/task/Task.java # src/main/java/panav/task/TaskList.java # src/main/java/panav/ui/Ui.java Resolve conflicts by basic editing

# Conflicts: # src/main/java/panav/command/DeadlineCommand.java # src/main/java/panav/command/DeleteCommand.java # src/main/java/panav/command/EditCommand.java # src/main/java/panav/command/EventCommand.java # src/main/java/panav/command/ExitCommand.java # src/main/java/panav/command/ListCommand.java # src/main/java/panav/command/TodoCommand.java Resolve by basic editing

yanlings

Overall, really well done!

yanlings · 2023-01-31T08:45:25Z

src/main/java/panav/command/FindCommand.java

+    String keyWord;
+
+    public FindCommand(String keyWord) {
+        this.keyWord = keyWord;


I think keyWord can be written as keyword instead.

yanlings · 2023-01-31T08:46:36Z

src/main/java/panav/command/TodoCommand.java

+    private String todoMessage;
+
+    public TodoCommand(String todoMessage) {
+        this.todoMessage = todoMessage;


Could be toDoMessage because of camelcase.

Johnchiahk

Overall, a very great job Panav :D I hope to write code as well as you do!

Johnchiahk · 2023-02-04T20:49:46Z

src/main/java/panav/command/TodoCommand.java

+public class TodoCommand extends Command {
+
+    public static final String COMMAND_WORD = "todo";
+    private String todoMessage;


Perhaps toDoMessage may be better?

Yup agreed, thanks for the input!

Johnchiahk · 2023-02-04T20:51:58Z

src/main/java/panav/storage/Storage.java

+            if (indexBy != -1) {
+                textToAdd += String.format("%c ~ %d ~ %s ~ %s %n", str.charAt(1), check,
+                        str.substring(7, indexBy - 2), str.substring(indexBy + 4, length - 1));
+            } else if (indexFrom != -1) {
+                textToAdd += String.format("%c ~ %d ~ %s ~ %s ~ %s %n", str.charAt(1), check,
+                        str.substring(7, indexFrom - 1), str.substring(indexFrom + 6, indexTo - 1),
+                        str.substring(indexTo + 4, length - 1));
+            } else {
+                textToAdd += String.format("%c ~ %d ~ %s %n", str.charAt(1), check, str.substring(7));
+            }


Great code quality that you have shown, using if, else if, and else 👍

Johnchiahk · 2023-02-04T20:53:05Z

src/main/java/panav/task/TaskList.java

+        tasks = new ArrayList<>();
+        for (Task task : src) {
+            tasks.add(task);
+        }


Great code quality that you have shown, as the add function in ArrayList is very efficient! :D

Johnchiahk · 2023-02-04T20:54:09Z

src/main/java/panav/task/ToDo.java

+     */
+    public ToDo(String description) throws ToDoDescriptionException {
+        super(description);
+        if (description.length() == 0) {


Perhaps !description.length() is better?

True, shall make the change

Johnchiahk · 2023-02-04T20:55:18Z

src/main/java/panav/task/Task.java

+     * @return "X" is task is done, " " otherwise.
+     */
+    public String getStatusIcon() {
+        return (isDone ? "X" : " "); // mark done task with X


Great code quality shown! The choice of conditionals over if-else statements make your code looks cleaner!

nevinlim

LGTM, just some minor suggestions to improve code quality 😄

nevinlim · 2023-02-07T06:38:04Z

src/main/java/panav/command/DeleteCommand.java

+     * @throws InvalidNumberException If the index doesn't exist.
+     */
+    public static int readNumber(String command, int len) throws InvalidNumberException {
+        int number = Integer.parseInt(String.valueOf(command.charAt(command.length() - 1)));


Perhaps can split this up into variables instead of nested parentheses to improve code quality

Agreed, thanks for the inputs!

nevinlim · 2023-02-07T06:40:29Z

src/main/java/panav/Panav.java

+                if (c.toString().compareTo(ListCommand.COMMAND_WORD) != 0
+                        || c.toString().compareTo(ExitCommand.COMMAND_WORD) != 0) {


Maybe can split this into more easily understandable variables

nevinlim · 2023-02-07T07:13:31Z

src/main/java/panav/command/EditCommand.java

+     * @throws InvalidNumberException If the index doesn't exist.
+     */
+    public static int readNumber(String command, int len) throws InvalidNumberException {
+        int number = Integer.parseInt(String.valueOf(command.charAt(command.length() - 1)));


Can reduce this to more readable variables too

Thanks for pointing it out :)

Add assertions to highlight important assumptions in the code

# Conflicts: # src/main/java/panav/MainWindow.java

Branch a code quality

User should have the ability to find all the todos/deadlines/events in the task list. Let's add functionality so the user can just type "find todo" to list out all the todos in the list. Makes it easier for users to filter out tasks of one type if the list is too long.

'searchable' part of a string representation of a task

work on any OS

EditCommand

marked; same for unmark as well

damithc and others added 27 commits July 31, 2022 17:20

Add Gradle support

556af3f

Created Level - 1 framework

8673b0a

Level-2 completed

54806e6

Added new Task class and edited Duke according to level 3 increment

98c646a

Added new subclasses of events and completed Level-4

541bb7b

Tested out automated testing

be2eea4

Did level 5

8e72879

Added delete functionality

3b2449c

Fixed bugs in "deadline"

fd9fe32

Add InvalidNumberException and fix bugs

bfd8f00

Add javadocs

9e26bff

Add functionality to save list of tasks into hard disk

8712493

Merge branch 'branch-Level-7'

80afa77

Add .gitignore

ad2a01c

Implement OOP principls

a7622e2

Organise all existing classes into packages

8a3dc35

Merge remote-tracking branch 'origin/add-gradle-support'

a0a814c

Add gradle support

9279d4e

Configure Gradle to to run JUnit tests

90f01fc

Implement JUnit tests for some methods of certain classes

c9f4605

Modify details in build.gradle

bd74c08

Add JavaDoc comments to all classes and public methods in the program.

e7428b5

Made changes to adhere to coding stadard

338daa6

Add feature to find all tasks in the list which contain a specific word

b5a4cba

Merge branch 'branch-A-JavaDoc'

0ec955c

yanlings reviewed Jan 31, 2023

View reviewed changes

panavdua added 2 commits February 2, 2023 21:03

Implement checkstyle tests and improve the general coding quality

5060a4d

Improve checkStyle in various files

9b4c746

Add JavaFX basic controls to Panav.java and created Launcher.java

2b68763

Johnchiahk reviewed Feb 4, 2023

View reviewed changes

panavdua added 2 commits February 6, 2023 10:15

Create basic layout for GUI Panav

189ecd8

Improve code styling and convention

f28a21b

nevinlim reviewed Feb 7, 2023

View reviewed changes

panavdua added 25 commits February 7, 2023 21:36

Add interaction of GUI with the user

c58139b

Use FXML and SceneBuilder

c2b7737

Merge branch 'Level-10'

e6e1273

Improve code quality

30f7bf5

Add assertions to highlight important assumptions in the code

ece3ec7

Merge pull request #2 from panavdua/branch-A-Assertions

ac9c061

Add assertions to highlight important assumptions in the code

Merge branch 'master' of https://github.com/panavdua/ip

71317ea

Merge branch 'master' into branch-A-CodeQuality

f9964d1

# Conflicts: # src/main/java/panav/MainWindow.java

Update build.gradle

8f02e34

Merge pull request #3 from panavdua/branch-A-CodeQuality

a55a43e

Branch a code quality

Allow case-insensitivity for 'find' command and narrow down on the

242a488

'searchable' part of a string representation of a task

Merge branch 'branch-C-BetterSearch'

a0a1f5d

Update build.gradle to include JavaFX

14caf56

enable relative path directory instead of absolute so that it can

50573ed

work on any OS

Merge branch 'branch-enableRelativePath'

d6253a8

Fix bugs related to 'mark' and 'unmark' command

8916609

create new classes to separate edit commands

91cbdeb

create new classes for MarkCommand and UnmarkCommand which extend

82290b5

EditCommand

Add restriction such that user cannot mark tasks which are already

d765a34

marked; same for unmark as well

change panav.txt

5bda6ff

Merge branch 'branch-separateEditCommands'

16a969b

Add functionality to catch errors arising from editing tasks

77cbce3

Create User Guide

e93deda

Update User Guide

573f6a1

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[panavdua] iP #158

[panavdua] iP #158

panavdua commented Jan 24, 2023 •

edited

yanlings left a comment

yanlings Jan 31, 2023

yanlings Jan 31, 2023

Johnchiahk left a comment

Johnchiahk Feb 4, 2023

panavdua Feb 7, 2023

Johnchiahk Feb 4, 2023

Johnchiahk Feb 4, 2023

Johnchiahk Feb 4, 2023

panavdua Feb 7, 2023

Johnchiahk Feb 4, 2023

nevinlim left a comment

nevinlim Feb 7, 2023

panavdua Feb 7, 2023

nevinlim Feb 7, 2023

nevinlim Feb 7, 2023

panavdua Feb 7, 2023

		if (c.toString().compareTo(ListCommand.COMMAND_WORD) != 0
		\|\| c.toString().compareTo(ExitCommand.COMMAND_WORD) != 0) {

[panavdua] iP #158

Are you sure you want to change the base?

[panavdua] iP #158

Conversation

panavdua commented Jan 24, 2023 • edited

Panav ChatBot

yanlings left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Johnchiahk left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nevinlim left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

panavdua commented Jan 24, 2023 •

edited