[Guo Yulong] iP #166

gyulong1 · 2023-01-24T05:23:43Z

DukePro

"“Your mind is for having ideas, not holding them.” – David Allen source

DukePro frees your mind of having to remember things you need to do. It's,

text-based
easy to learn
FAST SUPER FAST to use

All you need to do is,

download it from here.
double-click it.
add your tasks.
let it manage your tasks for you 😉

And it is FREE!

Features:

Managing tasks
Managing deadlines (coming soon)
Reminders (coming soon)

If you Java programmer, you can use it to practice Java too. Here's the main method:

public class Main {
    public static void main(String[] args) {
        Application.launch(MainApp.class, args);
    }
}

# Conflicts: # src/main/java/Deadline.java # src/main/java/Event.java

# Conflicts: # src/main/java/duke/command/CommandDelete.java # src/main/java/duke/command/CommandTask.java

bernicetoh

Overall, I found your code neat and have followed the coding standard. I noticed that you have not added JavaDoc comments for your classes. Consider including them in.

bernicetoh · 2023-01-31T03:14:04Z

src/main/java/duke/task/Event.java

+
+import java.time.LocalDate;
+import java.time.format.DateTimeFormatter;
+


Perhaps you can include JavaDoc comments for each class?

bernicetoh · 2023-01-31T03:21:22Z

src/test/java/duke/ParserTest.java

+
+        assertEquals(true, command.isExit());
+    }
+}


Looks good.

rockman007372

Overall neat and readable code that follows Java coding convention well. My only suggestions are to consider trailing whitespace during parsing and to rename the test methods to be more in line with convention! Great job Yulong!

rockman007372 · 2023-02-02T15:11:51Z

src/main/java/duke/Parser.java

@@ -72,7 +76,9 @@ public static Command parse(String fullCommand) {
                    int indexFrom = fullCommand.indexOf("/from");
                    int indexTo = fullCommand.indexOf("/to");
                    if (indexFrom != -1 && indexTo != -1) {
-                        t = new Event(fullCommand.substring(6, indexFrom), fullCommand.substring(indexFrom + 6, indexTo - 1), fullCommand.substring(indexTo + 4));
+                        t = new Event(fullCommand.substring(6, indexFrom),


Neat indexing that follows coding standard. Well done!

rockman007372 · 2023-02-02T15:14:00Z

src/test/java/duke/ParserTest.java


 public class ParserTest {
    @Test
-    public void dummyTest(){
+    public void dummyTest() {


I think using another name for test method would be more appropriate. Perhaps using the test name convention whatIsBeingTested_descriptionOfTestInputs_expectedOutcome

rockman007372 · 2023-02-02T15:20:12Z

src/main/java/duke/task/Task.java

@@ -25,7 +28,7 @@ public String getDesc() {
     * Sets the status of the task.
     * @param isDone final status of the task.
     */
-    public void setStatus(Boolean isDone){
+    public void setStatus(Boolean isDone) {


I like how you combine mark and unmark method into a single setStatus method!

rockman007372 · 2023-02-02T15:23:37Z

src/main/java/duke/Parser.java

@@ -72,7 +76,9 @@ public static Command parse(String fullCommand) {
                    int indexFrom = fullCommand.indexOf("/from");
                    int indexTo = fullCommand.indexOf("/to");
                    if (indexFrom != -1 && indexTo != -1) {
-                        t = new Event(fullCommand.substring(6, indexFrom), fullCommand.substring(indexFrom + 6, indexTo - 1), fullCommand.substring(indexTo + 4));


Good parsing practices but I also recommend using method trim() to remove the leading and trailing whitespace in the task description!

jengoc415

Great job on the code overall!

jengoc415 · 2023-02-05T13:22:20Z

src/main/java/duke/Duke.java

+    private Storage storage;
+    private TaskList tasks;
+    private Ui ui;
+


I like how you stored the information!

jengoc415 · 2023-02-05T13:26:10Z

src/main/java/duke/Parser.java

+    public static Command parse(String fullCommand) {
+
+        if (fullCommand.equalsIgnoreCase("bye")) {
+            return new CommandBye(fullCommand);


Might want to consider using a switch case to make code more readable

jengoc415 · 2023-02-05T13:29:22Z

src/main/java/duke/command/CommandDelete.java

+        System.out.println("Now you have " + len + " in the list.");
+
+        storage.writeArray(taskList);
+    }


Neat code even printing complex set of text

jengoc415 · 2023-02-05T13:30:10Z

src/main/java/duke/command/CommandFind.java

+        System.out.println("Here are the matching tasks in your list:\n");
+        for (int i = 0; i < taskList.getLength(); i++) {
+            if (taskList.getTask(i).getDesc().contains(word)) {
+                System.out.printf("%d.%s\n", i + 1, taskList.getTask(i).toString());


Might be more readable to split these functions up instead of doing it all in one line

Added assertions to check that input line should be non-empty as this can cause exceptions. Also checked if the requested index was within the length of Tasklist before marking.

Refactored code to make it more readable using switch statements and more intermediate variables.

Add A-Assertions

# Conflicts: # src/main/java/duke/task/Task.java

Add A-CodeQuality

Ability to undo to add more flexiblity for the user. Creating a temporary store to the arraylist for the previous command. Introduce inverse commands which undo the effect of the previous command. To reduce adding more classes and utilise the existing abstraction to achieve the feature.

This reverts commit 8501c16.

This reverts commit d294575.

Fixed bugs with undo feature.

Change import statements

Included examples of features and screenshot of start UI.

Update import order to align with the guidelines.

damithc and others added 21 commits July 31, 2022 17:20

Add Gradle support

556af3f

Added Level-1

2f1f359

Added Level-2

f4fd5a7

Added Level-3

d919c78

Added Level-4

284cd2b

Added A-TextUiTesting

95850de

Added Level-5

0038b4f

Added A-Collections

a6ebbbc

Add Level-7

bc3aea8

Add Level-8

f67291e

Merge remote-tracking branch 'origin/branch-Level-8'

a7bd96e

# Conflicts: # src/main/java/Deadline.java # src/main/java/Event.java

Add A-MoreOOP

3adcc42

Add A-Packages

0304764

Merge remote-tracking branch 'origin/add-gradle-support'

ed217b8

Add A-Gradle

16e57e1

Add A-JUnit

e36bb40

Add A-JavaDoc

e1ecf27

Add A-CodingStandard

797741b

Add Level-9

f85a78d

Merge branch 'branch-A-CodingStandard'

f29183d

# Conflicts: # src/main/java/duke/command/CommandDelete.java # src/main/java/duke/command/CommandTask.java

Merge branch 'branch-Level-9'

e2b77e2

bernicetoh reviewed Jan 31, 2023

View reviewed changes

Add Checkstyle

c3d6093

rockman007372 reviewed Feb 2, 2023

View reviewed changes

jengoc415 reviewed Feb 5, 2023

View reviewed changes

gyulong1 added 5 commits February 7, 2023 00:47

Add Level-10

02379d6

Add A-Assertions

37187c7

Added assertions to check that input line should be non-empty as this can cause exceptions. Also checked if the requested index was within the length of Tasklist before marking.

Add A-CodeQuality

0196e2f

Refactored code to make it more readable using switch statements and more intermediate variables.

Merge pull request #1 from gyulong1/branch-A-Assertions

2cffeac

Add A-Assertions

Changed import messages

779962d

gyulong1 added 11 commits February 7, 2023 02:34

Merge branch 'master' into branch-A-CodeQuality

34759e7

# Conflicts: # src/main/java/duke/task/Task.java

Merge pull request #2 from gyulong1/branch-A-CodeQuality

8858bd9

Add A-CodeQuality

Revert "Undo Command: add undo feature"

d294575

This reverts commit 8501c16.

Revert "Revert "Undo Command: add undo feature""

56f388d

This reverts commit d294575.

Change user picture to one that has a transparent background.

b8955cd

Fixed bugs with undo feature.

Credited checkstyle

62e4616

Change import statements

Add name in title

3d2a38a

Add user guide draft

ec146c5

Included examples of features and screenshot of start UI.

Change exit command to close the window.

f4c815a

Update import order to align with the guidelines.

Update naming of variables and header to adhere to coding standard.

f2f44f6

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Guo Yulong] iP #166

[Guo Yulong] iP #166

gyulong1 commented Jan 24, 2023 •

edited

bernicetoh left a comment

bernicetoh Jan 31, 2023

bernicetoh Jan 31, 2023

rockman007372 left a comment

rockman007372 Feb 2, 2023

rockman007372 Feb 2, 2023

rockman007372 Feb 2, 2023

rockman007372 Feb 2, 2023

jengoc415 left a comment

jengoc415 Feb 5, 2023

jengoc415 Feb 5, 2023

jengoc415 Feb 5, 2023

jengoc415 Feb 5, 2023


		import java.time.LocalDate;
		import java.time.format.DateTimeFormatter;

[Guo Yulong] iP #166

Are you sure you want to change the base?

[Guo Yulong] iP #166

Conversation

gyulong1 commented Jan 24, 2023 • edited

DukePro

bernicetoh left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rockman007372 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jengoc415 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gyulong1 commented Jan 24, 2023 •

edited