[yyj-02] iP #17

yyj-02 · 2023-01-18T11:37:21Z

Duke Ultra Pro Max

"Duke is your friend when you have no friends" - someone famous

Description

Duke Ultra Pro Max is a open source bleeding edge 🔪, blazingly fast ⚡, highly interactive 🔥, all-in-one 📦 task manager for all your needs.

We are crrently in Beta Mode so Duke Ultra Pro Max is FREE FOR ALL USAGE. We also welcome everyone to contribute!

Feature

Can add 3 different types of tasks, todo | deadline | event
Persistent storage with the help of your local storage
Easily find events happening on a certain day with on command
Intuitive search function with string matching using find command

Usage

Go to Duke Ultra Pro Max v1.0 release link
Download duke-v1.0.jar AT YOUR OWN RISK
(IMPORTANT) Disable your Antivirus and Windows Defender
Double click the jar file ~~and let us steal your data~~
Start managing your tasks

Remember to give us these details:

Developer Guide

If you Java programmer, you can use it to practice Java too. Here's the main method:

public class Duke {
    public static void main(String[] args) {
        new Duke(<location of local storage file in string>).run();
    }
}

…ases

…n abstract task class

…format to be passed in

salty-flower · 2023-01-31T03:23:32Z

src/main/java/command/Command.java

+
+import storage.TaskList;
+
+public abstract class Command {


I like how you separated the code with an abstract class Command 😄

salty-flower · 2023-01-31T06:47:38Z

src/main/java/command/OnCommand.java

+    public String run(TaskList taskList) {
+        ArrayList<Task> taskOnQueryDate = new ArrayList<>(taskList.indexTask().stream().filter(task ->
+                        (task instanceof Deadline && ((Deadline) task).daysToDeadline(this.queryDate) == 0) ||
+                                (task instanceof Event && ((Event) task).daysToEvent(this.queryDate) == 0))


I like how you indented the lines here

anshumaantgi

Overall a well-thought IP, I can see that you have structured the classes very well and inside packages. Good use of Java OOP and the language itself, maybe you can add some JavaDoc comments, otherwise looks good to me.

anshumaantgi · 2023-02-04T17:03:59Z

src/main/java/command/DeleteCommand.java

+        try {
+            String taskDescription = taskList.showTask(this.index).toString();
+            taskList.deleteTask(this.index);
+            return "Noted. I've removed this task:\n  " + taskDescription + "\nNow you have " + taskList.countTask()


I like how you abstract commands under the abstract class .Seeing how each run statement return a string , maybe store that string in each command and make a output method , this was you abstract all you're outputs there and in the future if you;re output message changes you would not have to change the code .

Yeah considered that too and it would be easier for testing as well.

anshumaantgi · 2023-02-04T17:04:32Z

src/main/java/parser/Request.java

+     */
+    public Command parse() throws UnknownCommandException, MissingArgumentException, InvalidArgumentException {
+        preprocess();
+        switch (this.requestType) {


I like how you used switch-case statements here

anshumaantgi · 2023-02-04T17:05:46Z

src/main/java/storage/TaskList.java

@@ -0,0 +1,125 @@
+package storage;
+
+import java.time.LocalDate;


Import statements could be more clearer, The ordering of import statements must be consistent. as stated in the coding guidelines. So maybe organise them by putting spaces between them .

anshumaantgi · 2023-02-04T17:07:25Z

src/test/java/command/DeadlineCommandTest.java

+import task.Deadline;
+import task.Task;
+
+public class DeadlineCommandTest {


test can follow this featureUnderTest_testScenario_expectedBehavior() according to guideline.

Added assetions where assumptions were made, mainly in the command package: * Mark, Unmark, Delete: assert that index >= 0 * Todo, Deadline, Event: assert that task is not empty

Follow the coding standards more closely. Did the following tasks: * Add missing header comments * Rearrange import statements

Added assertions for: * out of index * empty task

* Rearranged imports * Refactored code

Amend code to follow code quality Follow more SLAP principles and add more comments! 👀

damithc and others added 30 commits July 31, 2022 17:20

Add Gradle support

556af3f

Level-0: add greet messages

96f3711

Level-1(Duke): accept input and add terminating condition

d6fec83

Level-1(RequestHandler): add request handler class to echo message

b0318c1

Level-1(RequestHandler): add javadoc

ee3ff0c

Level-2(TodoList): add new class to store todos

f3839f3

Level-2(RequestHandler): add request type enum

db07d59

Level-2(RequestHandler): add switch to return response according to c…

1938ae3

…ases

Level-3(RequestHandler): add new request types

3d2e1a6

Level-3(Todo): create todo class and add mark/unmark functionality

b6f396d

Level-4(TaskList): refactor to accomodate new classes that inherits a…

32e9b43

…n abstract task class

Level-4(TaskList): add support for all types of events

33f080e

Level-5: refactor for more oop

399d5df

Level-5(Parser): add exceptions handling

ed58f14

Level-5(command): add exception handling

8cc8cd8

Level-6(tasklist): add delete operation

22d31c0

Level-6(deletecommand): add delete command handler

ce73a4a

Level-6(deleteparser): add parser to parse delete request

1f2d57f

A-TextUiTesting: add testing

a6e2404

Level-7(TaskList): add method to populate tasks from file

45c882e

Level-7(TaskList): add method to write tasks to file

f6a682f

Parser: ignore case when matching string

fbc4bbb

Level-8: refactor code to follow more dry principle and require date …

64b59b7

…format to be passed in

Level-8: add guide in exception description

44a54a0

Level-8(oncommand): add method to check days to deadline or event

4e40231

Level-8: update checking of dates for event

3197c4b

Level-8: update test case

1b0294f

Level-8: merge branch into master

49ef041

Oop: move localstorage logic into a separate class

f222472

Oop: refactored to create a duke class

3029e8c

yyj-02 added 9 commits January 29, 2023 12:06

Add test case for find command

b514294

Add header comments

3ef3332

Add comments for other components

4f1879f

Merge branch 'branch-Level-9'

de51846

Follow coding standard

61c9ef6

Remove unnecessary final tag

1c50cee

Integrate with javafx

4c3b4ab

Set up basic ui

d0b9037

Follow tutorial for javafx ui

98fab93

salty-flower reviewed Feb 3, 2023

View reviewed changes

anshumaantgi reviewed Feb 4, 2023

View reviewed changes

yyj-02 and others added 19 commits February 9, 2023 21:02

Add padding and rounded border

1bb6b5d

Refactor the gui code

4ec5177

Add padding and refactor

845ad82

Add assertions

bfce2f5

Added assetions where assumptions were made, mainly in the command package: * Mark, Unmark, Delete: assert that index >= 0 * Todo, Deadline, Event: assert that task is not empty

Clean up code

dd13043

Follow the coding standards more closely. Did the following tasks: * Add missing header comments * Rearrange import statements

Assert any assumptions

af3d06b

Added assertions for: * out of index * empty task

Improve code quality

bb9633a

* Rearranged imports * Refactored code

Add github action to run gradle check and build

b415136

Fix some checkstyle mistakes

7c336a4

Clean up test case code

94bf3a8

Add reminder feature

cd6942c

Correct grammar in comment

37f7c33

Apply SLAP principle

9bc4b51

Merge pull request #2 from yyj-02/branch-A-CodeQuality

7c0b54f

Amend code to follow code quality Follow more SLAP principles and add more comments! 👀

Add screenshot in docs

a2ef3af

Add feature list to readme

19602c5

Update readme

258c367

Add introduction to readme

52b47aa

Add thank you note

68a56dc

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[yyj-02] iP #17

[yyj-02] iP #17

yyj-02 commented Jan 18, 2023 •

edited

salty-flower Jan 31, 2023

salty-flower Jan 31, 2023

anshumaantgi left a comment

anshumaantgi Feb 4, 2023

yyj-02 Feb 9, 2023

anshumaantgi Feb 4, 2023

anshumaantgi Feb 4, 2023

anshumaantgi Feb 4, 2023

		@@ -0,0 +1,125 @@
		package storage;

		import java.time.LocalDate;

[yyj-02] iP #17

Are you sure you want to change the base?

[yyj-02] iP #17

Conversation

yyj-02 commented Jan 18, 2023 • edited

Duke Ultra Pro Max

Description

Feature

Usage

Developer Guide

salty-flower Jan 31, 2023

Choose a reason for hiding this comment

salty-flower Jan 31, 2023

Choose a reason for hiding this comment

anshumaantgi left a comment

Choose a reason for hiding this comment

anshumaantgi Feb 4, 2023

Choose a reason for hiding this comment

yyj-02 Feb 9, 2023

Choose a reason for hiding this comment

anshumaantgi Feb 4, 2023

Choose a reason for hiding this comment

anshumaantgi Feb 4, 2023

Choose a reason for hiding this comment

anshumaantgi Feb 4, 2023

Choose a reason for hiding this comment

yyj-02 commented Jan 18, 2023 •

edited