[Ong Wei Jie] ip #170

ongweijie7 · 2023-01-24T06:36:27Z

DukePro frees your mind of having to remember things you need to do. It's,

~~Fast~~ SUPER FAST to use for CLI users
User-Friendly
Allows you to keep track of your schedule!!

ALL YOU NEED TO DO IS TO download it from here.

double-click it.
add your tasks.
let it manage your tasks for you 😉
And it is FREE!

Features:

Managing tasks
Finding Tasks
Reminders (coming soon)

If you Java programmer, you can use it to practice Java too. Here's the main method:

public class Main {
    public static void main(String[] args) {
        Application.launch(MainApp.class, args);
    }
}

…requested

Replaced some if-else statements with case. Replaced remove() method in task class and subclasses to removeTask().

* branch-level-7: Add ability to save tasks in hard disk # Conflicts: # src/main/java/Duke.java

* commit '556af3f47a96b32898ab4cdbd65b16486a4871e8': Add Gradle support

afiqzu

Overall your code is easy to understand 👍 Keep it up!

afiqzu · 2023-02-03T17:29:51Z

src/main/java/Duke.java

+                            DateTimeFormatter formatter = DateTimeFormatter.ofPattern("d/MM/yyyy HHmm");
+                            LocalDateTime dateTime = LocalDateTime.parse(taskDate[1], formatter);
+                            String dateTimeString = dateTime.format(DateTimeFormatter.ofPattern("MMM d yyyy hhmma"));
+                            input = taskDate[0] + "(by:" + dateTimeString  + ")";
                            newTask = new Deadline(input);
                            break;
                        case "event" :


Just a minor coding standard violation but I think there should not be a white space between the "event" condition and the colon

afiqzu · 2023-02-03T17:35:36Z

src/main/java/Storage.java

+                        break;
+                    case "D" :
+                        this.actions.add(new Deadline(taskName));
+                        break;


Perhaps you would like to insert a default case to make it clear that it is the end of the switch statement?

zhoyx

Overall, I fould your code easy to read. Just ensure JavaDocs end off with fullstops.

zhoyx · 2023-02-03T17:40:02Z

src/main/java/duke/Parser.java

+     * @throws Missing if there is missing information regarding date and time
+     * @throws WrongKeyWord if there is a missing key command
+     */
+    public static String understandInput(String input, String[] input_arr, TaskList tasks, Storage storage) throws Missing, WrongKeyWord {


Would both input and input_arr both need to be passed in to the function? Could you obtain one from the other?

zhoyx · 2023-02-03T17:40:56Z

src/main/java/duke/Parser.java

+public class Parser {
+
+    /**
+     * Returns reply string based on.


Is the fullstop here intended?

zhoyx · 2023-02-03T17:43:40Z

src/main/java/duke/Storage.java

+     * @param filePath path of where the file is.
+     */
+    public Storage(String filePath) {
+        this.path = "./src/main/data/duke.txt";


Should this make use of the filePath passed into the constructor 🤔

zhoyx · 2023-02-03T17:45:45Z

src/main/java/duke/Ui.java

+ * Class that prints output for the user.
+ */
+public class Ui {
+    private Scanner r;


Maybe a more descriptive name for the scanner would make it clearer.

zhoyx · 2023-02-03T17:47:11Z

src/main/java/duke/dukeexceptions/TaskListEmpty.java

+package duke.dukeexceptions;
+
+/**
+ *  An exception that throws when TaskList is empty.
+ */
+public class TaskListEmpty extends DukeException{
+
+    /**
+     * Constructor for the Exception.
+     *
+     * @param s string to be thrown during exception.
+     */
+    public TaskListEmpty(String s) {
+        super(s);
+    }
+
+    /**
+     * {@inheritDoc}
+     *
+     * @return a warning message when there is missing information.
+     */
+    @Override
+    public String getMessage() {
+        return "☹ hmm strange the list is missing and so are my cookies?!?";
+    }
+}


Good use of various duke exceptions for error handling 👍

zhoyx · 2023-02-03T17:50:20Z

src/main/java/duke/task/ToDo.java

+        return "Noted I've removed this task:\n "
+                + this.status() + "\n" + "Now you have "
+                + super.total + " tasks in the list";


Clean line breaks, improves readability 👍

zhoyx · 2023-02-03T17:52:32Z

src/main/java/duke/task/ToDo.java

+    /**
+     * Returns the updates on removal
+     *
+     * @return string regarding removal of a ToDo
+     */


Maybe consider adding a fill stop to the end of JavaDocs sentences

There was a complicated "if else" expression to determind the types of task as there were a few or expressions. Breaking down the "if else" expression into their own individual expressions improved the readability and code quality.

Branch a assertions

Revert "Branch a assertions"

* 'master' of https://github.com/ongweijie7/ip: Revert "Branch a assertions" Add Assertions and also catch statements to catch various exceptions Add assertion and created .jar file

* origin/master: Revert "Branch a assertions" Add Assertions and also catch statements to catch various exceptions Add assertion and created .jar file

* origin/branch-A-CodeQuality: Improve code quality

…own. Added catch statements to catch exceptions because they could be thrown when user gave missing commands. Exceptions that occur when there is a missing time/date or wrong format given will be caught and I will throw a Missing DukeException. It is done this way since this error is specific to a missing command. The error message for Missing exception is also improved as I realised the missing command is also used when there is no information on the task name given

There was a complicated "if else" expression to determind the types of task as there were a few or expressions to check for all types of task. Breaking down the "if else" expression into their own individual expressions improved the readability and code quality. This ensures that there are seperate conditional expressions to consider each variation of task added, allowing for easier understanding of code.

…own. Added catch statements to catch exceptions because they could be thrown when user gave missing commands. Exceptions that occur when there is a missing time/date or wrong format given will be caught and I will throw a Missing DukeException. It is done this way since this error is specific to a missing command. The error message for Missing exception is also improved as I realised the missing command is also used when there is no information on the task name given

* commit '306bf4fd7b532958292332396c6a4e359c29ac73': Remove 3 empty lines Add a few catch statements in Parser and edited the error message thrown. Improve code quality

Abstracted away the marking, unmarking and deleting of tasks. Also make it such that storage will keep track of done tasks. TaskList should handle the marking of tasks instead of letting tasks handle it themselves. It is done this way because Storage needs to constantly update the textfile.

Needs to be changed to make things easier for user especially for command line users Have shortened the first command to a simple capital letter. This ensures that actual commands can be differentiated from accidental inputs.

damithc and others added 21 commits July 31, 2022 17:20

Add Gradle support

556af3f

Added greet, echo and exit

03631f9

no message

13869b8

Added the ability to store text entered by the user and display when …

ad73d59

…requested

Added ability to mark list as done/not done

347e77c

Added different subclasses of Task

240fbac

Added ToDos, Deadlines, Events classes

7dce79c

Added exceptions when user input is incorrect

968ebce

Added capability to delete in list

ef0db69

Tidy up code

5ccec30

Replaced some if-else statements with case. Replaced remove() method in task class and subclasses to removeTask().

Add ability to save tasks in hard disk

91b394c

Add ability for duke to process dates

37155be

Merge branch 'branch-level-7'

0cc1352

* branch-level-7: Add ability to save tasks in hard disk # Conflicts: # src/main/java/Duke.java

Add more classes for OOP

3e8269d

Implement A-MoreOOP

821617f

Organise into packages

02f5c1c

Merge commit '556af3f47a96b32898ab4cdbd65b16486a4871e8'

860e20e

* commit '556af3f47a96b32898ab4cdbd65b16486a4871e8': Add Gradle support

Add Junit tests and JAR file

409a34b

no message

ae61454

Add javadoc and tweak code to comply with coding standard

70409d5

Add command to find keyword

3d40c86

afiqzu reviewed Feb 3, 2023

View reviewed changes

zhoyx reviewed Feb 3, 2023

View reviewed changes

ongweijie7 and others added 7 commits February 10, 2023 02:33

Add GUI interface

dfaeae3

Correct coding violations and use CheckStyle

ed1e94d

Add assertion and created .jar file

a2ab29e

Add Assertions and also catch statements to catch various exceptions

28553dc

Improve code quality

739e0f2

There was a complicated "if else" expression to determind the types of task as there were a few or expressions. Breaking down the "if else" expression into their own individual expressions improved the readability and code quality.

Merge pull request #2 from ongweijie7/branch-A-Assertions

4a76b5d

Branch a assertions

Revert "Branch a assertions"

e601831

ongweijie7 and others added 23 commits February 13, 2023 00:57

Merge pull request #3 from ongweijie7/revert-2-branch-A-Assertions

5498089

Revert "Branch a assertions"

Merge branch 'master' of https://github.com/ongweijie7/ip

70ab8ac

* 'master' of https://github.com/ongweijie7/ip: Revert "Branch a assertions" Add Assertions and also catch statements to catch various exceptions Add assertion and created .jar file

Merge remote-tracking branch 'origin/master' into branch-A-CodeQuality

2c6295a

* origin/master: Revert "Branch a assertions" Add Assertions and also catch statements to catch various exceptions Add assertion and created .jar file

Merge remote-tracking branch 'origin/branch-A-CodeQuality'

be50b27

* origin/branch-A-CodeQuality: Improve code quality

Remove 3 empty lines

306bf4f

Remove 3 empty lines

d89e8f8

Merge commit '306bf4fd7b532958292332396c6a4e359c29ac73'

1246793

* commit '306bf4fd7b532958292332396c6a4e359c29ac73': Remove 3 empty lines Add a few catch statements in Parser and edited the error message thrown. Improve code quality

Add syntax to make commands simpler.

d57a523

Needs to be changed to make things easier for user especially for command line users Have shortened the first command to a simple capital letter. This ensures that actual commands can be differentiated from accidental inputs.

Make minor deletes to Bye commands

16f46e7

Add the user guide for Duke

9819b12

no message

e643db6

no message

c139bda

Make improvements to storage

4ad9b11

no message

b51020a

Change the User guide

975b25e

no message

4aac2ce

Edit UserGuide

28ba10d

Make minor improvements

a255b23

no message

7a66ed4

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Ong Wei Jie] ip #170

[Ong Wei Jie] ip #170

ongweijie7 commented Jan 24, 2023 •

edited

afiqzu left a comment

afiqzu Feb 3, 2023

afiqzu Feb 3, 2023

zhoyx left a comment

zhoyx Feb 3, 2023

zhoyx Feb 3, 2023

zhoyx Feb 3, 2023

zhoyx Feb 3, 2023

zhoyx Feb 3, 2023

zhoyx Feb 3, 2023

zhoyx Feb 3, 2023

[Ong Wei Jie] ip #170

Are you sure you want to change the base?

[Ong Wei Jie] ip #170

Conversation

ongweijie7 commented Jan 24, 2023 • edited

afiqzu left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zhoyx left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ongweijie7 commented Jan 24, 2023 •

edited