[gitsac] iP #180

gitsac · 2023-01-24T08:41:26Z

Knight

"Now, your mind can forget what's to be done, for I will remember it for you." - Knight

Knight frees you from life's smallest worries, by remembering all the tasks you need to do. It's:

text-based
easy to learn
incredibly efficient when proficient

Setting you up for success

Ready to remember less things, and start doing more?
All you need to do is,

download it from here.
open a command window in the same directory
using the command window, type the following command:
java -jar Duke.jar
add your tasks.
let it manage your tasks for you 😉

And it is FREE!

Features:

Managing tasks
Managing deadlines
Reminders (coming soon)

If you happen to do a little coding in Java, see if this makes sense to you:

public class Main {
    public static void main(String[] args) {
        Application.launch(MainApp.class, args);
    }
}

…k output when using list command

text output of certain messages

…getting class fields

# Conflicts: # src/main/java/Duke.java # src/main/java/duke/Parser.java # src/main/java/duke/TaskList.java # src/main/java/duke/Ui.java # src/main/java/duke/tasktypes/Deadlines.java

wz2k

Overall, I can see that you have put in a lot of efforts to verify inputs. Just need to address some small changes to your code. Keep up the good work! 👍

wz2k · 2023-01-31T06:11:58Z

src/main/java/data/dukedata.txt

+1.[T][X] test2              
+2.[T][X] foru    
+3.[D][X] forum enjoyer (by: Tuesday) 


You seem to have 2 data text file and folder. Just a reminder to double check you file path and delete the redundant folder

src/main/java/duke/DukeExceptions.java

wz2k · 2023-01-31T06:17:22Z

src/main/java/duke/DukeExceptions.java

+        if (printThisOut.equals("Wrong size for mark/unmark")) {
+            toReturn = ":( Sorry, the number input is wrong. Please check the possible indexes again using list!";
+        }
+        if (printThisOut.equals("deadline") || printThisOut.equals("todo")) {
+            toReturn = ":( Sorry, the description of a " + this.printThisOut + " cannot be empty!";
+        }
+        if (printThisOut.equals("event")) {
+            toReturn = ":( Sorry, the description of an " + this.printThisOut + " cannot be empty!";
+        }
+        if (printThisOut.equals("find")) {
+            toReturn = ":( Sorry, please input a keyword!";
+        }


Possible to use a switch statement here with fall through for deadline and todo but this is up to you.

wz2k · 2023-01-31T06:19:34Z

src/main/java/duke/Parser.java

+            if (input.startsWith("todo")) {
+                handleToDoTask(input, listOfTasks);
+                return;
+            }
+
+            if (input.startsWith("find")) {
+                handleFindTask(input, listOfTasks);
+                return;
+            }
+
+            if (input.startsWith("deadline")) {
+                handleDeadlineTask(input, listOfTasks);
+                return;
+            }
+
+            if (input.startsWith("event")) {
+                handleEventTask(input, listOfTasks);
+                return;
+            }
+
+            if (input.equals("list")) {
+                handleList(listOfTasks);
+                return;
+            }
+
+            if (input.startsWith("delete")) {
+                handleDelete(input, listOfTasks);
+                return;
+            }
+
+            if (input.startsWith("checkdue")) {
+                handleCheckDue(input, listOfTasks);
+                return;
+            }
+
+            if (input.startsWith("mark")) {
+                handleMark(input, listOfTasks);
+                return;
+            }
+
+            if (input.startsWith("unmark")) {
+                handleUnmark(input, listOfTasks);
+                return;
+            }


One way to use 'startsWith' together with a switch statement is to use the split method.

src/main/java/duke/Parser.java

wz2k · 2023-01-31T06:39:12Z

src/main/java/duke/Ui.java

+package duke;
+
+import java.io.BufferedReader;
+import java.io.InputStreamReader;
+import java.io.IOException;
+
+/**
+ * Class used to read user's input for Duke chatbot.
+ */
+public class Ui {
+
+    protected BufferedReader readingInput;
+
+    /**
+     * Constructor to initiate a bufferedreader to get user input.
+     */
+    public Ui() {
+        this.readingInput = new BufferedReader(new InputStreamReader(System.in));
+    }
+
+    /**
+     * Function to read user input.
+     * @return String representation of user input.
+     * @throws IOException
+     */
+    public String gettingUserInput() throws IOException {
+        String userInput = readingInput.readLine();
+        return userInput;
+    }
+
+}


Perhaps all you printing of messages could also be handled by the UI class

wz2k · 2023-01-31T06:40:57Z

src/main/java/duke/tasktypes/Deadlines.java

+/**
+ * Class which represents a Task with a deadline.
+ */
+public class Deadlines extends Task {


Perhaps it is better to name is in singular form as each object from this class is a singular deadline.

src/main/java/duke/tasktypes/Deadlines.java

wz2k · 2023-01-31T06:45:18Z

src/main/java/duke/tasktypes/Deadlines.java

+     * @return String representation of deadline task.
+     */
+    @Override
+    public String toString() {


Try to keep methods to a limit of 30 lines if possible

src/main/java/duke/tasktypes/Task.java

src/main/java/Duke.java

Sheemo · 2023-02-03T15:16:59Z

src/main/java/duke/DukeExceptions.java

+ */
+public class DukeExceptions extends Exception {
+    protected String printThisOut;
+


Better to use a variable name like toPrint

Also better to call your exception DukeException

Sheemo · 2023-02-03T15:17:34Z

src/main/java/duke/Parser.java

+import duke.tasktypes.Events;
+import duke.tasktypes.ToDo;
+import duke.tasktypes.Task;
+


Great use of packages!

Sheemo · 2023-02-03T15:20:03Z

src/main/java/duke/Storage.java

+        scannerForFileData.close();
+        return useThis;
+    }
+


Might need to consider corrupted files and handle them gracefully

Sheemo · 2023-02-03T15:21:26Z

src/main/java/duke/TaskList.java

+            toPrint = "Got it. I've added this task:\n  " + toAdd.toString() + "\nNow you have " + listOfTasks.size() + " tasks in the list.";                   
+        }
+        System.out.println(toPrint);
+    }


Printing listOfTasks.size() should be abstracted out to a function. Now there is a lot of repeated code. The function could also take in a boolean parameter isPlural for that extra "s" case

Sheemo · 2023-02-03T15:22:48Z

src/main/java/duke/tasktypes/Task.java

+        return this.name;
+    }
+
+}


Task should be responsible for printing the [X] as this is repeated across all subclasses

In many methods, it is assumed that certain variables or objects are of a certain state. By using assertions, code quality can be improved to make those assumptions a guarantee. Assumptions make it difficult to debug if the error stack trace is very long. It is important to hold assumptions in current state as otherwise there will be a need to check for many things at all methods. Let's improve code quality and make debugging easier by adding assumptions.

The code body is functioning well but makes for poor reading at times due to issues like big chunks of code and deep nesting. By abstracting deep nesting and big chunks of code into multiple helper functions, the code becomes more readable. Let's practice SLAP and be mindful of readability in the future.

Add assertions to Duke

Improve code quality by refactoring.

damithc and others added 11 commits July 31, 2022 17:20

Add Gradle support

556af3f

Add level-1 Increment

f7417fc

Removed class file

6ea87a9

Add level-2 Increment

f804062

Add level-3 Increment

a54d2e2

Add level-4 Increment

4b31a33

Abstracted tasks into their own classes, and fixed formatting for tas…

cac5843

…k output when using list command

Added level-5 Increment

67e75be

Added level-6 Increment

15286d0

Added automated text ui testing and re-formatted

583bfac

text output of certain messages

Edited formatting of message output for tasks

d24a989

gitsac changed the title ~~gitsac iP~~ [gitsac] iP Jan 24, 2023

gitsac added 18 commits January 25, 2023 12:02

Add level-7 Increment

708998d

Edit saved data file directory

29e45c3

Add Level-8 Increment

ea2b6c7

Merge branch 'branch-Level-7'

8829b58

merge conflict resolved

0094345

Merge branch 'branch-Level-8' with merge conflict resolved

acd824a

Merge branch 'master' of https://github.com/gitsac/ip

209ca66

Add A-MoreOOP Increment

7289e49

Add A-Packages Increment

9edcc88

Merge remote-tracking branch 'origin/add-gradle-support'

9275f98

Add A-Gradle Increment

94c0cf7

Remove commented-out lines

89ada46

Remove more commented-out lines no longer in use

f6ce2fd

Fix function obtaining date of deadline task

d1d59a1

Add A-JUnit Increment

96b1e0d

Add A-Jar Increment

d4399c9

Add Level-9 Increment

c20eaf4

Remove redundant lines of code and added additional abstraction when …

743688c

…getting class fields

gitsac added 3 commits January 29, 2023 20:57

Add JavaDocs for all relevant methods

f2260be

Fix function obtaining date of deadline task

b372bb3

Merge branch 'branch-A-JavaDoc'

4cbcbc1

# Conflicts: # src/main/java/Duke.java # src/main/java/duke/Parser.java # src/main/java/duke/TaskList.java # src/main/java/duke/Ui.java # src/main/java/duke/tasktypes/Deadlines.java

wz2k reviewed Jan 31, 2023

View reviewed changes

Sheemo reviewed Feb 3, 2023

View reviewed changes

gitsac and others added 24 commits February 4, 2023 00:28

Fix code formatting according to checkstyle

856c88f

Add JavaFX tutorial parts 1-3

507a5b1

Add basic JavaFX functionality

5f588db

Refactor classes into appropriate packages

486148e

Add JavaDocs for GUI classes and fixed checkstyle

863a124

Edit variable to successfully build with GUI

e10f65d

Fix JavaDocs formatting

dd495e5

Merge pull request #2 from gitsac/branch-A-Assertions

0369604

Add assertions to Duke

Merge branch 'master' into branch-A-CodeQuality

bf8e88a

Merge pull request #3 from gitsac/branch-A-CodeQuality

320eec1

Improve code quality by refactoring.

Fix typo in Task class method

c7dafe2

Add C-Tagging functionality

4b14f68

Improve GUI of chatbot

7f810c0

Center profile picture of user and chatbot

241d048

Fix background image for chat bot

2e197ba

Add unique personality to chatbot

dd20645

Change response when tagging task

e1181b2

Add Ui.png

ecf2538

Change Ui.png to be more reflective

92460f2

Update README.md

98824f9

Update README.md

bfbf4c4

Fix checkstyle and test issues

a873afd

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[gitsac] iP #180

[gitsac] iP #180

gitsac commented Jan 24, 2023 •

edited

wz2k left a comment

wz2k Jan 31, 2023

wz2k Jan 31, 2023

wz2k Jan 31, 2023

wz2k Jan 31, 2023

wz2k Jan 31, 2023

wz2k Jan 31, 2023

Sheemo Feb 3, 2023

Sheemo Feb 3, 2023

Sheemo Feb 3, 2023

Sheemo Feb 3, 2023

Sheemo Feb 3, 2023

Sheemo Feb 3, 2023

[gitsac] iP #180

Are you sure you want to change the base?

[gitsac] iP #180

Conversation

gitsac commented Jan 24, 2023 • edited

Knight

Setting you up for success

Features:

wz2k left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gitsac commented Jan 24, 2023 •

edited