-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nicleejy] iP #181
base: master
Are you sure you want to change the base?
[nicleejy] iP #181
Conversation
Merge task file changes to master
Merge date time processing feature into master
add gradle file wrapper to project
Merge find feature into master branch
Merge JavaDoc changes to master branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, the coding standard is good! 👍 It follows the Java coding standard closely. There was only a minor issue I found regarding the naming of boolean methods.
Please let me know if you have any queries regarding my comments.
* | ||
* @return boolean value indicating the success of the file creation. | ||
*/ | ||
public boolean createTaskFile() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this method returns a boolean, you may want to consider using a prefix such as is
, has
, was
. Perhaps something like canCreateTaskFile
or hasCreatedTaskFile
?
* The TaskFileReaderWriter class provides methods for reading and writing tasks to and from a file. | ||
* It includes methods for loading tasks from a file and updating a task file with tasks from a | ||
* TaskManager object, and creating a new task file. | ||
* @author Nicholas Lee |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that you included @author
in your comments.
* @param taskManager The TaskManager object containing the tasks to be written to the file. | ||
* @return boolean value indicating the success of the file update operation. | ||
*/ | ||
public boolean updateTaskFile(TaskManager taskManager) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar comment as the one above
/** | ||
* Various responses of UwU_TaskMaster | ||
*/ | ||
public enum Response { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good addition! It offers an easier way to manage responses. 👍
userData/test.txt
Outdated
@@ -0,0 +1,2 @@ | |||
Deadline|false|eat food|23/12/2023 1200 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a suggestion. Perhaps you want to include test.txt in your .gitignore file to prevent the constant file change when committing changes.
Merge assertion updates into master
Users were previously unable to query for free times in their list of tasks. To resolve this issue, adding a new feature allowing users to state a duration and the bot automatically finds a free slot if it exists. Introduce FreeTimeBlock class to represent free timeslots with start and end timings. Implement getFreeTimes() method in the TaskManager class to find free slots based on the user's schedule. A different String representation of FreeTimeBlock is generated depending on whether it is bounded or unbounded. This update allows for more efficient time management, and improves user experience.
Add query for free time slots in user schedule
Introducing UwU_TaskMaster
UwU_TaskMastew fwees youw mind of having t-to wemembew things you nyeed t-to do. It's,
FASTruns away SUPEW FAST t-to useaww >w< you nyeed t-to do is,
And it is FWEE!
Features:
If you Java pwogwammew, you c-can use i-it t-to pwactice Java too. runs away Hewe's the x3 main method for the CLI version of UwU_TaskMaster: