[szejiancheng] iP #205

szejiancheng · 2023-01-25T01:58:58Z

Introducing Duke, the CLI task assistant!

It's so easy, even a Y2 CS student can use it! 👍 - someone
source

Duke stores all your tasks so you don't have to! Now supporting:

Todos
Deadlines
Events
And more!

All you need to do is,

Download the JAR file here
Unzip it into somewhere convenient
Open and run it
Simply type commands into the command line and let Duke help you remember them!

Features:

Task adding, removing, marking, and saving
Finding an added task _{Coming soon!}
GUI _{Coming soon!}

if (this.userApproval = HIGH) {
    this.merge();
}

…n EXPECTED.txt

…es to reflect new error messages in EXPECTED.txt and input.txt

From Level-7 requirements. Using java.nio.file classes to save on String parsing.

In order to facillitate more complicated instruction parsing, consolidated all command parsing under recieveInput

Taught duke how to understand dates

# Conflicts: # src/main/java/DukeBehaviour.java

What it says on the tin, was confused and had to figure out where Level-7 went to

Encapsulate the various components of Duke's execution in seperate classes

ryanjansen

Looks good, just some small cosmetic changes. The code was easy to read and made sense!

ryanjansen · 2023-01-31T03:01:11Z

src/main/java/Parser.java

+        ArrayList<String> tokens = new ArrayList<>(Arrays.asList(input.split(" ")));
+        tokens.removeIf(s -> s.equals(" ") || s.equals(""));
+        tokens.forEach(s -> s = s.trim());
+        //System.out.println(tokens);


Can remove this.

ryanjansen · 2023-01-31T03:01:27Z

src/main/java/Task.java

+        this.isDone = false;
+    }
+
+


Can remove.

ryanjansen · 2023-01-31T03:03:20Z

src/main/java/AddDeadlineCommand.java

+        super(tokens);
+        int byId = tokens.indexOf("/by");
+        if (byId < 0){
+            throw new DukeException("Invalid input received! \nDeadline commands are in the form of: deadline name /by bytime \n(remember to include '/by')");


Can add line breaks for style.

StanleyNeoh

Looks good to me. Just some minor styling issues here and there.

StanleyNeoh · 2023-01-31T02:59:48Z

src/main/java/AddDeadlineCommand.java

+        String name = String.join(" ", tokens.subList(1, byId));
+        LocalDate by = LocalDate.parse(String.join(" ", tokens.subList(byId+1, tokens.size())));
+        Deadline newDeadline = new Deadline(name, by);
+        super.setTaskToAdd(newDeadline);


As AddDeadlineCommand extends AddCommand, the command setTaskToAdd should work without the super in front. You should be able to just call it directly.

StanleyNeoh · 2023-01-31T03:01:11Z

src/main/java/Deadline.java

+
+    @Override
+    public String toString() {
+        return "[D]" + super.toString() + " (by: " + by.format(format) + ")";


As [D] shows up in multiple places, you may want to consider making it a constant within the class

StanleyNeoh · 2023-01-31T03:02:06Z

src/main/java/DeleteCommand.java

+    static final int commandLength = 2;
+    static final int indexOfIndex = 1;


As these 2 variables are final, should consider probably fully capitalising them like COMMAND_LENGTH for example.

StanleyNeoh · 2023-01-31T03:06:18Z

src/main/java/DeleteCommand.java

+    static final int commandLength = 2;
+    static final int indexOfIndex = 1;
+
+    private Task taskToDeleted;


taskToDeleted sounds grammatically incorrect. Maybe you meant taskToDelete or taskToBeDeleted.

StanleyNeoh · 2023-01-31T03:09:06Z

src/main/java/Event.java

+    protected LocalDate from;
+    static DateTimeFormatter format = DateTimeFormatter.ofPattern("MMM d yyyy");
+    protected LocalDate to;


you may want to consider rearranging the order, perhaps static variables together and non static ones together.

StanleyNeoh · 2023-01-31T03:09:30Z

src/main/java/Event.java

+
+    @Override
+    public String toString() {
+        return "[E]" + super.toString() + " (from: " + from.format(format) + " to: " + to.format(format) + ")";


Same thing, you might want to abstract out the status icon

StanleyNeoh · 2023-01-31T03:10:44Z

src/main/java/MarkCommand.java

+        int index = Integer.parseInt(tokens.get(1));
+        markIndex = index;


Why not just directly assign?

StanleyNeoh · 2023-01-31T03:11:48Z

src/main/java/Parser.java

+    }
+    private static ArrayList<String> tokenize(String input) {


Since you have been putting a newline between every function so far, might be good to keep consistent and put newline between functions here as well.

StanleyNeoh · 2023-01-31T03:13:12Z

src/main/java/Parser.java

+        switch (key) {
+            case "bye":


According to the java styles, the switch and case should be in the same indentation.

StanleyNeoh · 2023-01-31T03:14:10Z

src/main/java/Task.java

+        this.isDone = false;
+    }
+
+}


May want to add new line to the end of your file

Added FindCommand.java, additional switch line in Parser.java, print result function in Ui

# Conflicts: # src/main/java/duke/components/Storage.java

Also refactored code to make more sense now that we've removed the Ui class.

Code does not fully follow the specified code style, negatively impacting its readability Amending all checkstyle violations improves the code quality. In order to improve code quality, lets resolve all checkstyle violations. This will improve readability as well as ease of documentation.

Fix checkstyle violations

Add assertions to component classes

Previously the application did not exit properly when the bye command was invoked, which was not expected behaviour By invoking System.exit(), the command behaves as expected

If a user wants to directly see what tasks they have upcoming, there is no current functionality to sort tasks by date, or completion status. By adding a remind command, the user is able to get a glance of their upcoming uncompleted tasks within a timeframe they desire (in days) In our push for optimal user experience, lets add this functionality.

damithc and others added 17 commits July 31, 2022 17:20

Add Gradle support

556af3f

add DukeBehaviour.java and implement Level-1 functionality

020a838

add Level-2 functionality

276c7bd

add Task.java class, add Level-3 functionality

2162d57

Add task subclasses, more functionality to addTask method

83a84b1

fix unnecessary whitespace using trim

5391416

Add A-TextUiTesting, Add testcases in input.txt and expected return i…

4b13a25

…n EXPECTED.txt

Add exceptions to DukeBehaviour.java addTask methods, updated testcas…

3bfa112

…es to reflect new error messages in EXPECTED.txt and input.txt

Add delete method to DukeBehaviour.java, updated testcases

7e1c9d4

Add DukeBehaviour.java javadoc comments

754f676

Add save data feature

13a02d7

From Level-7 requirements. Using java.nio.file classes to save on String parsing.

Add tokenize implementation

fcbf7fc

In order to facillitate more complicated instruction parsing, consolidated all command parsing under recieveInput

Add Level-8 functionality

e651d75

Taught duke how to understand dates

Merge branch 'branch-Level-8'

e4b1869

# Conflicts: # src/main/java/DukeBehaviour.java

Fix merge conflicts and behaviour tweaks

b9f1c6d

What it says on the tin, was confused and had to figure out where Level-7 went to

Redesign Duke with OOP

ebf409a

Encapsulate the various components of Duke's execution in seperate classes

Organize the classes into suitable java packages

b4fc356

ryanjansen approved these changes Jan 31, 2023

View reviewed changes

ryanjansen reviewed Jan 31, 2023

View reviewed changes

StanleyNeoh reviewed Jan 31, 2023

View reviewed changes

szejiancheng added 10 commits February 1, 2023 11:17

Organized all packages under duke

e3b3510

Merge remote-tracking branch 'origin/add-gradle-support'

1b454bb

Add JUnit Tests

fd37c64

Update build.gradle with additional dependencies

c8bcbb6

Add JavaDocs to component classes

f6b3b5b

Tweak components package to comply with coding standard

c7ee56f

Add find functionality

52c9834

Added FindCommand.java, additional switch line in Parser.java, print result function in Ui

Add javadocs for exceptions and tasks

a7ba8f5

Add javadocs to AddCommand and Command

8c0078c

Merge branch 'A-CodingStandard'

873f246

szejiancheng and others added 30 commits February 7, 2023 14:20

Merge branch 'branch-Level-9'

ab43955

Merge branch 'branch-A-JavaDoc'

f6f329c

# Conflicts: # src/main/java/duke/components/Storage.java

Add Checkstyle functionality

1cfa487

Add GUI functionality

e2f30ac

Fix welcome message not appearing

1ec4a64

Also refactored code to make more sense now that we've removed the Ui class.

Refactor DukeGui

f568cb9

Merge branch 'branch-A-CheckStyle'

8931925

Merge branch 'branch-Level-10'

48251fc

Add assertions to component classes

58c713f

Merge pull request #2 from szejiancheng/branch-A-CodeQuality

3778cdd

Fix checkstyle violations

Merge branch 'master' into branch-A-Assertions

4a63368

Merge pull request #3 from szejiancheng/branch-A-Assertions

b8b9cfb

Add assertions to component classes

Fix application not exiting

84a7ccc

Previously the application did not exit properly when the bye command was invoked, which was not expected behaviour By invoking System.exit(), the command behaves as expected

Merge branch 'branch-A-CodeQuality'

5f0020e

Adjust Duke GUI formatting

a8cf58d

Tweak GUI

b412e3c

Add DaUser profile picture license

2b40770

Merge branch 'master' of https://github.com/szejiancheng/ip

7c9c037

Tweak GUI more

7354571

Merge branch 'master' of https://github.com/szejiancheng/ip

d790f51

Tweak window formatting

40c9f2c

Add Ui screenshot to docs

35249fa

Fix find command indexing

514876f

Add README file

60a7066

Add bye command to README

885e5c1

Create _config.yml

f2135a9

Edit Duke version number

fbaa7e1

Fix unamed module warning on app launch

0cd8322

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[szejiancheng] iP #205

[szejiancheng] iP #205

szejiancheng commented Jan 25, 2023 •

edited

ryanjansen left a comment

ryanjansen Jan 31, 2023

ryanjansen Jan 31, 2023

ryanjansen Jan 31, 2023

StanleyNeoh left a comment

StanleyNeoh Jan 31, 2023

StanleyNeoh Jan 31, 2023

StanleyNeoh Jan 31, 2023

StanleyNeoh Jan 31, 2023

StanleyNeoh Jan 31, 2023

StanleyNeoh Jan 31, 2023

StanleyNeoh Jan 31, 2023

StanleyNeoh Jan 31, 2023

StanleyNeoh Jan 31, 2023

StanleyNeoh Jan 31, 2023

		static final int commandLength = 2;
		static final int indexOfIndex = 1;

		int index = Integer.parseInt(tokens.get(1));
		markIndex = index;

[szejiancheng] iP #205

Are you sure you want to change the base?

[szejiancheng] iP #205

Conversation

szejiancheng commented Jan 25, 2023 • edited

Introducing Duke, the CLI task assistant!

ryanjansen left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

StanleyNeoh left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

szejiancheng commented Jan 25, 2023 •

edited