Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bernicetoh] iP #207

Open
wants to merge 63 commits into
base: master
Choose a base branch
from
Open

Conversation

bernicetoh
Copy link

@bernicetoh bernicetoh commented Jan 25, 2023

Duke

"Your mind is for having ideas, not holding them." - David Allen (source)

Free your mind and let Duke remember the things you have to do. It's,

  • text-based
  • easy to learn
  • FAST SUPER FAST to use

All you need to do is,

  1. download it from here
  2. double-click it.
  3. add your tasks.
  4. let it manage your tasks for you 😆

And it is FREE!

Features:

  • Manage your todo list
  • Keep track of your deadlines
  • Keep track of your events

If you are a Java programmer, you can use it to practice Java too. Here's the main method:

public class Main {
    public static void main(String[] args) {
        Application.launch(MainApp.class, args);
    }
}

bernicetoh and others added 3 commits February 5, 2023 18:12
There is a merge conflict when merging the code quality branch
this.taskList = new TaskList(storage.loadData());

}

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this method could be given a header comment.

userInput.clear();
}

/**
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you could remove/replace these header comments once you're done following the instructions here.

@@ -0,0 +1,14 @@
package duke.commands;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its a good call to package the different types of commands under this class.

*/
public abstract class Command {

public abstract boolean isExit();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you could include header comments for the following two lines.

final String commandWord = matcher.group("commandWord");
final String arguments = matcher.group("arguments");

switch (commandWord) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good use of switch-case and appropriate indentation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants