-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bernicetoh] iP #207
base: master
Are you sure you want to change the base?
[bernicetoh] iP #207
Conversation
…hiveBaseName values
* branch-A-CodingStandard: Tweak code to comply with the coding standard
* branch-Level-9: Add search function to find a task by searching for a keyword
Use Assertion
There is a merge conflict when merging the code quality branch
Improve code quality
this.taskList = new TaskList(storage.loadData()); | ||
|
||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this method could be given a header comment.
userInput.clear(); | ||
} | ||
|
||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you could remove/replace these header comments once you're done following the instructions here.
@@ -0,0 +1,14 @@ | |||
package duke.commands; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think its a good call to package the different types of commands under this class.
*/ | ||
public abstract class Command { | ||
|
||
public abstract boolean isExit(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you could include header comments for the following two lines.
final String commandWord = matcher.group("commandWord"); | ||
final String arguments = matcher.group("arguments"); | ||
|
||
switch (commandWord) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good use of switch-case and appropriate indentation!
Duke
Free your mind and let Duke remember the things you have to do. It's,
FASTSUPER FAST to useAll you need to do is,
And it is FREE!
Features:
If you are a Java programmer, you can use it to practice Java too. Here's the
main
method: