[SeanChinJunKai] iP #209

SeanChinJunKai · 2023-01-25T02:26:59Z

Duke

Duke frees your mind of having to remember things you need to do. It's,

text-based
easy to learn
-~~FAST~~ SUPER FAST to use

All you need to do is,

download it from here.
double-click it.
add your tasks.
let it manage your tasks for you 😉

And it is FREE!

Features:

Managing tasks
Managing deadlines (coming soon)
Reminders (coming soon)

If you Java programmer, you can use it to practice Java too. Here's the main method:

public class Main {
    public static void main(String[] args) {
        Application.launch(MainApp.class,args);
    }
}

# Conflicts: # src/main/java/duke/Duke.java # src/main/java/duke/Parser.java # src/main/java/duke/Ui.java

# Conflicts: # src/main/java/duke/Duke.java # src/main/java/duke/Parser.java # src/main/java/duke/TaskList.java # src/main/java/duke/Ui.java

JamesLiuZX

Overall great coding standards! Can tell that you are an experienced programmer so I don't have much to add apart from exceptions and packaging which are not really coding standards. Keep up the good work!

JamesLiuZX · 2023-02-02T14:18:44Z

src/main/java/duke/Parser.java

+            break;
+        }
+        default:
+            throw new DukeException("Invalid command entered!");


Good cases of exception handling! The exceptions can be more specific if time permits, but since this is a chatbot that focuses heavily on UI, there isn't really a need for too much exception handling either beyond printing error messages.

JamesLiuZX · 2023-02-02T14:20:01Z

src/main/java/duke/Storage.java

+    private static final String DIR_PATH = System.getProperty("user.home") + "/ip/data";
+    private String filePath;


Good job on setting the variables as private! Also for using final appropriately.

Good work on making the file paths private

JamesLiuZX · 2023-02-02T14:23:22Z

src/main/java/duke/Storage.java

+     * @return Task object.
+     * @throws DukeException if there is an error reading the file.
+     */
+    public static Task readTaskString(String input) throws DukeException {


This method could be under Parser, I think even though it is under the context of the text file it is still a parser method.

gekhro · 2023-02-05T12:26:11Z

src/main/java/duke/Duke.java

+     * @return string to be displayed to user.
+     */
+
+    public String getResponse(String input) {


maybe shift the getResponse method to the command class, this could simplify code in duke.java. Enum list could be in the parser class as well

gekhro · 2023-02-05T13:03:49Z

src/main/java/duke/Storage.java

+    private static final String DIR_PATH = System.getProperty("user.home") + "/ip/data";
+    private String filePath;


Good work on making the file paths private

gekhro · 2023-02-05T13:05:13Z

src/main/java/duke/Task.java

+ *
+ * @author Sean Chin Jun Kai
+ */
+public class Task {


good job on making javdocs for your methods

gekhro · 2023-02-05T13:06:18Z

src/main/java/duke/TaskList.java

+     * @return chosen Task.
+     * @throws DukeException if given ID does not exist in TaskList.
+     */
+    public Task getTask(int taskNumber) throws DukeException {


good use of dukeException to convert the default array out of bounds exception to a custom one

Duke methods does not adhere to code quality standards. Poor code quality can result in readers not being able to understand the code whilst making it more prone to bugs and errors. Usage of blank lines in order to implement logical structuring of code in the getResponse method and the removal of redundant method calls in the same method. By laying out the code such that it adheres to logical structure, this makes it very clear for readers to easily tell at a glance what we are doing. Furthermore, the removal of redundant code can reduce the complexity of code being read by readers allowing them to better understand our intentions as the developer.

This reverts commit d0c8071.

Duke methods does not adhere to code quality standards. Poor code quality can result in readers not being able to understand the code whilst making it more prone to bugs and errors. Usage of blank lines in order to implement logical structuring of code in the getResponse method and the removal of redundant method calls in the same method. By laying out the code such that it adheres to logical structure, this makes it very clear for readers to easily tell at a glance what we are doing. Furthermore, the removal of redundant code can reduce the complexity of code being read by readers allowing them to better understand our intentions as the developer.

Parser methods do not adhere to code quality standards. Poor code quality can result in readers not being able to understand the code whilst making it more prone to bugs and errors. Usage of blank lines in order to implement logical structuring of code whilst implementing guard clauses to make happy path prominent. By laying out the code such that it adheres to logical structure, this makes it very clear for readers to easily tell at a glance what we are doing. Furthermore, the use of guard clauses prevent readers from getting distracted by alternative paths taken when error conditions happen

Add basic assertions

Adhering to code quality

damithc and others added 30 commits July 31, 2022 17:20

Add Gradle support

556af3f

Updated gitignore to exclude .class files

643f60b

Completed Level 1

6822983

Edited console display by inserting tab

5cae928

Completed Level 2

3c4e9ec

Completed Level 3

15412a9

Added getStatusIcon and removed id

b6c832a

Completed Level 4

3165949

Completed A-TextUiTesting

6b5d4b1

Completed Level-5

9a878c1

Completed Level-6

5439fe8

Code reformatting

9e1cdb9

Updated A-TextUITesting

59ef801

Complete Level-7

7d3f41b

Complete Level-8

ddd59b7

Merge branch 'branch-Level-8'

0cfedee

Fix load deadline functionality

feca082

Merge branch 'add-gradle-support'

3c665c8

Add Checkstyle

977f8d9

Add more OOP

56e00c7

Remove unneeded files

ffa4c75

Organise classes into duke package

91e173e

Add JUnit Tests

2c264f6

Add JavaDocs

c6113f3

Tweak code to comply with coding standard

c4c3597

Add search functionality

1cf5652

Merge branch 'branch-A-CodingStandard'

63a520a

# Conflicts: # src/main/java/duke/Duke.java # src/main/java/duke/Parser.java # src/main/java/duke/Ui.java

Merge branch 'branch-Level-9'

a688b7b

# Conflicts: # src/main/java/duke/Duke.java # src/main/java/duke/Parser.java # src/main/java/duke/TaskList.java # src/main/java/duke/Ui.java

Update Javadocs

8393fd3

Configure styling to match Gradle CheckStyle

d8a07b6

SeanChinJunKai added 5 commits February 1, 2023 00:44

Refactor code to make full use of TaskList abstraction

de01c38

Refactor code for find functionality

10e8457

Add Level-10 functionality

485e150

Update javadocs

544fe38

Edit JavaDocs Part 2

eba2388

JamesLiuZX reviewed Feb 2, 2023

View reviewed changes

gekhro reviewed Feb 5, 2023

View reviewed changes

SeanChinJunKai and others added 16 commits February 7, 2023 20:32

Update gradle build file

5bf1a91

Add basic assertions

a7f5fe7

Revert "Refactor Duke class to adhere to code quality standards"

c7761f3

This reverts commit d0c8071.

Refactor Storage, TaskList and Test classes

a938691

Merge pull request #1 from SeanChinJunKai/branch-A-Assertions

8dd0a38

Add basic assertions

Merge branch 'master' into branch-A-CodeQuality

f34e6ee

Merge pull request #2 from SeanChinJunKai/branch-A-CodeQuality

4a7209f

Adhering to code quality

Fix missing curly braces

49373da

Fix missing text before displaying tasks in the list

a84045c

Add duplicate task detection functionality

2862bfd

Add abstraction for Duke commands

3ed7a81

Added product name to application window

510e77b

Update README.md to be the user guide

00f8d9d

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SeanChinJunKai] iP #209

[SeanChinJunKai] iP #209

SeanChinJunKai commented Jan 25, 2023 •

edited

JamesLiuZX left a comment

JamesLiuZX Feb 2, 2023

JamesLiuZX Feb 2, 2023 •

edited

gekhro Feb 5, 2023

JamesLiuZX Feb 2, 2023

gekhro Feb 5, 2023

gekhro Feb 5, 2023

gekhro Feb 5, 2023

gekhro Feb 5, 2023

		private static final String DIR_PATH = System.getProperty("user.home") + "/ip/data";
		private String filePath;

[SeanChinJunKai] iP #209

Are you sure you want to change the base?

[SeanChinJunKai] iP #209

Conversation

SeanChinJunKai commented Jan 25, 2023 • edited

Duke

JamesLiuZX left a comment

Choose a reason for hiding this comment

JamesLiuZX Feb 2, 2023

Choose a reason for hiding this comment

JamesLiuZX Feb 2, 2023 • edited

Choose a reason for hiding this comment

gekhro Feb 5, 2023

Choose a reason for hiding this comment

JamesLiuZX Feb 2, 2023

Choose a reason for hiding this comment

gekhro Feb 5, 2023

Choose a reason for hiding this comment

gekhro Feb 5, 2023

Choose a reason for hiding this comment

gekhro Feb 5, 2023

Choose a reason for hiding this comment

gekhro Feb 5, 2023

Choose a reason for hiding this comment

SeanChinJunKai commented Jan 25, 2023 •

edited

JamesLiuZX Feb 2, 2023 •

edited