[ryanjansen] iP #219

ryanjansen · 2023-01-25T05:24:02Z

Duke

Duke is a simple, easy to use task manager for those who can't remember jack.

Features

Add tasks
Delete tasks
Mark tasks as done

How to add a task

Type "todo" followed by the title to add a todo
Type "event" followed by the title, from date and to date to add a event
Type "deadline" followed by the title, date, to add deadline

Here's a demo of checking a task:

A task
Another task

Here's an example of the code:

public class Main { public static void main(String[] args) { Application.launch(MainApp.class, args); } }

UnwilledTangent

I'm very impressed with your coding standards! Well done! The most that I have observed is just whitespaces that need to be added here and there! Other than that, no major violations! Keep up the good work! I'm sure that you will be a good programmer in the tP if you keep this coding standard up! :) Jiayous for the rest of CS2103!

UnwilledTangent · 2023-02-03T14:44:24Z

src/main/java/duke/TaskList.java

+    private ArrayList<Task> tasks;
+
+    public TaskList() {
+        this.tasks = new ArrayList<>(100);


Oh? Is there a need to specify the capacity to 100? Why not use the default capacity, which is
this.tasks = new ArrayList<>();

UnwilledTangent · 2023-02-03T14:49:10Z

src/main/java/duke/command/Command.java

+package duke.command;
+import duke.TaskList;
+import duke.Ui;
+import duke.Storage;


Might want to put a whitespace like so :)

package duke.command;

import duke.TaskList;
import duke.Ui;
import duke.Storage;

UnwilledTangent · 2023-02-03T14:49:48Z

src/main/java/duke/command/DeleteCommand.java

+import duke.task.Task;
+public class DeleteCommand extends Command {


Might want to add a whitespace here! :)

UnwilledTangent · 2023-02-03T14:50:05Z

src/main/java/duke/command/DeleteCommand.java

+    }
+    @Override


Whitespace here too!

UnwilledTangent · 2023-02-03T14:51:26Z

src/main/java/duke/command/EventCommand.java

+import java.time.LocalDate;
+public class EventCommand extends Command {


Whitespace here too! :)

UnwilledTangent · 2023-02-03T14:59:24Z

src/main/java/duke/task/Todo.java

+
+

Suggested change

2 spaces here!

UnwilledTangent · 2023-02-03T14:59:42Z

src/main/java/duke/task/Todo.java

+
+

Suggested change

2 spaces here! should be 1!

UnwilledTangent · 2023-02-03T15:00:34Z

src/test/java/duke/command/ExitCommandTest.java

+import static org.junit.jupiter.api.Assertions.assertEquals;
+public class ExitCommandTest {


Suggested change

import static org.junit.jupiter.api.Assertions.assertEquals;

public class ExitCommandTest {

import static org.junit.jupiter.api.Assertions.assertEquals;

public class ExitCommandTest {

Whitespace here too! :)

UnwilledTangent · 2023-02-03T15:01:25Z

text-ui-test/input.txt

+deadline finish ip /by 2359
+event lecture /from now /to later
+list
+todo survive one more day
+mark 1
+list
+mark 3
+unmark 3
+list
+bye


No need to push test files! Can gitignore! :)

UnwilledTangent · 2023-02-03T15:01:46Z

text-ui-test/EXPECTED.TXT

+    ____________________________________________________________
+     Hello! I'm Duke
+     What can I do for you?
+    ____________________________________________________________
+    ____________________________________________________________
+     Got it. I've added this task:
+       [D][ ] finish ip (by: 2359)
+     Now you have 1 tasks in the list
+    ____________________________________________________________
+    ____________________________________________________________
+     Got it. I've added this task:
+       [E][ ] lecture (from: now to: later)
+     Now you have 2 tasks in the list
+    ____________________________________________________________
+    ____________________________________________________________
+     Here are the tasks in your list:
+     1.[D][ ] finish ip (by: 2359)
+     2.[E][ ] lecture (from: now to: later)
+    ____________________________________________________________
+    ____________________________________________________________
+     Got it. I've added this task:
+       [T][ ] survive one more day
+     Now you have 3 tasks in the list
+    ____________________________________________________________
+    ____________________________________________________________
+     Nice! I've marked this task as done:
+       [D][X] finish ip (by: 2359)
+    ____________________________________________________________
+    ____________________________________________________________
+     Here are the tasks in your list:
+     1.[D][X] finish ip (by: 2359)
+     2.[E][ ] lecture (from: now to: later)
+     3.[T][ ] survive one more day
+    ____________________________________________________________
+    ____________________________________________________________
+     Nice! I've marked this task as done:
+       [T][X] survive one more day
+    ____________________________________________________________
+    ____________________________________________________________
+     OK! I've marked this task as not done yet:
+       [T][ ] survive one more day
+    ____________________________________________________________
+    ____________________________________________________________
+     Here are the tasks in your list:
+     1.[D][X] finish ip (by: 2359)
+     2.[E][ ] lecture (from: now to: later)
+     3.[T][ ] survive one more day
+    ____________________________________________________________
+    ____________________________________________________________
+     Bye. Hope to see you again soon!
+    ____________________________________________________________


No need to push test files! Can gitignore! :)

Refactored much of the code to make it more readable. Main changes were removing nested if statements, refactoring them into switch statements instead and removing unecessary string builder instances from the UI class.

Assert that the title of the new tasks added match the title passed to the respective method.

Added assertions

Improved code quality

damithc and others added 11 commits July 31, 2022 17:20

Add Gradle support

556af3f

Implemented Level-1

61d6abb

Implemented Level 2

f4eab40

Implemented Level 3

36f7aaf

Implemented Level 4

a6920dc

Implemented Text UI Testing

803d807

Implemented Level 5

8a16db6

Implemented Level 6

13f9c38

Implemented Level 7

68c91e5

Implemented Level 8

7d45851

Merge branch 'branch-Level-7'

874059b

ryanjansen force-pushed the master branch from 7d45851 to 874059b Compare January 25, 2023 06:47

ryanjansen added 14 commits January 25, 2023 14:48

Merge branch 'branch-Level-8'

7d927b5

Implemented A-MoreOOP

cc1497e

Implemented A-Packages

d5a6495

Merge remote-tracking branch 'upstream/add-gradle-support'

fd62537

Implemented Gradle

9a6296e

Implemented A-JUnit

56c162a

Added java docs

1e36159

followed coding standards

8e58e5f

Implemented Level 9

ea4e804

Merge branch 'branch-A-JavaDoc'

a8fa9e2

Merge branch 'branch-A-CodingStandard'

3021cdb

Merged branch-Level-9 into master

4c1730a

Added GUI

e45bf15

Merge branch 'branch-Level-10'

8080c24

UnwilledTangent reviewed Feb 3, 2023

View reviewed changes

ryanjansen added 3 commits February 16, 2023 14:21

Improved code quality

37024cd

Refactored much of the code to make it more readable. Main changes were removing nested if statements, refactoring them into switch statements instead and removing unecessary string builder instances from the UI class.

Added assertions

d53ff63

Assert that the title of the new tasks added match the title passed to the respective method.

Merge pull request #2 from ryanjansen/branch-A-Assertions

d041b0a

Added assertions

ryanjansen added 6 commits February 16, 2023 14:42

Merge branch 'master' into branch-A-CodeQuality

a6fdc9e

Merge pull request #3 from ryanjansen/branch-A-CodeQuality

1e1c912

Improved code quality

Added snooze extension

f1a9b69

A-UserGuide

4ac9477

A-Release

1ff5161

Updated docs

85e3656

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ryanjansen] iP #219

[ryanjansen] iP #219

ryanjansen commented Jan 25, 2023 •

edited

UnwilledTangent left a comment

UnwilledTangent Feb 3, 2023

UnwilledTangent Feb 3, 2023

UnwilledTangent Feb 3, 2023

UnwilledTangent Feb 3, 2023

UnwilledTangent Feb 3, 2023

UnwilledTangent Feb 3, 2023

UnwilledTangent Feb 3, 2023

UnwilledTangent Feb 3, 2023

UnwilledTangent Feb 3, 2023

UnwilledTangent Feb 3, 2023

		import duke.task.Task;
		public class DeleteCommand extends Command {

		import java.time.LocalDate;
		public class EventCommand extends Command {

		import static org.junit.jupiter.api.Assertions.assertEquals;
		public class ExitCommandTest {

[ryanjansen] iP #219

Are you sure you want to change the base?

[ryanjansen] iP #219

Conversation

ryanjansen commented Jan 25, 2023 • edited

Duke

UnwilledTangent left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ryanjansen commented Jan 25, 2023 •

edited