[sarthak181] iP #225
Open
[sarthak181] iP #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wz2k
reviewed
Jan 31, 2023
src/main/java/Duke.java
Outdated
Comment on lines
23
to
92
| switch (getSwitch(str)) { | ||
| case 0: | ||
| int n; | ||
| Task t; | ||
| String num; | ||
| num = str.substring(5); | ||
| n = Integer.parseInt(num) - 1; | ||
| t = list.get(n); | ||
| t.markAsDone(); | ||
| System.out.println("Nice! I've marked this task as done:\n" | ||
| + " [" + t.getStatusIcon() + "] " + t.description); | ||
| break; | ||
| case 1: | ||
| int n_1; | ||
| Task t_1; | ||
| String num_1; | ||
| num_1 = str.substring(7, 9); | ||
| n_1 = Integer.parseInt(num_1) - 1; | ||
| t_1 = list.get(n_1); | ||
| t_1.unMark(); | ||
| System.out.println("OK, I've marked this task as not done yet:\n" | ||
| + " [" + t_1.getStatusIcon() + "] " + t_1.description); | ||
| break; | ||
| case 2: | ||
| Task a; | ||
| try { | ||
| a = new Todo(str.substring(5)); | ||
| } catch (DukeException e) { | ||
| System.out.println(e.getMessage()); | ||
| break; | ||
| } | ||
| list.add(a); | ||
| System.out.println("Got it. I've added this task:\n " | ||
| + a.toString() + "\nNow you have " + list.size() | ||
| + " tasks in the list."); | ||
| break; | ||
| case 3: | ||
| int ind = str.indexOf("/by"); | ||
| Task b = null; | ||
| try { | ||
| b = new Deadline(str.substring(9, ind), str.substring(ind+3)); | ||
| } catch (DukeException e) { | ||
| System.out.println(e.getMessage()); | ||
| break; | ||
| } | ||
| list.add(b); | ||
| System.out.println("Got it. I've added this task:\n " | ||
| + b.toString() + "\nNow you have " + list.size() | ||
| + " tasks in the list."); | ||
| break; | ||
| case 4: | ||
| int index_1 = str.indexOf("/from"); | ||
| int index_2 = str.indexOf("/to"); | ||
| Task c = null; | ||
| try { | ||
| c = new Event(str.substring(6, index_1), str.substring(index_1+5, index_2), | ||
| str.substring(index_2 + 3)); | ||
| } catch (DukeException e) { | ||
| System.out.println(e.getMessage()); | ||
| break; | ||
| } | ||
| list.add(c); | ||
| System.out.println("Got it. I've added this task:\n " | ||
| + c.toString() + "\nNow you have " + list.size() | ||
| + " tasks in the list."); | ||
| break; | ||
| case 5: | ||
| System.out.println("☹ OOPS!!! I'm sorry, but I don't know what that means :-("); | ||
|
|
||
| } |
There was a problem hiding this comment.
cases in switch statements should not be indented. eg
switch (variable) {
case 0:
return 0;
case 1:
return 1;
}
src/main/java/Duke.java
Outdated
Comment on lines
104
to
108
| if (str.startsWith("mark ")) return 0; | ||
| if (str.startsWith("unmark ")) return 1; | ||
| if (str.startsWith("todo ")) return 2; | ||
| if (str.startsWith("deadline ")) return 3; | ||
| if (str.startsWith("event ")) return 4; |
There was a problem hiding this comment.
Use K&R style brackets. eg
if (condition) {
return 0;
}I suggest just using the string directly in the switch statement but this is entirely up to you.
src/main/java/Duke.java
Outdated
| @@ -1,3 +1,5 @@ | |||
| import java.util.*; | |||
|
|
|||
| public class Duke { | |||
There was a problem hiding this comment.
Classes should be placed in a package. You can just place all your current class in a duke package minimally
src/main/java/Event.java
Outdated
| protected String from; | ||
| protected String to; | ||
|
|
||
| public Event(String description, String from, String to) throws DukeException{ |
There was a problem hiding this comment.
'DukeException{'. Missed out on a space between n and {.
src/main/java/Duke.java
Outdated
| @@ -1,3 +1,5 @@ | |||
| import java.util.*; | |||
There was a problem hiding this comment.
Wildcard imports should not be used. Imported classes should be listed explicitly
# Conflicts: # src/main/java/duke/TaskList.java
Merge Added Assertions
Changed the way that the code responds when an exception is caught. Changed it so that when an exception is caught, the Duke bot actually tells the user that there is an error.
This help command is simply the user typing help in all lowercase and hitting enter. The commands aren't too easy to remember, so this help command will make it easier to use the app.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.