[liujiayue314] iP #233

liujiayue314 · 2023-01-25T12:11:10Z

Duke task planner

"He who fails to plan is planning to fail" -- Winston Churchill
(Source)

DukePro is a task planner that is free, downloadable it from here!.
Programmers can also use it in intelliJ, by running main method. 🧑‍💻

It frees your mind of having to remember things you need to do. It's

Fast to install
Suitable for fast typers
~~Easy~~ Super Easy to use

It can

Manage task
Manage deadline
Set reminders (coming soon!)

Currently, the features are

Add/Delete task
Mark/Unmark task
Search task by keywords

public class Main {
    public static void main(String[] args) {
        Application.launch(MainApp.class, args);
    }
}

jiexuanc

Overall, aside from missing JavaDocs and some coding violations, the code can be easily understood, variables and methods are well named

jiexuanc · 2023-02-01T11:16:56Z

src/main/java/Main/Duke.java

@@ -0,0 +1,42 @@
+package Main;


I think package name should be all lower case.

jiexuanc · 2023-02-01T11:20:30Z

src/main/java/Task/Task.java

+
+
+    public abstract String toText();
+    abstract public LocalDate getDate();


Suggested change

abstract public LocalDate getDate();

public abstract LocalDate getDate();

jiexuanc · 2023-02-01T11:22:02Z

src/main/java/Command/DeadlineCommand.java

+import Task.Task;
+
+public class DeadlineCommand extends Command {
+    String description;


Maybe having a private access modifiers for attributes would be better?

cjyothika

Generally, your code is readable and formatted well other than a few minor details. Nice work!

cjyothika · 2023-02-01T15:27:53Z

src/main/java/main/Ui.java

+
+public class Ui {
+
+    private static final String indentation = "     ";


Perhaps these constant names can be in all caps?

cjyothika · 2023-02-01T15:29:56Z

src/main/java/task/Event.java

+    @Override
+    public String toString() {
+        return "[E]" + super.toString() + " (from: "
+                + formatOfDate.format(startDate) + " to: " + formatOfDate.format(endDate) + ")";


Good job! This looks like the right indentation for this scenario. Looks like there are no line length issues with your code and you broke your line before an operator.

cjyothika · 2023-02-01T15:35:30Z

src/main/java/command/MarkCommand.java

+import task.Task;
+
+public class MarkCommand extends Command {
+    int index;


Perhaps this class variable should be declared private?

cjyothika · 2023-02-01T15:36:52Z

src/main/java/command/UnmarkCommand.java

+
+public class UnmarkCommand extends Command{
+
+    int index;


Similar to the comment in the MarkCommand class, do consider making this variable private.

Apply GFMD in description

…than starting date of event Currently, user can add an event with any ending and starting date. Users should be informed of their mistake and be prompted to change. Let's check for wrong dates and raise an exception when the mistake is detected.

Add event task: inform users when ending date of an event is earlier …

Branch a code quality

Previously, users have to manually add task. Manually adding task can be tedious and users might be forgetful in adding the task. Recurring command is more user-friendly because users can leave the task to the task planner. Let's, * update input and output to read recurring command * update the task planner to mark task as not done when the task refreshes.

damithc and others added 17 commits July 31, 2022 17:20

Add Gradle support

556af3f

added greet, echo, exit

af53a20

added: task class + add and list interface

52a0e65

added: mark and unmark interface

ae32c23

added: Deadline, Event, Todo class

3362aad

Fixed syntax and indentation, added input and expected output txt

dfe702e

Added: handling error features

8742c3d

Added: delete interface

4d95350

added: Enum

6d67c52

Add a saving feature

a00748d

Add date function

5f789aa

Merge branch 'branch-Level-7'

3b2e656

Resolve conflict between two merges

d00ef5c

Change the OOP structure

53b70c6

Classify into three package: Main, Task, Command

38dafd0

Merge remote-tracking branch 'origin/add-gradle-support'

6514c20

Add gradle

1d24eeb

jiexuanc reviewed Feb 1, 2023

View reviewed changes

Add JUnit tests

93f23b1

cjyothika reviewed Feb 1, 2023

View reviewed changes

liujiayue314 and others added 10 commits February 2, 2023 02:10

Add javadocs

33e30eb

Comply with a coding standard

c5cc9a0

Add find method

11220ed

Merge branch 'branch-A-CodingStandard' into branch-Level-9

f6941a6

Merge branch 'branch-A-CodingStandard'

4a4a8f0

Merge branch 'branch-Level-9'

12f271d

Update README.md

3baf80d

Apply GFMD in description

Checkstyle

dc64d6c

Checkstyle

d4b851b

Merge commit 'dc64d6cade8c03af6b4b41a704c532c29e634569'

db633e7

liujiayue314 and others added 27 commits February 7, 2023 02:57

Add GUI

cd71593

Merge branch 'branch-Level-10'

d67fc48

Update README.md

cff4518

Update build.gradle

fb81c15

Improve code quality

15a431d

Merge pull request #2 from liujiayue314/branch-A-Assertions

ba931dd

Add event task: inform users when ending date of an event is earlier …

Merge branch 'master' into branch-A-CodeQuality

68ec199

Merge pull request #3 from liujiayue314/branch-A-CodeQuality

8fdc9b3

Branch a code quality

Set up CI

5857040

Improved coding quality

1472e5b

Merge branch 'branch-Extension'

5dbf4da

Updated JavaDoc

236ffad

Merge branch 'branch-A-JavaDoc'

a0e2537

Update README.md

88562ca

Update checkstyle

4240276

update test files

e42d86e

modified task

095b2b7

Updated test files

451b553

Added Ui.png

6f24dc6

Add a User Guide

04c0d2a

updated test files

340dd88

updated user guide

e9b3d35

minor changes to format

6f070c5

Merge branch 'branch-Level-9'

a5edb2a

Update README.md

e517164

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[liujiayue314] iP #233

[liujiayue314] iP #233

liujiayue314 commented Jan 25, 2023 •

edited

jiexuanc left a comment

jiexuanc Feb 1, 2023

jiexuanc Feb 1, 2023

jiexuanc Feb 1, 2023

cjyothika left a comment

cjyothika Feb 1, 2023

cjyothika Feb 1, 2023

cjyothika Feb 1, 2023

cjyothika Feb 1, 2023



		public abstract String toText();
		abstract public LocalDate getDate();

	abstract public LocalDate getDate();
	public abstract LocalDate getDate();


		public class Ui {

		private static final String indentation = " ";

[liujiayue314] iP #233

Are you sure you want to change the base?

[liujiayue314] iP #233

Conversation

liujiayue314 commented Jan 25, 2023 • edited

Duke task planner

jiexuanc left a comment

Choose a reason for hiding this comment

jiexuanc Feb 1, 2023

Choose a reason for hiding this comment

jiexuanc Feb 1, 2023

Choose a reason for hiding this comment

jiexuanc Feb 1, 2023

Choose a reason for hiding this comment

cjyothika left a comment

Choose a reason for hiding this comment

cjyothika Feb 1, 2023

Choose a reason for hiding this comment

cjyothika Feb 1, 2023

Choose a reason for hiding this comment

cjyothika Feb 1, 2023

Choose a reason for hiding this comment

cjyothika Feb 1, 2023

Choose a reason for hiding this comment

liujiayue314 commented Jan 25, 2023 •

edited