[dsja612] iP #239
Open
[dsja612] iP #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great job dude 👍 |
sumhungyee
reviewed
Jan 31, 2023
src/main/java/views/UI.java
Outdated
Comment on lines
31
to
32
| * Displays a list of possible commands | ||
| * to the user |
There was a problem hiding this comment.
Might it be better to end with a fullstop?
src/main/java/tasks/Event.java
Outdated
Comment on lines
19
to
21
| * @param name Name of the task | ||
| * @param startDate Starting date of the task | ||
| * @param endDate Ending date of the task |
There was a problem hiding this comment.
Might it be better to add a fullstop behind these lines?
src/main/java/storage/Storage.java
Outdated
| } | ||
| case "D": { | ||
| String by = inputList[2]; | ||
| LocalDateTime deadline = LocalDateTime.parse(by, DateTimeFormatter.ofPattern("yyyy-MM-dd'T'HH:mm")); |
sumhungyee
reviewed
Jan 31, 2023
|
|
||
| /** | ||
| * Constructor for DukeException that stores an error message. | ||
| * @param message Main body of error message |
There was a problem hiding this comment.
Perhaps this needs capitalising as well!
src/main/java/storage/Storage.java
Outdated
|
|
||
| /** | ||
| * Loads tasks from a local file into a TaskList, creates one if one does not exist. | ||
| * @throws IOException If fail to load/create a storage file |
There was a problem hiding this comment.
Perhaps this needs capitalising as well!
src/main/java/storage/Storage.java
Outdated
Comment on lines
85
to
87
| String[] inputList = input.split(","); | ||
| String taskType = inputList[0]; | ||
| String taskName = inputList[1]; |
There was a problem hiding this comment.
Your code here looks extremely readable! 👓
The GUI does not automatically close after the bye command is entered. The size of the window is also too small to display the initial list of supported commands. The GUI will now automatically close after a 3 second delay. Also, the GUI window is a bit bigger to accommodate long lists of text in the future if needed.
Add assertions for multiple files
Change Find command to use streams
Improve on code quality
Add command for user to find closest free day
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duke
Yet another school project??
Duke is a task manager written in Java, in an object-oriented manner. This is all so you can live your life in a task-oriented manner 🤓
"Pfft, why would I use Duke instead of Google Calendar??" - 🤓
And it is FREE!
Features
Download it here!
If you want to learn Java & OOP:
Feel free to check out how Duke is organized. Duke starts running from this code block in
Duke.java: