[chongweiguan] iP #244
Open
[chongweiguan] iP #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
izzhafeez
reviewed
Jan 31, 2023
src/main/java/Duke.java
Outdated
Comment on lines
109
to
111
| LocalDateTime formattedstartTime = LocalDateTime.parse(from, dateTimeFormatter); | ||
| LocalDateTime formattedendTime= LocalDateTime.parse(to, dateTimeFormatter); | ||
| Event event = new Event(command.substring(0,fromStart-7), formattedstartTime, formattedendTime); |
There was a problem hiding this comment.
Hi, I'm your commenter and I would like to confirm whether the camelCase for these variable declarations has been fixed? Otherwise, great job on the clean code!
afiqzu
reviewed
Feb 3, 2023
src/main/java/duke/Duke.java
Outdated
| import java.io.FileReader; | ||
| import java.io.FileWriter; | ||
| import java.io.IOException; | ||
| import java.util.*; |
There was a problem hiding this comment.
You might want to list out the specific imports instead of using a wildcard import
src/main/java/duke/UI.java
Outdated
|
|
||
| String[] taskDescription = list.getTask(i).getDescription().split(" "); | ||
| for (String word : taskDescription) { | ||
| if(keyword.equals(word)) { |
There was a problem hiding this comment.
Minor coding standard violation but there should be a whitespace after 'if'
This reverts commit 8aaa678.
Merge A-Assertion include assert statements in java files when required
A-CodeQuality
Code quality fixes on all java files, made method length shorter and added Javadoc comments Good software engineering practices Made method length shorter by abstracting out the function into separate methods, and added Javadoc comments for methods without JavaDoc comments Abstracting out the functions into separate methods is preferable that helps with reading
Documentation for class fields added for better readability
Added javaDoc comments
A-CodeQuality
Added more JavaDoc for documentation and good software engineering practices
Add a feature that allows a user to add a task that needs to be done within a certain period
Trim out trailing white spaces
A-CodeQuality
Add JavaDoc description to ensure better readability and better documentation
Add JavaDoc for setDuke method in MainWindow.java It allows for better readability and documentation is good software engineering practice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DukeBot
DukePro frees your mind of having to remember things you need to do. It's,
FASTSUPER FAST to useWhere do I begin?
All you need to do is,
And it is FREE
Features