[kimberlybp] iP #245

kimberlybp · 2023-01-25T14:56:47Z

Sirius

"Time is the scarcest resource and unless it is managed nothing else can be managed." - Peter Drucker (source)

Sirius is a CLI app that helps you manage your time. It's,

text-based
easy to use
~~FAST~~ SUPER FAST to use

In order to use it..

Download the JAR file from here
Double-click it
Add your tasks
Let Sirius handle the rest! 😎

Features

List all your tasks
Manage Todos, Deadlines and Events
Reminders (Coming soon!)

Devs feel free and play around with the code

Here's a preview of the main method:

public static void main(String[] args) {
    new Duke(PATH).run();
}

Skeltons

I've noticed that your Ui class is not being used properly as some classes are still printing to console without calling the Ui class. Overall, your code looks good to me!

Skeltons · 2023-02-01T15:03:40Z

src/main/java/commands/CommandType.java

+        this.value = value;
+    }
+
+    public boolean equals(String input) {


Perhaps the methods should be called isEqual?

I think isEqual is a good idea!

Skeltons · 2023-02-01T15:06:45Z

src/main/java/duke/Parser.java

+import commands.*;
+import exceptions.DukeException;
+import tasks.*;


Shouldn't wildcard imports be avoided?

Skeltons · 2023-02-01T15:08:04Z

src/main/java/duke/Storage.java

+import tasks.*;
+
+import java.io.*;


Shouldn't wildcard imports be avoided?

Skeltons · 2023-02-01T15:09:24Z

src/main/java/duke/Storage.java

+                case "T":
+                    initList.add(new Todo(taskDesc, isCompleted));
+                    break;
+                case "D":
+                    initList.add(new Deadline(taskDesc, isCompleted, strArr[3]));
+                    break;
+                case "E":
+                    initList.add(new Event(taskDesc, isCompleted, strArr[3], strArr[4]));
+                    break;


Shouldn't there be no indentation between switch and case?

jinbesan · 2023-02-03T06:39:13Z

src/main/java/duke/Duke.java

+import java.util.Scanner;
+
+public class Duke {
+    private static final String PATH = "data/Duke.txt";


Nice use of capitalization for constants

jinbesan · 2023-02-03T06:40:21Z

src/main/java/commands/CommandType.java

+        this.value = value;
+    }
+
+    public boolean equals(String input) {


I think isEqual is a good idea!

jinbesan · 2023-02-03T06:42:35Z

src/main/java/duke/Parser.java

+    }
+
+    public static Command parse(String input) throws DukeException {
+        String[] inputArr = input.split(" ", 2);


Perhaps we can better understand this String array variable by naming it inputs or inputTokens?

jinbesan · 2023-02-03T06:43:56Z

src/main/java/duke/Parser.java

+                    throw new DukeException("Hey now.. The description of a deadline cannot be empty. >:(");
+                }
+                taskInput = inputArr[1];
+                String[] dArr = taskInput.split("/by", 2);


The naming of this array might not be immediately evident on what it is supposed to be, because of the short name. Perhaps we can use a more precise name?

jinbesan · 2023-02-03T06:49:56Z

src/main/java/duke/Storage.java

+    }
+
+    public List<Task> loadFile() throws Exception {
+        List<Task> initList = new ArrayList<>();


Perhaps we can rename this Collection variable to be tasks as it is a collection of Tasks?

Previous build.gradle file had duke.Duke as mainClassName, however due to GUI addition to duke, it needs to be updated to duke.Launcher to launch GUI Update mainClassName to duke.Launcher For JAR files to build and launch the main method of the correct class

Code can be further improved by applying code quality guidelines Refactor and apply guidelines such as SLAP, KISS. Also rename certain variables for better readability

Add Assertions

Improve code quality

damithc and others added 8 commits July 31, 2022 17:20

Add Gradle support

556af3f

Add Level 1. Greet, Echo, Exit

a5d695c

Add Level 2. Add, List

5c467ce

Add Level 3. Mark as Done

13479ab

Add Level 4. ToDos, Events, Deadlines

8f89d5c

Add A-TextUiTesting

886c279

Add Level 5. Handle Errors

7aa2f97

Add Level 6. Delete

f14b751

kimberlybp force-pushed the master branch from d064e0d to f14b751 Compare January 30, 2023 21:18

kimberlybp added 7 commits January 31, 2023 05:35

Add Level 8. Dates and Times

c00ed2e

Add Level 7. Save

14075a0

Merge branch 'branch-Level-7'

b351dfd

Merge branch 'branch-Level-8'

57beafc

Add A-MoreOOP, A-Enums

1ad5e01

Divide classes into packages, minor fixes

29db1f4

Merge remote-tracking branch 'origin/add-gradle-support'

134a31b

Skeltons reviewed Feb 1, 2023

View reviewed changes

jinbesan reviewed Feb 3, 2023

View reviewed changes

kimberlybp added 12 commits February 7, 2023 17:40

Update build.gradle shadowJar

7448a73

Add JUnit tests

cbd37e8

Add JavaDoc comments

ffe8cbd

Update code to comply with coding standard

13da630

Add Level 9. Find

dccaf69

Merge branch 'branch-A-JavaDoc'

65c979e

Merge branch 'branch-A-CodingStandard'

5bd30ac

Merge branch 'branch-Level-9'

1396cee

Add JavaDoc comments for Level-9

4382554

Add checkstyle scripts, clear checkstyle errors

8d1af60

Merge branch 'branch-A-CheckStyle'

db28b92

Fix data txt file not being created if no existing txt is found

ecc4425

Update build.gradle

ca3abd9

Previous build.gradle file had duke.Duke as mainClassName, however due to GUI addition to duke, it needs to be updated to duke.Launcher to launch GUI Update mainClassName to duke.Launcher For JAR files to build and launch the main method of the correct class

kimberlybp force-pushed the master branch from 33b784e to ca3abd9 Compare February 19, 2023 09:43

kimberlybp and others added 25 commits February 19, 2023 18:32

Add Assertions

9906a3b

Refactor to improve code quality

db3b9b7

Code can be further improved by applying code quality guidelines Refactor and apply guidelines such as SLAP, KISS. Also rename certain variables for better readability

Merge pull request #2 from kimberlybp/branch-A-Assertions

0eec7d0

Add Assertions

Merge remote-tracking branch 'origin/master' into branch-A-CodeQuality

bacefcb

Merge pull request #3 from kimberlybp/branch-A-CodeQuality

8ffd727

Improve code quality

Update code to clear checkstyle errors

ef09f98

Add priority param to Tasks

276d918

Merge branch 'branch-C-Extension'

f51fc79

Update Javadocs

dca71e9

Fix MarkCommand response message

252c1a2

Update package and chatbot class name

384a0f6

Update personality for duke

65ff555

Merge branch 'branch-A-Personality'

f50d22b

Change DukeException to NookException

42a0593

Update GUI to follow animal crossing theme

7024d38

Clear checkstyle errors

f8d24da

Merge branch 'branch-A-BetterGui'

1c6fa51

Add more error handling and improve existing error handling for Storage

bef5879

Merge branch 'branch-A-MoreErrorHandling'

ce51a7d

Add main window icon

9641bdb

Add placeholder message for List Command if no tasks

0ea3d82

Add Help Command

abc2b22

Enhance error handling in Parser to handle more edge cases

55d3b78

Clear checkstyle errors

61ca453

Update README.md, add Ui picture

eec9675

kimberlybp force-pushed the master branch from 02961f6 to eec9675 Compare February 20, 2023 10:57

kimberlybp added 2 commits February 20, 2023 19:12

Update Ui jpeg to png

06cb1a4

Update README.md

6bda66c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[kimberlybp] iP #245

[kimberlybp] iP #245

kimberlybp commented Jan 25, 2023 •

edited

Skeltons left a comment

Skeltons Feb 1, 2023

jinbesan Feb 3, 2023

Skeltons Feb 1, 2023

Skeltons Feb 1, 2023

Skeltons Feb 1, 2023

jinbesan Feb 3, 2023

jinbesan Feb 3, 2023

jinbesan Feb 3, 2023

jinbesan Feb 3, 2023

jinbesan Feb 3, 2023

		import tasks.*;

		import java.io.*;

[kimberlybp] iP #245

Are you sure you want to change the base?

[kimberlybp] iP #245

Conversation

kimberlybp commented Jan 25, 2023 • edited

Sirius

In order to use it..

Features

Devs feel free and play around with the code

Skeltons left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kimberlybp commented Jan 25, 2023 •

edited