[dohaduong] iP #263
Open
[dohaduong] iP #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users may want to undo the very last command. Undo command has been added to Duke. If the last command is only for listing/finding purpose, it will not be able to undone as these commands do not change any data that Duke has. Users can now undo the last command, given that it is applicable.
Users may want to undo the very last command let's, * update Duke's available commands so that undo can become a legit command * update Parser and Ui so that Duke can revert back to before the most recent command We need to update Parser and Ui classes as these classes are used to reply to users and get input from users directly
joytqt-1202
reviewed
Feb 10, 2023
Comment on lines
185
to
191
| } catch (IndexOutOfBoundsException e) { | ||
| throw new InvalidIndexException(); | ||
| } | ||
| } catch (InvalidIndexException e) { | ||
| return (e.getMessage()); | ||
| } | ||
| return new InvalidIndexException().getMessage(); |
There was a problem hiding this comment.
good catching of exception cases!
but instead of nested try-catch blocks, could you try to use try-catch-catch instead?
try (...) { ... } catch (...) { ... } catch (...) { ... }
Update GUI: Avatar in circle
A personality
Delete all command has minor error of clearing the whole task list Updating delete all command helps users to use it more efficiently Let's update the command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duke
Your friendly task management app
Your busy life deserves this.
Duke is
To start using Duke, you only need to follow these steps:
Available features:
Duke can be used to practice your Java as a programmer too! Here's the
mainmethod for you to start with: