[Nevin Lim] iP #270
Open
[Nevin Lim] iP #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ba73214.
Emrysil
reviewed
Jan 30, 2023
src/main/java/Deadline.java
Outdated
| @@ -0,0 +1,14 @@ | |||
| public class Deadline extends Task { | |||
|
|
|||
| protected String by; | |||
There was a problem hiding this comment.
Would it be better to use private modifier here? Or is there a particular reason to use protected?
src/main/java/Duke.java
Outdated
| System.out.println("____________________________________________________________\n" + | ||
| "Nice! I've marked this task as done:\n" + | ||
| " " + tasks.get(num - 1).toString() + "\n" + | ||
| "____________________________________________________________"); |
There was a problem hiding this comment.
I think you could make the line breaks private fields so that you don't need to type so many times
src/main/java/Duke.java
Outdated
| public class Duke { | ||
| private static final String greeting = "____________________________________________________________\n" + "Hello! I'm Duke\n" + "What can I do for you?\n" + "____________________________________________________________"; |
There was a problem hiding this comment.
I think for static final fields, the variable name should all be in uppercase:)
src/main/java/Duke.java
Outdated
| public class Duke { | ||
| private static final String greeting = "____________________________________________________________\n" + "Hello! I'm Duke\n" + "What can I do for you?\n" + "____________________________________________________________"; | ||
| private static final String goodbye = "____________________________________________________________\n" + "Bye. Hope to see you again soon!\n" + "____________________________________________________________"; | ||
| private static boolean active = true; |
There was a problem hiding this comment.
perhaps rename to isActive to make the variable sound more boolean?
src/main/java/DukeException.java
Outdated
| @@ -0,0 +1,7 @@ | |||
| import java.util.*; | |||
There was a problem hiding this comment.
Maybe specify the class being imported instead of just importing *
# Conflicts: # src/main/java/Duke.java
# Conflicts: # data/duke.txt # src/main/java/duke/main/Parser.java
Tariq-droid
reviewed
Feb 2, 2023
|
|
||
| import java.io.IOException; | ||
|
|
||
| public class MarkCommand extends Command { |
|
|
||
| import java.io.IOException; | ||
|
|
||
| public class MarkCommand extends Command { |
There was a problem hiding this comment.
I don't think it makes sense to have these as classes. methods make more sense
| } | ||
|
|
||
| public void execute(Tasklist tasklist, Ui ui, Storage storage) throws IOException { | ||
| tasklist.markDone(this.taskNum - 1); |
src/main/java/duke/main/Parser.java
Outdated
| import duke.command.*; | ||
| import duke.task.Deadline; | ||
| import duke.task.Event; | ||
| import duke.task.Todo; |
src/main/java/duke/main/Parser.java
Outdated
| * @throws DukeException when input is invalid | ||
| */ | ||
| public static Command parseCommand(String fullCommand) throws DukeException { | ||
| String[] splits = fullCommand.split(" ", 2 ); |
There was a problem hiding this comment.
not a very indicative name for this array
src/main/java/duke/main/Parser.java
Outdated
| throw new DukeException("☹ OOPS!!! Please use format: event <description> /from <datetime> /to <datetime>"); | ||
| } | ||
| try { | ||
| String[] secondsplits = splits[1].split("/from", 2); |
src/main/java/duke/main/Storage.java
Outdated
| StringBuilder strings = new StringBuilder(); | ||
| FileWriter fw = new FileWriter(this.file); | ||
|
|
||
| for (Task curr : tasklist.getTasks()) { |
There was a problem hiding this comment.
this is a complicated expression. Can be simplified
src/main/java/duke/main/Storage.java
Outdated
| .append(curr.getDescription()) | ||
| .append("\n"); | ||
| } else if (curr instanceof Deadline) { | ||
| strings.append("D ") |
src/main/java/duke/main/Ui.java
Outdated
| printLine(); | ||
| } | ||
|
|
||
| public void printFoundTasks(ArrayList<Task> foundTasks) throws DukeException { |
| import duke.main.Ui; | ||
|
|
||
| public class ExitCommand extends Command { | ||
| public void execute(Tasklist taskList, Ui ui, Storage storage) { |
There was a problem hiding this comment.
nota very indicative name for the method
# Conflicts: # src/main/java/duke/command/AddCommand.java
Removed duplicated getTasksNum() method from Tasklist and did some cosmetic changes to several other classes.
Added the ability to recognize and deal with duplicate tasks from user.
Added *personality* to newly named Smudge program. Added new help command too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duke bot
Duke frees your mind of having to remember things you need to do. It's:
All you need to do is,
And it is FREE❗ ❗ 😃
Features:
If you Java programmer, you can use it to practice Java too. Here's the
mainmethod: