[Ang Min Cher, Branda] iP #273

panpannnnn · 2023-01-26T06:30:15Z

DukePro 😁

“Your mind is for having ideas, not holding them.” – David Allen (source)

DukePro is a very simple task tracker. It's

Easy to use
Text-based
Efficient

All you need to do is,

Download it from here.
Double-click it.
Learn the functions from the help menu
Sit back and let it manage tasks for you!

The new and improved DukePro allows you to,

If you are a Java programmer, you can use it to practice Java too. Here's the main method:

public class Duke {
    public static void main(String[] args) throws DukeException {
        UI ui = new UI();
        TaskList list = new TaskList(100);
        Storage storage = new Storage(list);
        Parser parser = new Parser();
        ui.start();
        storage.findData();
        storage.connect();
        start(ui, list, storage, parser);
    }
}

Add Gradle support

kyueran

LGTM, can consider changing some minor style changes suggested. Good job overall!

kyueran · 2023-01-31T03:15:36Z

src/main/java/duke/Deadline.java

+        if (super.isDone()) {
+            return "D | 1 | " + super.getName() + " | " + this.deadline.format(DateTimeFormatter.ofPattern("yyyy-MM-dd")) + "\n";
+        } else {
+            return "D | 0 | " + super.getName() + " | " + this.deadline.format(DateTimeFormatter.ofPattern("yyyy-MM-dd")) + "\n";


Can line break in the middle, before this.deadline.format

kyueran · 2023-01-31T03:20:17Z

src/main/java/duke/UI.java

+    public void mark(TaskList list, int index) {
+        list.getTask(index - 1).setDone();
+        System.out.println("ʕ•̀ω•́ʔ✧ :: Nice! I've marked this task as done:\n  " + list.getTask(index - 1).toString());
+    }
+
+    public void unmark(TaskList list, int index) {
+        list.getTask(index - 1).setUndone();
+        System.out.println("ʕ•̀ω•́ʔ✧ :: OK, I've marked this task as not done yet:\n  " + list.getTask(index - 1).toString());
+    }


Can break the line here to improve readability.

kyueran · 2023-01-31T03:20:52Z

src/main/java/duke/UI.java

+        System.out.println("ฅʕ'ᴥ'ʔฅ :: Got it. I've added this task:");
+        System.out.println("  " + list.getTask(list.getSize() - 1).toString());
+        System.out.println("ʕ•ᴥ•ʔっ :: Now you have " + list.getSize() + " task(s) in the list.");


Can concatenate the strings first then call System.out.println on the overall string.

verydaftpunk · 2023-02-04T14:35:12Z

src/main/java/duke/Task.java

+        this.done = " ";
+    }
+
+    public boolean isDone() {


good naming of boolean in line with coding standards

verydaftpunk · 2023-02-04T14:37:44Z

src/main/java/duke/UI.java

+        list.addTask(new Event(name, start, end));
+        System.out.println("ฅʕ'ᴥ'ʔฅ :: Got it. I've added this task:");
+        System.out.println("  " + list.getTask(list.getSize() - 1).toString());
+        System.out.println("ʕ•ᴥ•ʔっ :: Now you have " + list.getSize() + " task(s) in the list.");


good addition of emoticons to inject personality into duke. very good.

verydaftpunk · 2023-02-04T14:38:39Z

src/main/java/duke/Duke.java

+                    }
+                } else if (cmd.startsWith("delete")) {
+                    if (list.getSize() == 0) {
+                        throw new DukeException("ʕ ﾟ ● ﾟʔ :: ☹ OOPS!!! The list is empty!");


good throwing of exception if trying to delete an empty list

verydaftpunk · 2023-02-04T14:38:57Z

build.gradle

@@ -0,0 +1,41 @@
+plugins {


your stuff is very good!

Storage: change boolean naming to convention Duke: improve SLAP of the start() method Method was too long. Hence the implementation was split into different smaller methods.

Create find functionality Duke: create a new case for finding a task Parser: create a new method to find keyword of the task Tasklist: create new method to gather matching tasks UI: create a new method to display matching tasks

* branch-A-CodingStandard: Edit according to coding standards.

# Conflicts: # src/main/java/duke/Duke.java # src/main/java/duke/UI.java

Add checkstyle

…sed in through the methods.

Add GUI to duke Add a 'help' menu Add a 'retrieve data' feature for users using the GUI to load previous tasks

Add assert feature to tasklist methods to document assumptions that should hold.

Add JavaDocs for each method and code comments. Check for readability. Consolidate duplicate conditional fragments for Duke.java

Branch-A-Assertions

Branch-A-CodeQuality

Add the C-Help extension. Actually added in an earlier commit: see commit 5f1c137

Change Duke to panpan (my own nickname:P)

Update README.md with the new user guide

damithc and others added 13 commits July 31, 2022 17:20

Add Gradle support

556af3f

Level-1

4cfb024

Level-2

0a14b06

Level-3

4bd152a

Level-4

bff544e

A-TextUiTesting

106d173

Level-5

012520b

Level-6

bacc588

Level-7

39eb196

Level-8

c17b811

A-MoreOOP

13d4d0a

A-Packages

80b8897

Merge pull request #1 from panpannnnn/add-gradle-support

db1e93a

Add Gradle support

kyueran reviewed Jan 31, 2023

View reviewed changes

verydaftpunk reviewed Feb 4, 2023

View reviewed changes

src/main/java/duke/Task.java

this.done = " ";

}

public boolean isDone() {

Copy link

verydaftpunk Feb 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good naming of boolean in line with coding standards

verydaftpunk reviewed Feb 4, 2023

View reviewed changes

build.gradle

@@ -0,0 +1,41 @@

plugins {

Copy link

verydaftpunk Feb 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your stuff is very good!

panpannnnn added 12 commits February 12, 2023 18:42

A-Gradle

fadb26d

A-JUnit

d570284

A-Jar

b6e391c

Incorrectly reversed hunk

dd32d06

A-JavaDoc

a095553

Edit according to coding standards.

9723cdb

Storage: change boolean naming to convention Duke: improve SLAP of the start() method Method was too long. Hence the implementation was split into different smaller methods.

Level-9

be00e75

Create find functionality Duke: create a new case for finding a task Parser: create a new method to find keyword of the task Tasklist: create new method to gather matching tasks UI: create a new method to display matching tasks

Merge branch 'branch-A-CodingStandard'

f396da8

* branch-A-CodingStandard: Edit according to coding standards.

Merge branch 'branch-Level-9'

fd54ce9

# Conflicts: # src/main/java/duke/Duke.java # src/main/java/duke/UI.java

A-CheckStyle

76d804b

Add checkstyle

Revamp duke so that ui, list, storage and parser won't have to be pas…

79914dd

…sed in through the methods.

Level-10

5f1c137

Add GUI to duke Add a 'help' menu Add a 'retrieve data' feature for users using the GUI to load previous tasks

panpannnnn and others added 12 commits February 17, 2023 12:47

A-Assertions

d9c35b8

Add assert feature to tasklist methods to document assumptions that should hold.

A-Assertions

a690036

Add assert feature to tasklist methods to document assumptions that should hold.

A-CodeQuality

ecb2da3

Add JavaDocs for each method and code comments. Check for readability. Consolidate duplicate conditional fragments for Duke.java

Merge pull request #3 from panpannnnn/branch-A-Assertions

5fea342

Branch-A-Assertions

Merge pull request #4 from panpannnnn/branch-A-CodeQuality

babfebd

Branch-A-CodeQuality

BCD-Extension

cbc5bcd

Add the C-Help extension. Actually added in an earlier commit: see commit 5f1c137

Add credit for GUI design

259f155

A-Personality

7ded73e

Change Duke to panpan (my own nickname:P)

A-UserGuide

3452f3a

Update README.md with the new user guide

Rename archive base name to 'panpan' for release

bd4fbe1

Update mainClassName for new release

de5d5fa

Update Storage handling of file not found exception

bcfa290

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Ang Min Cher, Branda] iP #273

[Ang Min Cher, Branda] iP #273

panpannnnn commented Jan 26, 2023 •

edited

kyueran left a comment

kyueran Jan 31, 2023

kyueran Jan 31, 2023

kyueran Jan 31, 2023

verydaftpunk Feb 4, 2023

verydaftpunk Feb 4, 2023

verydaftpunk Feb 4, 2023

verydaftpunk Feb 4, 2023

[Ang Min Cher, Branda] iP #273

Are you sure you want to change the base?

[Ang Min Cher, Branda] iP #273

Conversation

panpannnnn commented Jan 26, 2023 • edited

DukePro 😁

kyueran left a comment

Choose a reason for hiding this comment

kyueran Jan 31, 2023

Choose a reason for hiding this comment

kyueran Jan 31, 2023

Choose a reason for hiding this comment

kyueran Jan 31, 2023

Choose a reason for hiding this comment

verydaftpunk Feb 4, 2023

Choose a reason for hiding this comment

verydaftpunk Feb 4, 2023

Choose a reason for hiding this comment

verydaftpunk Feb 4, 2023

Choose a reason for hiding this comment

verydaftpunk Feb 4, 2023

Choose a reason for hiding this comment

panpannnnn commented Jan 26, 2023 •

edited