[Nicholas Arlin Halim] iP #276

daytona65 · 2023-01-26T08:40:03Z

DukeMeister3000

"Tasks not complete, until DukeMeister3000 I used" - Mister Yoda

DukeMeister3000 tracks your tasks and gives you that edge to complete them on time. It is

extremely intuitive
fast
~~quite~~ ~~very~~ ABSOLUTELY simple to use

Simply

Download it here
Run it as a jar file
Start typing your tasks
And there you have it!

Let DukeMeister3000 manage your tasks for you! 💯

Some features:

Deadline setting
Display your current tasks
Stores your tasks when you stop the program and accesses them again on the next startup

If you are a Java programmer, you can review the code easily with its well designed code and JavaDocs. Here's the newEvent method:

    /**
     * Creates a new Event task and prints a message for the user
     * confirming the addition of the task to the Task List.
     *
     * @param input The user input.
     * @param taskSize The current Task List size.
     * @return The created task.
     */
    public Task newEvent(String input, int taskSize) throws DukeException {
        int fromIndex = input.indexOf(" /from ");
        int toIndex = input.indexOf(" /to ");
        Task task = new Event(input.substring(6, fromIndex), input.substring(fromIndex + 7, toIndex),
                input.substring(toIndex + 5));
        Ui.addMessage(task, taskSize);
        return task;
    }

Dangabit

Coding standard wise it mostly look fine!
Some possible improvements are commented.

Dangabit · 2023-01-30T10:38:10Z

src/main/java/Duke.java

 public class Duke {
+    private static Scanner sc;
+    private static List<Task> list;


Perhaps a better variable name than list here to indicate what the list holds?

Suggested change

private static List<Task> list;

private static List<Task> tasks;

Dangabit · 2023-01-30T10:39:47Z

src/main/java/Deadline.java

@@ -0,0 +1,13 @@
+public class Deadline extends Task {
+    protected String by;


I think a more descriptive variable name would be more helpful.

Suggested change

protected String by;

protected String dueDate;

Dangabit · 2023-01-30T10:41:43Z

src/main/java/Duke.java

+            } else if (isMark(input, list.size())) {
+                int taskindex = Integer.parseInt(input.substring(5)) - 1;
+                list.get(taskindex).markAsDone();
+                System.out.println("Solid! I'm marking this task as done:\n" + list.get(taskindex).toString());


Line may have been too long, perhaps separate into multiple lines to be more aligned with the coding standard. There are also more similar issues further below.

Dangabit · 2023-01-30T10:57:23Z

src/main/java/Deadline.java

@@ -0,0 +1,13 @@
+public class Deadline extends Task {


I believe organising your Deadline, Todo, Event and task into a single package will help with the structure of your files. Also helps as you implement more classes.

Dangabit · 2023-01-30T10:59:08Z

src/main/java/Duke.java

+        }
+    }
+
+    public static boolean isMark(String input, int listSize) {


All your methods are aptly named with the right names and format. Nice!

KSunil2001

LGTM, almost. Just a few nits to fix.
Overall, the code is well done 😄

KSunil2001 · 2023-02-01T09:19:34Z

src/main/java/Duke.java

+            if ("bye".equals(input)) {
+                break;
+            } else if ("list".equals(input)) {
+                System.out.println("Here are the tasks in your list:");
+                for (int i = 0; i < list.size(); i++) {
+                    int j = i + 1;
+                    System.out.println(j + "." + list.get(i).toString());
+                }
+            } else if (isMark(input, list.size())) {
+                int taskindex = Integer.parseInt(input.substring(5)) - 1;
+                list.get(taskindex).markAsDone();
+                System.out.println("Solid! I'm marking this task as done:\n" + list.get(taskindex).toString());
+            } else if (isUnMark(input, list.size())) {
+                int taskindex = Integer.parseInt(input.substring(7)) - 1;
+                list.get(taskindex).markAsNotDone();
+                System.out.println("Aight, marking this as not done:\n" + list.get(taskindex).toString());
+            } else if (isDelete(input, list.size())) {
+                int taskindex = Integer.parseInt(input.substring(7)) - 1;
+                String removed = list.get(taskindex).toString();
+                list.remove(taskindex);
+                System.out.println("Swee! One less task to go! Removing...\n" + removed);
+            } else { //Task Creation
+                Task task = null;
+                if (isToDo(input)) {
+                    task = new ToDo(input);
+                    list.add(task);
+                } else if (isDeadline(input)) {
+                    int index = input.indexOf(" /by ");
+                    task = new Deadline(input.substring(0, index), input.substring(index + 5));
+                    list.add(task);
+                } else if (isEvent(input)) {
+                    int fromdex = input.indexOf(" /from ");
+                    int todex = input.indexOf(" /to ");
+                    task = new Event(input.substring(0, fromdex), input.substring(fromdex + 7, todex), input.substring(todex + 5));
+                    list.add(task);
+                } else {
+                    throw new DukeException("What are you saying?\n" + "Please input a task with either todo, deadline or event prefixed!");
+                }
+                System.out.println("Roger. This task has been added:\n" + "  " + task.toString());
+                System.out.println("Now you have " + list.size() + " tasks in your list.");
+            }


Maybe you could use switch case statements instead of if-else statements for better readability? 🤔

KSunil2001 · 2023-02-01T09:24:50Z

src/main/java/Duke.java

+
+    public static boolean isDeadline(String input) throws DukeException {
+        if (input.length() >= 8 && input.startsWith("deadline")) {
+            if (input.equals("deadline") || input.substring(8).isBlank() || input.equals("deadline /by") || input.equals("deadline /by ")) {


I would recommend breaking this statement into 2 lines to make the code look more neat.

KSunil2001 · 2023-02-01T09:26:11Z

src/main/java/Duke.java

+                int fromdex = input.indexOf(" /from ");
+                int todex = input.indexOf(" /to ");
+                if (fromdex + 7 > todex) {
+                    throw new DukeException("What are you saying?");
+                }


There seems to be additional indentation to these 5 lines of code.

KSunil2001 · 2023-02-01T09:29:47Z

src/main/java/Task.java

+
+    @Override
+    public String toString() {
+        return "[" + getStatusIcon() + "] " + getDescription();


Is getDescription() necessary here? 🤔

Suggested change

return "[" + getStatusIcon() + "] " + getDescription();

return "[" + getStatusIcon() + "] " + description;

KSunil2001 · 2023-02-01T09:36:38Z

src/main/java/Duke.java

+    public static boolean isUnMark(String input, int listSize) {
+        if (input.length() >=  8 && input.startsWith("unmark ") && isNumeric(input.substring(7))) {
+            int taskindex = Integer.parseInt(input.substring(7)) - 1;
+            return !(taskindex < 0 || taskindex > listSize - 1);
+        }
+        return false;
+    }
+
+    public static boolean isDelete(String input, int listSize) {
+        if (input.length() >=  8 && input.startsWith("delete ") && isNumeric(input.substring(7))) {
+            int taskindex = Integer.parseInt(input.substring(7)) - 1;
+            return !(taskindex < 0 || taskindex > listSize - 1);
+        }
+        return false;
+    }
+
+    public static boolean isToDo(String input) throws DukeException {
+        if (input.length() >= 4 && input.startsWith("todo")) {
+            if (input.equals("todo") || input.substring(4).isBlank()) {
+                throw new DukeException("TODO needs a description!");
+            } else return input.startsWith("todo ");
+        }
+        return false;
+    }


I like how you have defined your functions clearly and also applied the KISS rule. Well done 😄

Command classes are all user commands parsed from user inputs, and are executable. Extracting a Command class allows for better OOP and modularity of the code. Execution of commands is extracted from Parser class into Command classes. Each command is a subclass of the abstract Command class and each command implements execute() differently. This allows for modularity and better OOP so more commands can easily be added in the future. The code is also easier to understand and functionality and execution of the commands are abstracted away into the corresponding Command classes instead of just the Parser class.

Add assertions in Command, Task and Duke

Improve code quality

… functions

…ser and Gigachad icons

Update UG

Gigachad

damithc and others added 8 commits July 31, 2022 17:20

Add Gradle support

556af3f

Level 1

af021e6

Level 2

7f32ce5

Level 3

250988b

Level 4

9ce2c8d

Level 5

a02df7d

Fixed Level 5 and added text ui testing increment

42458e6

Level-6

ea9f565

Dangabit reviewed Jan 30, 2023

View reviewed changes

Add save function

01b38df

KSunil2001 reviewed Feb 1, 2023

View reviewed changes

nichalim and others added 19 commits February 1, 2023 21:57

Add Date and Time function

b165977

Extract more classes for OOP

4c58354

Add duke, task and exception packages

244fb0a

Merge branch 'add-gradle-support'

2f7b2c1

Add JUnit tests for the 3 task classes

1f74d52

Create new release

203416b

Add JavaDoc comments and fixed coding standards

fa26392

Add coding standards in JavaDoc branch

1bbc793

Add find command

18f2ed8

Merge tag 'A-CodingStandard'

cd2d909

Merge branches JavaDoc, CodingStandard and Level-9

605784f

Fix description bugs in all three tasks

10205b1

Fix Gradle

340ff81

GUI up to Dialog Box

874b774

Clip image to circle and fix paddings

b8279c9

Link GUI to Duke

29335f9

Add command package

4cde100

Fix JUnit tests

72afc5e

daytona65 and others added 30 commits February 17, 2023 13:31

Change comments in GUI

1559483

Add @OverRide to execute() of subclasses of Command

0d12d2e

Merge pull request #2 from daytona65/branch-A-Assertions

21bee87

Add assertions in Command, Task and Duke

Merge branch 'master' into branch-A-CodeQuality

fb847c5

Merge pull request #3 from daytona65/branch-A-CodeQuality

7677f2a

Improve code quality

Merge branch 'branch-Level-10'

1690716

Merge tag 'branch-A-CodeQuality'

db4875a

Merge branch 'master' of https://github.com/daytona65/ip

8e488de

Change product name to DukeMeister3000

fae02a6

Implement Priority enum, PriorityCommand and all of its corresponding…

f1d2f07

… functions

Add Priority Enums

fd908cd

Make changes to GUI to make it look better, such as circle cropping u…

19f17ff

…ser and Gigachad icons

Add more personalised phrases for Duke

fc99a55

Add more handling for edge cases

59c17cf

Merge branch 'branch-BCD-Extension'

3bd3c5a

Merge branch 'branch-A-BetterGui'

fc89f34

Merge branch 'branch-A-Personality'

9bc3f73

Merge branch 'branch-A-MoreErrorHandling'

84a4dac

Update build

9645ce8

Add Ui.png to /docs

c572df9

Add user guide

7195049

Update User Guide

fc23935

Fix pget indexing to 1 indexed commands

66a2590

Update UG

e45d06e

Merge pull request #4 from daytona65/UG-update

274e4fe

Update UG

Gigachad

0955ceb

Merge pull request #5 from daytona65/UG-update

6b62815

Gigachad

Add spacings to UG

67ba624

Merge branch 'master' of https://github.com/daytona65/ip

f59225f

Add space UG

dd01ce5

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Nicholas Arlin Halim] iP #276

[Nicholas Arlin Halim] iP #276

daytona65 commented Jan 26, 2023 •

edited

Dangabit left a comment

Dangabit Jan 30, 2023

Dangabit Jan 30, 2023

Dangabit Jan 30, 2023

Dangabit Jan 30, 2023

Dangabit Jan 30, 2023

KSunil2001 left a comment

KSunil2001 Feb 1, 2023

KSunil2001 Feb 1, 2023

KSunil2001 Feb 1, 2023

KSunil2001 Feb 1, 2023

KSunil2001 Feb 1, 2023

	private static List<Task> list;
	private static List<Task> tasks;

		@@ -0,0 +1,13 @@
		public class Deadline extends Task {
		protected String by;

	return "[" + getStatusIcon() + "] " + getDescription();
	return "[" + getStatusIcon() + "] " + description;

[Nicholas Arlin Halim] iP #276

Are you sure you want to change the base?

[Nicholas Arlin Halim] iP #276

Conversation

daytona65 commented Jan 26, 2023 • edited

DukeMeister3000

Dangabit left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

KSunil2001 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

daytona65 commented Jan 26, 2023 •

edited