[HAO ZEYU] iP #281

PROGRAMMERHAO · 2023-01-26T11:13:32Z

Duke Pro

“Your mind is for having ideas, not holding them.” – David Allen

DukePro frees your mind of having to remember things you need to do. It's,

text-based
easy to learn
~~FAST~~ SUPER FAST to use

All you need to do is,

download it from here.
double-click it.
add your tasks.
let it manage your task for you 😉

And it is FREE!

Features:

Managing tasks
Managing deadlines (coming soon)
Reminders (coming soon)

If you Java programmer, you can use it to practice Java too. Here's the main method:

public class Main {
    public static void main(String[] args) {
        Application.launch(MainApp.class, args);
    }
}

# Conflicts: # src/main/java/duke/parser/Parser.java # src/main/java/duke/ui/Ui.java

# Conflicts: # src/main/java/duke/command/Command.java # src/main/java/duke/command/MarkDoneCommand.java # src/main/java/duke/command/MarkUndoneCommand.java # src/main/java/duke/command/ShowListCommand.java # src/main/java/duke/storage/Storage.java # src/main/java/duke/tasks/Deadline.java # src/main/java/duke/tasks/Event.java # src/main/java/duke/tasks/Task.java

ruiyigan

Overall, great job! 👍 Some minor issues I found

Missing comments for classes (I may have missed a class or two) but I think it will be helpful to include briefly what the class function is.
Perhaps not committing your txt file to github.

Other than that, the code looks good!
Please let me know if you have any queries regarding my comments.

ruiyigan · 2023-01-30T14:47:46Z

data/duke.txt

@@ -0,0 +1,4 @@
+E | 1 | say hi | from 2 to 5


Just a suggestion. You may want to consider adding duke.txt into your .gitignore file to avoid the constant file change when committing changes.

ruiyigan · 2023-01-30T14:48:26Z

src/main/java/duke/Duke.java

+
+
+
+


Perhaps you can consider adding a comment for the Duke class briefly explaining what the Duke class do.

ruiyigan · 2023-01-30T14:51:41Z

src/main/java/duke/Commands.java

@@ -0,0 +1,5 @@
+package duke;
+
+public enum Commands {


I like how you have an enum to manage the different commands.

ruiyigan · 2023-01-30T14:52:05Z

src/main/java/duke/parser/Parser.java

+
+
+
+


Similar comments as above regarding the comment for the class.

ruiyigan · 2023-01-30T14:54:12Z

src/main/java/duke/command/Command.java

+import duke.ui.Ui;
+
+
+


Similar comments as above regarding the comment on class (for all classes under command folder)

ruiyigan · 2023-01-30T14:54:47Z

src/main/java/duke/tasks/Task.java

@@ -0,0 +1,99 @@
+package duke.tasks;
+
+public class Task {


Similar comments as above regarding comments on class.

ruiyigan · 2023-01-30T14:57:32Z

src/test/java/duke/tasks/EventTest.java

+        assertEquals("[E][ ] finish homework (from: 2pm to: 4pm)", new Event("finish homework", "from 2pm to 4pm").toString());
+    }
+
+}


I think you can include a new line here. I don't think its compulsory but github warns you about it. I found a reason online in this link here if you're interested.

Flash161203

Overall, I found the 'Naming' aspect of Code Quality to be well-satisfied. Just a few minor things to 'fix'. Great job! 😄

Flash161203 · 2023-02-03T15:33:34Z

src/main/java/duke/Duke.java

+        ui = new Ui();
+        storage = new Storage(filePath);
+        try {
+            tasks = new TaskList(storage.load());
+        } catch (DirectoryNotFoundException e) {
+            ui.showError(e.getMessage());
+            tasks = new TaskList();
+        } catch (FileNotFoundException e) {
+            ui.showError(e.getMessage());
+            tasks = new TaskList();


The naming used here is very straightforward and easy to understand 👍

Flash161203 · 2023-02-03T15:37:25Z

src/main/java/duke/TaskList.java

+        try {
+            Scanner s = new Scanner(file); // create a Scanner using the File as the source
+            while (s.hasNext()) {
+                String cur = s.nextLine();


Perhaps could have avoided the short form and have used a slightly more descriptive variable name (e.g. currentLine)?

I also noticed similar instances in several other places as well...

Flash161203 · 2023-02-03T15:39:06Z

src/main/java/duke/TaskList.java

+     * @return The task deleted
+     */
+    public Task delete(int index) {
+        Task removed = taskList.remove(index);


I feel that it might be better to use the name removedTask instead :)
I would sat the same about instances in several other places as well, (e.g. markedTask, unmarkedTask, etc.)

Flash161203 · 2023-02-03T15:43:57Z

src/main/java/duke/command/FindCommand.java

+     * @param storage The storage object
+     */
+    public void execute(TaskList list, Ui ui, Storage storage) {
+        ArrayList<Integer> found = new ArrayList<>();


Maybe a more descriptive name like tasksFound?

A-Assertions

Currently some imports and functions are redundant and some places need more comments for other developers to understand Let's remove the redundant code and add more comments to make the code clearer and more succint Other developers will not msiunderstand the code and they will be able to know why some parsing is done in that way

Code Quality: refactor the code to improve the code quality

If a user makes a mistake he or she cannot undo it Allowing user to undo give them the chance to recover from their mistake Let's enable undo options for delete task, mark a task as done, mark a task as undone, and add a task Undoing an undo is not allowed because this user will be unlikely to do so, and undoing show task and find task commands are trivial so they cannot be undone as well.

Updated the user guide.

Update user guide

Uploaded Product Screenshot

Uploaded Ui.png

damithc and others added 27 commits July 31, 2022 17:20

Add Gradle support

556af3f

Level 1

bccd978

Level 2

bbb36e6

Level3

88de9ca

Level4

68f6e9b

A-TextUITesting

ab9f086

Level5

0d7628a

Level6

1f9391e

A-ENUM

e024f4d

Level-6 Refinements

83f87d2

Level7

3215f70

Level7

ee957e1

Level8

4802823

Merge branch 'branch-Level-8'

593befc

Level8

660bae6

Merge branch 'branch-Level-8'

2fb4132

A-MoreOOP

397a60f

A-Packages

93f3827

Merge remote-tracking branch 'origin/add-gradle-support'

bb07426

A-Gradle

e61e944

A-JUnit

fd71954

A-JavaDoc

0b523dd

A-CodingStandard

679c38a

Level-9

07ad999

Merge branch 'branch-A-CodingStandard'

51d2ebd

# Conflicts: # src/main/java/duke/parser/Parser.java # src/main/java/duke/ui/Ui.java

Refinements to Style

ea76b92

ruiyigan reviewed Jan 30, 2023

View reviewed changes

PROGRAMMERHAO added 2 commits January 31, 2023 18:30

Level-10

6a24cf3

ignore unnecessary files

6e99e0f

Merge branch 'branch-level-10'

dea2fb1

Flash161203 reviewed Feb 3, 2023

View reviewed changes

PROGRAMMERHAO and others added 22 commits February 11, 2023 09:54

Minor changes

3444dfb

A-Assertions

6a03aa7

Merge pull request #2 from PROGRAMMERHAO/A-Assertions

744c401

A-Assertions

Merge pull request #3 from PROGRAMMERHAO/heads/A-CodeQuality

eff88be

Code Quality: refactor the code to improve the code quality

Corrected some errors in assert

e9a2410

Corrected some assertion errors and the file creation procedure.

c6974e4

Refactored some code to SLAP

bdf15b9

Update User guide

afc842f

Updated the user guide.

Update User Guide

39819c3

Update user guide

Uploaded Product Screenshot

f806062

Uploaded Product Screenshot

Delete Ui.png

433c0a0

Uploaded Ui.png

451591c

Uploaded Ui.png

Refactored code to align with code quality

1c91279

Merge branch 'master' of https://github.com/PROGRAMMERHAO/ip

c13447a

Improved Coding Style

19a9f00

Delete Ui.png

0645545

Added Ui.png

870b819

Added more error handling functionalities to DUuke

2e3631e

Merge branch 'master' of https://github.com/PROGRAMMERHAO/ip

7b254bd

Update README.md

cd02f4b

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HAO ZEYU] iP #281

[HAO ZEYU] iP #281

PROGRAMMERHAO commented Jan 26, 2023 •

edited

ruiyigan left a comment •

edited

ruiyigan Jan 30, 2023

ruiyigan Jan 30, 2023

ruiyigan Jan 30, 2023

ruiyigan Jan 30, 2023

ruiyigan Jan 30, 2023

ruiyigan Jan 30, 2023

ruiyigan Jan 30, 2023

Flash161203 left a comment

Flash161203 Feb 3, 2023

Flash161203 Feb 3, 2023

Flash161203 Feb 3, 2023

Flash161203 Feb 3, 2023

		import duke.ui.Ui;

[HAO ZEYU] iP #281

Are you sure you want to change the base?

[HAO ZEYU] iP #281

Conversation

PROGRAMMERHAO commented Jan 26, 2023 • edited

Duke Pro

ruiyigan left a comment • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Flash161203 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PROGRAMMERHAO commented Jan 26, 2023 •

edited

ruiyigan left a comment •

edited