[zuohui48] ip #284
Open
[zuohui48] ip #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaowi
reviewed
Feb 3, 2023
src/main/java/Parser.java
Outdated
Comment on lines
10
to
39
| public boolean checkTodo(String input) { | ||
|
|
||
| return input.split(" ")[0].equals("todo"); | ||
| } | ||
| public boolean checkEvent(String input) { | ||
| return input.split(" ")[0].equals("Event"); | ||
| } | ||
| public boolean checkDeadline(String input) { | ||
| return input.split(" ")[0].equals("deadline"); | ||
| } | ||
|
|
||
| public boolean checkTask(String input) { | ||
| String cmd = input.split(" ")[0]; | ||
| return cmd.equals("deadline") || cmd.equals("todo") || cmd.equals("event"); | ||
| } | ||
| public boolean checkMark(String input) { | ||
| return input.split(" ")[0].equals("mark"); | ||
| } | ||
| public boolean checkUnmark(String input) { | ||
| return input.split(" ")[0].equals("unmark"); | ||
| } | ||
| public boolean checkList(String input) { | ||
| return input.split(" ")[0].equals("list"); | ||
| } | ||
| public boolean checkBye(String input) { | ||
| return input.split(" ")[0].equals("bye"); | ||
| } | ||
| public boolean checkDelete(String input) { | ||
| return input.split(" ")[0].equals("delete"); | ||
| } |
There was a problem hiding this comment.
Boolean variables/methods should be named to sound like booleans.
src/main/java/Storage.java
Outdated
| import java.io.File; | ||
| import java.io.IOException; | ||
| import java.io.FileWriter; | ||
| import java.io.*; |
There was a problem hiding this comment.
Imported classes should always be listed explicitly.
src/main/java/Parser.java
Outdated
| import java.util.Arrays; | ||
| import java.util.stream.Stream; | ||
| public class Parser { | ||
| private static String[] VALID_COMMANDS = {"mark", "unmark", "list", "delete", "bye", "todo", "event", "deadline"}; |
There was a problem hiding this comment.
final keyword can be specified for constants
src/main/java/TaskList.java
Outdated
| @@ -0,0 +1,136 @@ | |||
| import java.util.ArrayList; | |||
| public class TaskList { | |||
| private ArrayList<Task> list; | |||
There was a problem hiding this comment.
Possible to be more clear of what list is this ? :)
There are important assumptions that should hold at various points in the code. The assert feature is use to ensure that none of these assumptions are being violeted.
Handle user input with Parser
Use assert feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MrDuke
MrDuke helps you to micromanage all your tasks. It's
FASTSUPER FAST to useAll you need to do is,
And it is FREE!
You can:
If you are a Java programmer, you can use it to practice Java too. Here's the
mainmethod: