[gekhro] iP #319
[gekhro] iP #319
Conversation
src/main/java/Duke.java
Outdated
| continue; | ||
| } | ||
|
|
||
| else if (input.equals("mark")){ |
There was a problem hiding this comment.
Hey! I know you haven't gotten to the code-standard refinement stage yet, but I thought I'd just leave some comments on your code style (its a fast fix, don't worry).
There was a problem hiding this comment.
for your conditionals and everything that requires a () bracket, if there is curly braces after it, it would be best to leave a white space before the curly brace. eg.
else if (condition) {
code...
}
src/main/java/Task.java
Outdated
| this.isDone = true; | ||
| } | ||
|
|
||
| public void markAsNotDone(){ |
There was a problem hiding this comment.
I realize you have done this in several other code files, so I guess you could just follow that.
src/main/java/Deadline.java
Outdated
| import javax.swing.text.DateFormatter; | ||
|
|
||
| public class Deadline extends Task{ | ||
| private LocalDate by; |
There was a problem hiding this comment.
Although this code is just a WIP, I would just like to leave a comment: perhaps changing out the private LocalDate "by" with dateBy, or a more descriptive name would be better! I realized that you use isDone and is... for your boolean variables, so that's good, and your other variables should also reflect that level of precise descriptiveness (in camelcase, of course.)
There was a problem hiding this comment.
Thanks so much for reading! Hope the (somewhat wordy) comments has been somewhat useful. 😄
src/main/java/duke/Ui.java
Outdated
| public Ui () { | ||
| } | ||
|
|
||
| public void showWelcome() { |
| private LocalDate due_by; | ||
| private String output; | ||
|
|
||
| public Deadline(String description, String due_by) throws DukeException{ |
There was a problem hiding this comment.
You might wanna leave a space after the method name
src/main/java/duke/Parser.java
Outdated
| switch(commandinput) { | ||
|
|
||
| case "TODO": | ||
| return new AddTodo(input); |
There was a problem hiding this comment.
Good usage of simple expressions rather than complicated one
edited the variable name to follow the java coding standard
# Conflicts: # gradle/wrapper/gradle-wrapper.jar # gradle/wrapper/gradle-wrapper.properties # gradlew # gradlew.bat # src/main/java/duke/commands/Delete.java # src/main/java/duke/commands/Mark.java # src/main/java/duke/commands/Unmark.java # src/main/java/duke/tasks/Deadline.java
Removed files containing different gradle.build causing error -utilities/build.gradle -list/build.gradle -app/build.gradle
changed build.gradle to add javafx dependencies
implemented checkstyle into gradle build to check for violations
added code to assert that the index will be within range for delete, find and list commands
fixed exceptionhandling logic in adding deadline, event and todo tasks
Add: A-Assertions
This reverts commit 97fcc3a.
Heads/a code quality
Dukepro
DukePro frees your mind of having to remember things you need to do. It's,
FASTSUPER FAST to useAll you need to do is,
And it is FREE!
Features:
If you're Java programmer, you can use it to practice Java too. Here's the
mainmethod: