[jjiayyingtt] iP #325
Open
[jjiayyingtt] iP #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c0j0s
reviewed
Jan 30, 2023
src/main/java/Duke.java
Outdated
Comment on lines
99
to
103
| /*} else if (dataArr[0].equals("deadline ")) { | ||
| operationHandler("deadline" + dataArr[2] + "/by" + dataArr[3]); | ||
| } else if (dataArr[0].equals("event ")) { | ||
| operationHandler("event" + dataArr[2] + "/from" + dataArr[3] + "/to" + dataArr[4]); | ||
| }*/ |
There was a problem hiding this comment.
Maybe you might want to remove commented codes before committing to make the PR neater.
src/main/java/Duke.java
Outdated
| } | ||
|
|
||
| private static String[] stringProcessor(boolean isDeadline, String s){ // isDeadline = false meaning isEvent | ||
| if (isDeadline){ |
There was a problem hiding this comment.
I have noticed several areas in your code without a space after if/for/method declarations. You might want to be careful as it will be painful when you need to resolve check style issues later on.
src/main/java/Deadline.java
Outdated
Comment on lines
11
to
13
| System.out.print("[D]"); | ||
| super.printTask(); | ||
| System.out.println("(by: " + date + ")"); |
There was a problem hiding this comment.
Nice, OOP from the start. But you might want to extract IO dependencies from your model classes, it will be easier when you decide to change your ui layer in the future.
src/main/java/Duke.java
Outdated
Comment on lines
9
to
14
| class DukeException extends Exception { | ||
|
|
||
| public DukeException(String errorMessage){ | ||
| super(errorMessage); | ||
| } | ||
| } |
pkpaing
reviewed
Feb 1, 2023
src/main/java/Duke.java
Outdated
| err.printStackTrace(); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
This code is well indented and very readable!
src/main/java/Duke.java
Outdated
Comment on lines
20
to
35
| private static void startUp() { | ||
| String name = "todo bot"; | ||
| System.out.println("Hello from " + name); | ||
| System.out.println("------------------------------------"); | ||
| System.out.println("I can help you take care of your daily todos :)"); | ||
| System.out.println("There are 3 types of tasks I can handle."); | ||
| System.out.println("------------------------------------"); | ||
| System.out.println("1. normal todo, format: "); | ||
| System.out.println(" todo task"); | ||
| System.out.println("2. deadline, format: "); | ||
| System.out.println(" deadline task /by yyyy-mm-dd"); | ||
| System.out.println("3. event, format: "); | ||
| System.out.println(" event task /from yyyy-mm-dd /to yyyy-mm-dd"); | ||
| System.out.println("------------------------------------"); | ||
|
|
||
| } |
There was a problem hiding this comment.
Very well formatted print statements, easy to read!
Assertions are added to operationHandler, when tasks are added to the list.
Previous commit version's did not get tasks that were saved and it did not save tasks that were obtained from chatbot. Link the data file to the chatbot
Provide a way to easily snooze/postpone/reschedule tasks.
moved function within operationHandler out to addTask and Snooze
improved code quality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duke Project
FASTSUPER FAST to useAll you need to do is,
3.add your tasks.
And it is FREE!
Features: