Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EksdeeeX] iP #348

Open
wants to merge 45 commits into
base: master
Choose a base branch
from
Open

[EksdeeeX] iP #348

wants to merge 45 commits into from

Conversation

EksdeeeX
Copy link

@EksdeeeX EksdeeeX commented Jan 29, 2023

Duke Buddy

"Kiss the tree and come back. Go" -some encik

Duke Buddy helps you to remember and track tasks to complete so as to prevent you from signing extras.

Award-winning capabilities include:

  • Tracks ToDos, Events, and Deadlines.
  • Easy to learn and use.
  • Is as dependable as a well-oiled SAR21.
  • Helps you to do guard duty

Interested to try it out? Follow the steps below.

  1. Download it here.
  2. Start incorporating it into your life and become 100x happier 馃榾

Best part is its FREE!! 馃き

Versions:

  • Duke Buddy (Released V0.0.1)
  • Duke KorKor (Coming Soon!)
  • Duke RideOrDie (Coming Soon!)

Here's a sneak peak of it's main method:

public static void main(String[] args) throws IOException {
        Ui ui = new Ui();
        Parser parser = new Parser();
        ui.initialise();
        parser.initialise();
        .
        .
        .
}

@EksdeeeX EksdeeeX changed the title ip [EksdeeeX] iP Jan 29, 2023
# Conflicts:
#	src/main/java/Deadline.java
#	src/main/java/Duke.java
#	src/main/java/Event.java
Copy link

@Mehvin Mehvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall code looks good 馃憤, only a few minor mistakes relating to coding standards.

Additionally, apart from your code, remember that for each git commit to include a commit message subject (a requirement from the git conventions).

Keep up the good work and all the best for the future weeks!!!

Comment on lines 69 to 71
boolean isDescripton = true;
boolean first = false;
boolean second = false;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe rename the variables, first & second, to something similar to isDescripton to follow the coding standard?

Suggested change
boolean isDescripton = true;
boolean first = false;
boolean second = false;
boolean isDescripton = true;
boolean isFirst = false;
boolean isSecond = false;


public ArrayList<Task> load() throws FileNotFoundException {
Scanner sc = new Scanner(this.saved);
ArrayList<Task> list = new ArrayList<>();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps a more specific name can be use for the array list (e.g. tasksList)

public class Data {
private DateTimeFormatter savedFormat = DateTimeFormatter.ofPattern("dd/MMM/yyyy HHmm");
private DateTimeFormatter loadFormat = DateTimeFormatter.ofPattern("yyyy/MM/dd HHmm");
private boolean exist;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could use a better naming convention for exist

Comment on lines 74 to 90
if(task[i].equalsIgnoreCase("/from")) {
first = true;
isDescripton = false;
continue;
}
if(task[i].equalsIgnoreCase("/to")) {
second = true;
first = false;
continue;
}
if(first) {
start.append(task[i] + " ");
}
if(second) {
end.append(task[i] + " ");
}
if(isDescripton) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spacing can be added to after each if to follow the coding standards

Suggested change
if(task[i].equalsIgnoreCase("/from")) {
first = true;
isDescripton = false;
continue;
}
if(task[i].equalsIgnoreCase("/to")) {
second = true;
first = false;
continue;
}
if(first) {
start.append(task[i] + " ");
}
if(second) {
end.append(task[i] + " ");
}
if(isDescripton) {
if (task[i].equalsIgnoreCase("/from")) {
first = true;
isDescripton = false;
continue;
}
if (task[i].equalsIgnoreCase("/to")) {
second = true;
first = false;
continue;
}
if (first) {
start.append(task[i] + " ");
}
if (second) {
end.append(task[i] + " ");
}
if (isDescripton) {

EksdeeeX and others added 17 commits February 10, 2023 23:41
These assumptions have to be met in order for code to function without error.

In some cases, the code might be errneous and these assertions will help identify them.

Assertions act as a checker for correct code.

Assertions are important.
Code quality could be improved in some areas.

Code was edited in accordance to code quality standards.

Code quality standards should be followed to ensure uniformity.

Good code quality enables better readability
Improve tagging code.
Add Ui.png
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants