[minosx31] iP #353

minosx31 · 2023-01-29T18:51:40Z

DukePro

“Your mind is for having ideas, not holding them.” – David Allen (Source)

DukePro frees your mind of having to remember things you need to do. It's,

text-based
easy to learn
~~FAST~~ SUPER FAST to use

All you need to do is,

download it from here.
double-click it.
add your tasks.
let it manage your tasks for you 😉

And it is FREE!

Features:

Managing tasks
Managing deadlines (coming soon)
Reminders (coming soon)

If you are a Java programmer, you can use it to practice Java too. Here's the main method:

public class Main {
  public static void main(String[] args) {
    Application.launch(MainApp.class, args);
  }
}

LiuMC-SG

Overall okay so far, just a few key points to take note of to change. Some of the changes such as simplifying the long if-else/switch case would come naturally after the next few levels.
Keep up the good work! :D

LiuMC-SG · 2023-02-01T13:58:34Z

src/main/java/Duke.java

+    private static String numOfTasks(ArrayList<Task> tasks) {
+        return tasks.size() == 1 ? " task " : " tasks ";
+    }


The method name could perhaps be changed as it is misleading. numOfTasks would normally imply returning the number of tasks the list contain. However, you are just getting the string of whether it task should be plural or not. Method names should also start with a verb instead.

LiuMC-SG · 2023-02-01T14:00:20Z

src/main/java/Duke.java

        String logo = " ____        _        \n"
                + "|  _ \\ _   _| | _____ \n"
                + "| | | | | | | |/ / _ \\\n"
                + "| |_| | |_| |   <  __/\n"
                + "|____/ \\__,_|_|\\_\\___|\n";
-        System.out.println("Hello from\n" + logo);
+
+        System.out.println("Hello I'm Duke!\n" + "How can I help you?");


Maybe you can take out the string in your println to avoid "magic" strings. Such as welcomeMsg = "...". There are several instances later on as well that you can take not of.

LiuMC-SG · 2023-02-01T14:05:51Z

src/main/java/Deadline.java

+    public String toString() {
+        return "[D]" + "[" + super.getStatusIcon() + "] " + super.getDescription() + " (by: " + this.doBy + ")";
+    }


I feel like there is no need to use super.getStatusIcon and super.getDescription since your Deadline already extends from Tasks. Hence, these methods already exist within the Deadline class. Furthermore, the use of this should be removed if there is no multiple instances of it. This is a suggestion.

Suggested change

public String toString() {

return "[D]" + "[" + super.getStatusIcon() + "] " + super.getDescription() + " (by: " + this.doBy + ")";

}

public String toString() {

return String.format("[D] [%s] %s (by: %s)", getStatusIcon(), getDescription(), doBy);

}

The other classes that extend from Task have similar problem and can be dealt with respectively as well.

LiuMC-SG · 2023-02-01T14:08:28Z

src/main/java/Duke.java

+                    if (remainingInput == null) {
+                        throw new IncorrectInputException("Enter a description!");
+                    }


I like that you did this so that it is easier to see the "happy path" that the code would traverse through.

LiuMC-SG · 2023-02-01T14:10:37Z

src/main/java/Duke.java

+                    if (tasks.size() != 0) {
+                        for (int i = 0; i < tasks.size(); i++) {
+                            System.out.println((i + 1) + "." + tasks.get(i).toString());
+                        }
+                    }


Perhaps the if condition can be taken out so that it is easier to see the "happy path" and reduce indentation of code.

Suggested change

if (tasks.size() != 0) {

for (int i = 0; i < tasks.size(); i++) {

System.out.println((i + 1) + "." + tasks.get(i).toString());

}

}

if (tasks.size() == 0) {

continue;

}

for (int i = 0; i < tasks.size(); i++) {

System.out.println((i + 1) + "." + tasks.get(i).toString());

}

venuslimm

LGTM! I have commented on a few suggestions but generally, I think your code is easy to read! I like how you extracted the Task class very neatly into the 3 other classes.

venuslimm · 2023-02-02T18:50:08Z

src/main/java/Duke.java

+        }
+    }
+
+    private static String numOfTasks(ArrayList<Task> tasks) {


I agree with @LiuMC-SG, perhaps this can be a suggestion?

Suggested change

private static String numOfTasks(ArrayList<Task> tasks) {

private static String getTaskString(ArrayList<Task> tasks) {

venuslimm · 2023-02-02T19:01:12Z

src/main/java/Duke.java

    public static void main(String[] args) {
+        ArrayList<Task> tasks = new ArrayList<>();
+        Scanner sc = new Scanner(System.in );


Should there be no extra space after System.in?

Suggested change

Scanner sc = new Scanner(System.in );

Scanner sc = new Scanner(System.in);

venuslimm · 2023-02-02T19:09:20Z

src/main/java/Event.java

+
+    @Override
+    public String toString() {
+        return "[E]" + "[" + super.getStatusIcon() + "] " + super.getDescription() + " (from: " + this.period[0] + " to: " + this.period[1] + ")";


Would it be better to use line break as the character count exceeds 120?

venuslimm · 2023-02-02T19:12:59Z

src/main/java/Duke.java

+                    if (remainingInput == null) {
+                        throw new IncorrectInputException("Enter a description with a deadline!");
+                    }
+                    String[] deadlineDetails = remainingInput.split(" /by ", 2);
+                    String deadlineDescription = deadlineDetails[0];
+                    String deadline = deadlineDetails.length > 0 ? deadlineDetails[1] : null;
+
+                    if (deadline == null) {
+                        throw new IncorrectInputException("Enter a valid deadline!");
+                    }
+                    Task newTask = new Deadline(deadlineDescription, deadline);
+                    tasks.add(newTask);
+                    System.out.println("Got it. I've added this task:");
+                    System.out.println(newTask);
+                    System.out.println("Now you have " + tasks.size() + Duke.numOfTasks(tasks) + "in the list.");


I like how the different logical units are separated by a line! The same goes for the rest of this if statement.

The current Command classes that are responsible for handling commands that involve creating a new task, assumes that a Task object will be created upon execution. These classes are: * DeadlineCommand * EventCommand * TodoCommand These assumptions will have to hold in order for these classes to work as intended. However, if they do not hold, it will result in errors in other areas of the code. Having assertions will ensure that the original assumption holds in the respective Command classes.

Ensure that the code follows the provided guidelines so that it remains readable and is of high quality.

Add assertions

Improve code quality

MarkCommand does not handle the scenario where a task number does not exist in the TaskList. Todo, Event and Deadline also does not handle scenarios where task details are empty or invalid. When a user enters an input that belongs to such scenarios, they may encounter runtime errors which are undesirable. The respective classes can now handle errorneous inputs such as: * marking/unmarking a task number that does not exist * wrong command format * empty task descriptons

damithc and others added 9 commits July 31, 2022 17:20

Add Gradle support

556af3f

Increment Level-1

20f5511

Increment Level-2

a8bfb6e

Increment Level-3

692ba50

Increment Level-4

ba532a7

Increment A-TextUiTesting

5c83cd4

Increment Level-5

6e2313a

Increment Level-6

39b9f2b

Increment A-Enums

2d78f9f

LiuMC-SG reviewed Feb 1, 2023

View reviewed changes

venuslimm reviewed Feb 2, 2023

View reviewed changes

minosx31 added 19 commits February 3, 2023 19:52

Increment Level-7

6624acd

Increment Level-8

d3fcbc3

Merge branch 'branch-Level-7'

d60aac8

Merge branch 'branch-Level-8'

f3ef91f

Merge branch-Level-7 and branch-Level-8

798798c

Merge remote-tracking branch 'upstream/add-gradle-support'

79e8273

Increment A-MoreOOP

1516c25

Increment A-Packages

7015af7

Increment A-Gradle

b4df4e1

Increment A-JUnit

f41c3a1

Increment A-Jar

2d45c18

Added JavaDoc comments

9549064

Follow coding standard

ab80dc6

Increment Level-9

f66d524

Merge branch 'branch-A-JavaDoc'

11399b7

Resolve merge conflict with branch-A-CodingStandard

cbe2559

Merge branch 'branch-Level-9'

29a34d7

Increment A-CheckStyle

9a591e7

Increment Level-10

54d9c9b

minosx31 and others added 27 commits February 14, 2023 12:19

Merge branch 'branch-A-CheckStyle'

ff69f15

Merge branch 'branch-Level-10'

8e50425

Improve code quality

e47033e

Ensure that the code follows the provided guidelines so that it remains readable and is of high quality.

Merge pull request #2 from minosx31/branch-A-Assertions

66c959b

Add assertions

Merge branch 'master' into branch-A-CodeQuality

b19b32b

Merge pull request #3 from minosx31/branch-A-CodeQuality

d322b4b

Improve code quality

Add gradle.yml

96eebc3

Add C-Help extension

9a152f4

Merge branch 'branch-C-Help'

23ca05c

Improve GUI

10b67a2

Merge branch 'branch-A-BetterGui'

17a0c97

Update Duke's responses

f4d8543

Merge branch 'branch-A-Personality'

ca9076d

Update ByeCommand

dccaeae

Update of Event and Deadline

3a3ce87

Merge branch 'branch-A-MoreErrorHandling'

fed2d8a

Update GUI

7df31d5

Remove redundant code

58e15e1

Fix typo

dee885f

Update README.md and add Ui.png

9182527

Edit build.gradle file

8367a46

Update data file

11bf549

Update mainClassName

1e55b6b

Fix test cases

c686eeb

Fix checkstyle errors

be4ca33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[minosx31] iP #353

[minosx31] iP #353

minosx31 commented Jan 29, 2023 •

edited

LiuMC-SG left a comment

LiuMC-SG Feb 1, 2023

LiuMC-SG Feb 1, 2023

LiuMC-SG Feb 1, 2023

LiuMC-SG Feb 1, 2023

LiuMC-SG Feb 1, 2023

venuslimm left a comment

venuslimm Feb 2, 2023

venuslimm Feb 2, 2023

venuslimm Feb 2, 2023

venuslimm Feb 2, 2023

	private static String numOfTasks(ArrayList<Task> tasks) {
	private static String getTaskString(ArrayList<Task> tasks) {

	Scanner sc = new Scanner(System.in );
	Scanner sc = new Scanner(System.in);

[minosx31] iP #353

Are you sure you want to change the base?

[minosx31] iP #353

Conversation

minosx31 commented Jan 29, 2023 • edited

DukePro

LiuMC-SG left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

venuslimm left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

minosx31 commented Jan 29, 2023 •

edited