[clydelhui] iP #373

clydelhui · 2023-01-31T07:22:02Z

Duke

"How much wood would a woodchuck chuck if a woodchuck could chuck wood? As much as the number of tasks that Duke can store for you." - Clyde Lhui

Duke stores everything for you! It's

Fantastic
Awesome
Written by a cool guy 😸
~~Great~~ THE ABSOLUTE GREATEST

To experience the greatest of Duke,

Download it from here
Click on it
Experience the wonders of Duke!

Features:
[x] Task management
[ ] Search (coming soon)

If you are a Java programmer, you can take a look at the source code too!. Here is the main method in Duke!

public static void main(String[] args) {


        Scanner usrInput = new Scanner(System.in);
        Ui ui = new Ui(usrInput);

        ui.welcome();

        Storage storage = new Storage("data.txt", ui);

        TaskList taskList = new TaskList(storage, ui);

        Parser parser = new Parser();

        String input = "";

        while (true) {
            input = ui.getInput();
            try {
                Command command = parser.parse(input);
                command.execute(taskList, ui, storage);
            } catch (DukeException e) {
                ui.errorDisplay(e);
            }
        }

    }

…nvalid inputs

# Conflicts: # src/main/java/Duke.java

0x787af25e

Your code is of good quality (though I see some parts that do not conform to the coding standard).

zichen-3974

Nice job! Your code is clean and easy to follow overall, and your variables are named meaningfully. You may want to consider adding some Javadocs in the future :) 👍

zichen-3974 · 2023-02-04T08:10:11Z

src/main/java/CommandHandler.java

+        this.taskList = taskList;
+    }
+
+    public void execute(String command) throws IllegalCommandException,


Perhaps you can consider having Javadocs for this method

zichen-3974 · 2023-02-04T08:13:18Z

src/main/java/CommandHandler.java

+    public void execute(String command) throws IllegalCommandException,
+            IllegalInputException, NumberFormatException {
+        String[] parsedCommand = command.split(" ", 2);
+        switch (parsedCommand[0]) {


I like your implementation! Perhaps you can consider further abstraction, e.g having an abstract Command class that different types of commands can extend from :)

YZmunchmunch · 2023-02-05T09:56:31Z

src/main/java/items/Deadline.java

        super(description, "D");
        this.endDate = endDate;
    }

-    public Deadline(String description, boolean done, String endDate) {
+    public Deadline(String description, boolean done, LocalDate endDate) {


perhaps the parameter "done" could be changed to "isDone" instead!

JThh

The codes are easy to read and well-functional.

JThh · 2023-02-05T12:32:18Z

src/main/java/TaskList.java

+    }
+
+    public void delete(int index){
+        Task deleted = this.taskList.remove(index - 1);


Can here be some input validity check to ensure index is never less than 1?

JThh · 2023-02-05T12:33:01Z

src/main/java/dukeexceptions/IllegalInputException.java

@@ -0,0 +1,12 @@
+package dukeexceptions;


Please conform to the camelNaming rule here to name the package.

Add additional exceptions with better handling.

…mmand and Parser classes.

# Conflicts: # src/main/java/commands/VoidCommand.java

# Conflicts: # src/main/java/elems/TaskList.java

When TaskList methods are called, the ArrayList of Tasks should never be null. Adding assertions allows us to ensure that this invariant is always true. Let's add assertions to the TaskList methods to ensure that all TaskList Objects which are targets for method invocation have non-null ArrayLists at the time of method calling.

execute method in the AddCommmand class is long and can be hard to debug in the future. If more commands are added, the code will get even longer. Let's abstract out the steps taken in each case into a separate method. Future additions of AddCommands can adopt the same style of execution.

add assertions

* 'master' of https://github.com/clydelhui/ip: add assertions

Improve code quality

The user may wish to sort the task list by description to make it easy to read. Let's add a sorting feature to enable the user to do this. Some commands such as list and sort will access the list elements. If the list is empty, they are unable to work as intended. Let's add an exception to show the case when an empty list is being accessed by commands that work with the whole list.

damithc and others added 12 commits July 31, 2022 17:20

Add Gradle support

556af3f

Modified Duke.java

5ba595d

Modified Duke.java

8dfc573

Added Task.java and Modified Duke.java

808b76a

Added new task types, modified Duke.java

3e0e70a

Added Text UI Testing

1222458

Mofiy runtest.bat to compile packages, created exceptions to handle i…

75ff48e

…nvalid inputs

Modify Duke.java to include delete functionality

b8795a2

Add saving functionality, add CommandHandler and TaskList classes

d44382f

Change type of Deadline to LocalDate

4a5cb95

Merge branch 'branch-Level-7'

4949ee8

Merge branch 'branch-Level-8'

27e8322

# Conflicts: # src/main/java/Duke.java

0x787af25e reviewed Feb 2, 2023

View reviewed changes

zichen-3974 reviewed Feb 4, 2023

View reviewed changes

YZmunchmunch reviewed Feb 5, 2023

View reviewed changes

JThh reviewed Feb 5, 2023

View reviewed changes

clydelhui added 14 commits February 9, 2023 01:06

Add Ui, Storage, Parser, and Command classes.

1a3fb0a

Add additional exceptions with better handling.

Merge remote-tracking branch 'origin/add-gradle-support'

08bad31

Add checkstyle to gradle, fix style issues, add JUnit tests for AddCo…

d231c99

…mmand and Parser classes.

Add new StorageException, JavaDocs

6943842

Add new VoidCommand type "find"

7603704

Modify files to fit coding standard

fc4f9e3

Merge branch 'branch-A-JavaDoc'

9b4cc31

Merge branch 'branch-A-CodingStandard'

0bf4219

# Conflicts: # src/main/java/commands/VoidCommand.java

Merge branch 'branch-Level-9'

3572669

# Conflicts: # src/main/java/elems/TaskList.java

add UI with JavaFX

cad9b7a

Merge branch 'branch-Level-10'

fa95494

Merge pull request #2 from clydelhui/branch-A-Assertions

640b3e3

add assertions

clydelhui added 6 commits February 19, 2023 17:19

Merge branch 'master' of https://github.com/clydelhui/ip

47cc6af

* 'master' of https://github.com/clydelhui/ip: add assertions

Merge pull request #3 from clydelhui/branch-CodeQuality

9c2d01f

Improve code quality

Merge branch 'branch-BCD-Extension'

b65a8e2

update README.md, make minor bug fixes

9d7b757

Modify README.md

81c5f59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[clydelhui] iP #373

[clydelhui] iP #373

clydelhui commented Jan 31, 2023 •

edited

0x787af25e left a comment

zichen-3974 left a comment

zichen-3974 Feb 4, 2023

zichen-3974 Feb 4, 2023

YZmunchmunch Feb 5, 2023

JThh left a comment

JThh Feb 5, 2023

JThh Feb 5, 2023

[clydelhui] iP #373

Are you sure you want to change the base?

[clydelhui] iP #373

Conversation

clydelhui commented Jan 31, 2023 • edited

Duke

0x787af25e left a comment

Choose a reason for hiding this comment

zichen-3974 left a comment

Choose a reason for hiding this comment

zichen-3974 Feb 4, 2023

Choose a reason for hiding this comment

zichen-3974 Feb 4, 2023

Choose a reason for hiding this comment

YZmunchmunch Feb 5, 2023

Choose a reason for hiding this comment

JThh left a comment

Choose a reason for hiding this comment

JThh Feb 5, 2023

Choose a reason for hiding this comment

JThh Feb 5, 2023

Choose a reason for hiding this comment

clydelhui commented Jan 31, 2023 •

edited