[randallnhr] iP #389

randallnhr · 2023-02-03T14:09:55Z

DukeBot

“Your mind is for having ideas, not holding them.” – David Allen (source)

DukePro frees your mind of having to remember things you need to do. It's,

text-based
easy to learn
~~FAST~~ SUPER FAST to use

Where do I begin?

All you need to do is,

download the JAR file from (here).
double-click it.
add your tasks.
let it manage your tasks for you 😉

And it is FREE!

Features

Managing tasks
Managing deadlines (coming soon)
Reminders (coming soon)

runoutofit · 2023-02-03T17:54:06Z

src/main/java/Task.java

+    protected String startDate;
+    protected String endDate;
+
+    public Task(String name, String date1, String date2) {


would it be better to abstract out startDate and endDate to Event class?

runoutofit · 2023-02-03T17:57:44Z

src/main/java/Duke.java

@@ -12,8 +13,9 @@ public static void main(String[] args) throws IOException {

        BufferedReader br = new BufferedReader(new InputStreamReader(System.in));

-        String[] word = br.readLine().split(" ");
+        String[] word = br.readLine().split(" ",2);


i like that you store word as a String array for easier manipulation

runoutofit · 2023-02-03T17:59:04Z

src/main/java/Duke.java

@@ -12,8 +13,9 @@ public static void main(String[] args) throws IOException {

        BufferedReader br = new BufferedReader(new InputStreamReader(System.in));

-        String[] word = br.readLine().split(" ");
+        String[] word = br.readLine().split(" ",2);


would renaming word make it less vague and reflect more as a command?

antonlee59

Overall, LGTM. Very clean code and very nice use of ternary operators. Nice abstraction and use of Inheritance to enforce the OOP principles. Good job!

antonlee59 · 2023-02-04T21:35:01Z

src/main/java/Deadline.java

+    public String toString() {
+        return this.isDone
+                ? "[D][X] " + this.name + " (by: " + getDate(this.deadline) + ")"
+                : "[D][ ] " + this.name + " (by: " + getDate(this.deadline) + ")";
+    }
+}


Perhaps, instead of leaving the isDone logic in this toString() function, you could leave it in the Task class instead so that you dont have to retype so much code if you need to create a new Task type in the future.

antonlee59 · 2023-02-04T21:37:16Z

src/main/java/Duke.java

+        //         try {
+        //             if (word[0].equals("list")) {
+        //                 int curr = 1;
+        //                 Iterator<Task> iter = lst.iterator();
+        //                 while (iter.hasNext()) {
+        //                     System.out.println(curr + " " + iter.next());
+        //                     curr++;
+        //                 }
+        //                 word = br.readLine().strip().split(" ",2);
+        //             } else if (word[0].equals("mark")) {
+        //                 if (word.length == 1) {
+        //                     throw new DukeException("Mark needs a number.");
+        //                 }
+        //                 if (Integer.parseInt(word[1]) > count) {
+        //                     throw new DukeException("Invalid task.");
+        //                 }
+        //                 Task t = lst.get(Integer.parseInt(word[1]) - 1);
+        //                 t.isDone = true;
+        //                 System.out.println("Task has been marked as done:\n " + t);
+        //                 word = br.readLine().split(" ",2);
+        //             } else if (word[0].equals("unmark")) {
+        //                 if (word.length == 1) {
+        //                     throw new DukeException("Unmark needs a number.");
+        //                 }
+        //                 if (Integer.parseInt(word[1]) > count) {
+        //                     throw new DukeException("Invalid task.");
+        //                 }
+        //                 Task t = lst.get(Integer.parseInt(word[1]) - 1);
+        //                 t.isDone = false;
+        //                 System.out.println("Task has been marked as not done:\n " + t);
+        //                 word = br.readLine().split(" ",2);
+        //             } else if (word[0].equals("todo")) {
+        //                 if (word.length == 1) {
+        //                     throw new DukeException("todo needs a description");
+        //                 }
+        //                 Task t = new Todo(word[1].strip());
+        //                 lst.add(t);
+        //                 count++;
+        //                 System.out.println("Added new todo:\n  " + t + "\nNumber of tasks: " + count);
+        //                 word = br.readLine().strip().split(" ",2);
+        //             } else if (word[0].equals("deadline")) {
+        //                 if (word.length == 1 || !word[1].contains("/by")) {
+        //                     throw new DukeException("Deadline needs a /by.");
+        //                 }
+        //                 String[] tempWord = word[1].strip().split("/by ");
+        //                 if (tempWord.length == 1) {
+        //                     throw new DukeException("/by needs a date/time.");
+        //                 }
+        //                 try {
+        //                     Task t = new Deadline(tempWord[0].strip(), tempWord[1].strip());
+        //                     lst.add(t);
+        //                     count++;
+        //                     System.out.println("Added new deadline:\n  " + t + "\nNumber of tasks: " + count);
+        //                     word = br.readLine().strip().split(" ",2);
+        //                 } catch (DateTimeParseException e) {
+        //                     throw new DukeException("Date after /by needs to be in format yyyy-mm-dd");
+        //                 }
+        //             } else if (word[0].equals("event")) {
+        //                 if (word.length == 1 || !word[1].contains("/from") || !word[1].contains("/to") ) {
+        //                     throw new DukeException("Event needs a /from and /to.");
+        //                 }
+        //                 String[] tempWord = word[1].split("/");
+        //                 String[] from = tempWord[1].split(" ",2);
+        //                 String[] to = tempWord[2].split(" ",2);
+        //                 if (from.length == 1 || to.length == 1) {
+        //                     throw new DukeException("/from and /to needs a date/time.");
+        //                 }
+        //                 try {
+        //                     Task t = new Event(tempWord[0].strip(), from[1].strip(), to[1].strip());
+        //                     lst.add(t);
+        //                     count++;
+        //                     System.out.println("Added new event:\n  " + t + "\nNumber of tasks: " + count);
+        //                     word = br.readLine().strip().split(" ",2);
+        //                 } catch (DateTimeParseException e) {
+        //                     throw new DukeException("Date after /from and /to needs to be in format yyyy-mm-dd");
+        //                 }
+        //             } else if (word[0].equals("delete")) {
+        //                 if (word.length == 1) {
+        //                     throw new DukeException("Delete needs a number.");
+        //                 }
+        //                 if (Integer.parseInt(word[1]) > count) {
+        //                     throw new DukeException("Invalid task.");
+        //                 }
+        //                 Task t = lst.remove(Integer.parseInt(word[1]) - 1);
+        //                 count--;
+        //                 System.out.println("Deleted task:\n  " + t + "\nNumber of tasks: " + count);
+        //                 word = br.readLine().strip().split(" ",2);
+        //             } else {
+        //                 throw new DukeException("Sorry I do not understand the command");
+        //             }
+        //         } catch (DukeException e) {
+        //             System.out.println(e.getMessage());
+        //             word = br.readLine().strip().split(" ",2);
+        //         }
+        //     }
+        //     storeData(lst);
+        //     System.out.println("Duke: Goodbye");
+        // } catch (IOException e) {
+        //     System.out.println(e.getMessage());
+        // }


I suggest you to just delete all these unnecessary commented code. That is mainly the point of a version control system like git which is to undo any changes that you might not like in the future. Commenting them out and leaving them in code makes your code unnecssarily long and confusing.

Zhongli5712

Overall, I found your code easy to follow, however there are still some minors details that you should notice. Well done!

Zhongli5712 · 2023-02-05T12:34:08Z

src/main/java/duke/Parser.java

+    public void todo(String[] input, TaskList taskList) throws DukeException {
+        if (input.length == 1) {
+            throw new DukeException("todo needs a description");
+        }
+        Task t = new Todo(input[1].strip());
+        taskList.addTask(t);
+        System.out.println("Added new todo:\n  " + t + "\nNumber of tasks: " + taskList.size());
+    }


should the method name be "addTodo"?

Zhongli5712 · 2023-02-05T12:35:11Z

src/main/java/duke/TaskList.java

+import duke.task.Task;
+
+public class TaskList {
+    private ArrayList<Task> taskList;


should the name be "tasks"?

Zhongli5712 · 2023-02-05T12:38:17Z

src/main/java/duke/Parser.java

+        switch (input[0]) {
+            case "list":   
+                taskList.list(); 
+                break;        
+            case "mark":
+                mark(input, taskList);
+                break;
+            case "unmark":
+                unmark(input, taskList);
+                break;
+            case "todo":
+                todo(input, taskList);
+                break;
+            case "deadline":
+                deadline(input, taskList);
+                break;
+            case "event":
+                event(input, taskList);
+                break;
+            case "delete":
+                delete(input, taskList);
+                break;
+            default:
+                throw new DukeException("Sorry I do not understand the command");


should the switch and case and default be on the same indentation?

Zhongli5712 · 2023-02-05T12:39:27Z

src/main/java/duke/Parser.java

+    }
+
+    public void event(String[] input, TaskList taskList) throws DukeException {
+        if (input.length == 1 || !input[1].contains("/from") || !input[1].contains("/to") ) {


should it be broken down to be three boolean variables?

Zhongli5712 · 2023-02-05T12:40:22Z

src/main/java/duke/task/Deadline.java

+    public String getFileDesc() {
+        return this.isDone
+        ? "D|1|" + this.name + "|" + convertFileDate(this.deadline)
+        : "D|0|" + this.name + "|" + convertFileDate(this.deadline);
+    }


I like your break down line for easier reading

Set up JavaFX and link Duke class to GUI. Add MainWindow.java as controller for as main GUI. Add DialogBox.java as controller for DialogBox in GUI. Add MainWindow.fxml and DialogBox.fxml for GUI layout and interaction

Assertions make it easier to ensure that certain variables/ methods are behaving as expected. By using assertions, we can make debugging easier as assumptions are ensured.

Add assertions

There are several methods that use complicated expressions. `mark`, `unmark`, `deadline` and `delete` methods in Parser class has 2 checks in an if condition. Abstracted the checks to 2 variables to enhance readability. `event` method in the Parser class has 3 checks in the if condition. Abstracted the checks to 3 variables to enhance readability. As a step forward, let's abstract complicated checks in the conditions.

Branch a code quality

Allow users to change the /by date of deadline tasks and /from, /to of event tasks.

damithc and others added 10 commits July 31, 2022 17:20

Add Gradle support

556af3f

Level-1

d931af6

Level-1

34904a0

Level-2

4e12dad

Level-3

510ffff

Level-4

927000e

A-TextUiTesting

7315848

Level-5

149e1d0

Level-6

357e5f7

Level-7

c2c6903

runoutofit reviewed Feb 3, 2023

View reviewed changes

randallnhr added 5 commits February 4, 2023 15:13

Level-8

231ec2e

updated input and expected txt files

4614698

Merge branch 'branch-Level-8'

dbb7cbf

Merge Level-8 to master

df38bca

A-MoreOOP

5c0e7b1

antonlee59 reviewed Feb 4, 2023

View reviewed changes

randallnhr added 4 commits February 5, 2023 16:36

A-Packages

674f297

Merge remote-tracking branch 'origin/add-gradle-support'

c894cbf

A-Gradle

2e673f7

A-JUnit

359765a

Zhongli5712 reviewed Feb 5, 2023

View reviewed changes

randallnhr added 8 commits February 5, 2023 22:31

Add increment A-JavaDoc

224fa30

Remove redundant codes and correct layout of code

24d5209

Add increment Level-9

74266a2

Merge branch 'branch-A-CodingStandard'

56f1dc5

Merge branch 'branch-Level-9'

25c6740

Add GUI

1318085

Set up JavaFX and link Duke class to GUI. Add MainWindow.java as controller for as main GUI. Add DialogBox.java as controller for DialogBox in GUI. Add MainWindow.fxml and DialogBox.fxml for GUI layout and interaction

Add GUI

31a8483

Set up JavaFX and link Duke class to GUI. Add MainWindow.java as controller for as main GUI. Add DialogBox.java as controller for DialogBox in GUI. Add MainWindow.fxml and DialogBox.fxml for GUI layout and interaction

Merge branch 'branch-Level-10'

c0d137a

randallnhr and others added 14 commits February 12, 2023 23:45

Add assertions

caacaec

Assertions make it easier to ensure that certain variables/ methods are behaving as expected. By using assertions, we can make debugging easier as assumptions are ensured.

Merge pull request #2 from randallnhr/branch-A-Assertions

0af8473

Add assertions

Fix error in Parser

8794559

Merge pull request #3 from randallnhr/branch-A-CodeQuality

c21cf25

Branch a code quality

Add reschedule functionality

8539e7e

Allow users to change the /by date of deadline tasks and /from, /to of event tasks.

Merge branch 'branch-BCD-Extension'

d962643

Improve GUI

47632b4

Add personality

0f35873

Add personality

1c91d33

Edit delete and error message

919e432

Add Ui.png

9a5d484

Edit README.md

a70e173

Edit README.md

0c185b1

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[randallnhr] iP #389

[randallnhr] iP #389

randallnhr commented Feb 3, 2023 •

edited

runoutofit Feb 3, 2023

runoutofit Feb 3, 2023

runoutofit Feb 3, 2023

antonlee59 left a comment

antonlee59 Feb 4, 2023

antonlee59 Feb 4, 2023

Zhongli5712 left a comment

Zhongli5712 Feb 5, 2023

Zhongli5712 Feb 5, 2023

Zhongli5712 Feb 5, 2023

Zhongli5712 Feb 5, 2023

Zhongli5712 Feb 5, 2023

[randallnhr] iP #389

Are you sure you want to change the base?

[randallnhr] iP #389

Conversation

randallnhr commented Feb 3, 2023 • edited

DukeBot

Where do I begin?

Features

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

antonlee59 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Zhongli5712 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

randallnhr commented Feb 3, 2023 •

edited