[zhengsterz] iP #41
Open
[zhengsterz] iP #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whenever the task list changes TaskFile class added to maintain tasklist.txt Updates to Red and Tasklist classes to enable this new feature.
# Conflicts: # src/main/java/DeadlineTask.java # src/main/java/Red.java
Command and Parser classes added,TaskFile was changed to Storage for better clarity and updates to all Task classes to accomodate these changes
Classes were already put into packages in previous commit
FindCommand added to facilitate this.
# Conflicts: # src/main/java/red/storage/Storage.java
# Conflicts: # src/main/java/red/parser/Parser.java # src/main/java/red/task/TaskList.java
JunHao247
reviewed
Feb 2, 2023
data/tasklist.txt
Outdated
| @@ -0,0 +1,7 @@ | |||
| This is your current task list: | |||
| 1. [E][ ] cry (From: 2pm To: 8am) | |||
There was a problem hiding this comment.
Maybe you could include the date along with the time? Since in your code for deadline and event you are using LocalDateTime
| import red.task.ToDoTask; | ||
|
|
||
| import red.ui.UI; | ||
|
|
There was a problem hiding this comment.
I like how the imports are separated with a spacing into each category, very organised and tidy to read
| public class EventTask extends Task { | ||
|
|
||
| protected String by; | ||
| protected String byy; |
There was a problem hiding this comment.
Would help to have a more detailed attribute like
protected String start;
protected String end;
| String[] arrOfStrStr= arrOfStr[1].split("\\(From: ", 2); | ||
| String[] arrOfStrStrStr= arrOfStrStr[1].split("To: ", 2); | ||
| String[] arrOfStrStrStrStr= arrOfStrStrStr[1].split("\\)", 2); | ||
| EventTask currentTask = new EventTask(arrOfStrStr[0],arrOfStrStrStr[0],arrOfStrStrStrStr[0]); |
There was a problem hiding this comment.
It will be good to change the variable name to something more specific,
for example
String[] arrOfFrom= arrOfStr[1].split("\\(From: ", 2);
similar for the other variable names
Add ability to run shadowJar by altering build gradle plus minor
CommandTask classes Un/MarkCommand assertions checks that the tasklist size will never be a negative number.Parser assertions checks that the parser does not read an empty line as user input.DeadlineTask assertions checks that the date and time provided conform to the necessary format. These ensure that if something were to go wrong it would be the result of the user input instead of a problem with the program itself.
Add assertions to Un/MarkCommand,Parser,DeadlineTask and
Revert "Add ability to run shadowJar by altering build gradle plus mi…
Revert "Add assertions to Un/MarkCommand,Parser,DeadlineTask and"
…rtions Revert "Revert "Add ability to run shadowJar by altering build gradle plus mi…"
…rtions Revert "Revert "Add assertions to Un/MarkCommand,Parser,DeadlineTask and""
expressions This was done to avoid complicated expressions, especially those having many negations and nested parentheses, thus increasing code quality.
Add booleans to some of the command classes to simplify
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RED : Robotic Enhancer of Development
RED frees your mind of having to remember things you need to do. It's,
FASTSUPER FAST to useAll you need to do is,
And it is FREE!!!!
Features :