Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Zhu Le Yao] iP #414

Open
wants to merge 52 commits into
base: master
Choose a base branch
from
Open

[Zhu Le Yao] iP #414

wants to merge 52 commits into from

Conversation

ZhuLeYao
Copy link

@ZhuLeYao ZhuLeYao commented Feb 7, 2023

DukePro

"I love DukePro ❤️" - Lady Baba Source

DukePro helps you to record your tasks and events.
DukePro is:

  • simple
  • cleanly designed
  • convenient

How to use DukePro:

  1. Download it.
  2. Double-click on it.
  3. Add your tasks/ deadlines/ events.
  4. DukePro will handle the rest! 🎉

Features:

  • Managing Tasks
  • Managing Deadlines
  • Managing Events

If you would like to practice yourself, here is the main method:

public class Main {
    public static void main(String[] args) {
        Application.launch(MainApp.class, args);
    }
}

damithc and others added 10 commits July 31, 2022 17:20
Tasks can be marked as done or undone. Wordings are modified.

Task class is added to store name, number and task information.
Subclasses of Tasks are created, namely Todo, Deadline and Event.
Deadline and Event are able to store information on the task's time.
Some wording are also modified.
Exceptions are missing index, invalid index, invalid command and
incomplete command caused by missing task or task time.
Time format is shown as "MMM dd yyyy HHmm a".
}

@Override
public void markAsDone() {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good splitting of lines!


try {
if (command.equals("list")) {
this.printCommandList(allTasks);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unnecessary qualifier to this

this.taskNumber = taskNumber;
this.taskStatus = taskStatus;
this.task = task;
this.totalNumOfTasks = totalNumOfTasks;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this field is unused

@@ -0,0 +1,66 @@
public class Task {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be made into a abstract class, with abstract method implementations

@@ -0,0 +1,58 @@
public class Deadline extends Task {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs Javadocs for these public classes & public methods

Existing ask list is able to be reflected in duke when restarted.
@ZhuLeYao ZhuLeYao force-pushed the master branch 5 times, most recently from dedfbd6 to 2008de1 Compare February 12, 2023 16:42
# Conflicts:
#	src/main/java/Deadline.java
#	src/main/java/Duke.java
#	src/main/java/Event.java
#	src/main/java/Task.java
# Conflicts:
#	src/main/java/Deadline.java
#	src/main/java/Duke.java
#	src/main/java/Event.java
#	src/main/java/Task.java
Ui: deals with interactions with the user
Storage: deals with loading tasks from the file and saving tasks in the
file
Parser: deals with making sense of the user command
TaskList: contains the task list e.g. it has operations to add/delete
tasks in the list
ZhuLeYao and others added 17 commits February 23, 2023 01:02
In Parser.java, "mark", "unmark" and "delete" commands has similar parsing codes.
Similar areas are taken out to form method
checkExceptionAndGetTask(String, TaskList).

In Storage.java, "mark" and "unmark" commands has similar file reading
procedures.
Similar areas are taken out to form method
markOrUnmarkStorage(File, String, Task, DateTimeFormatter, TaskList,
String).
"delete" command's file reading procedure is taken out to form method
deleteStorage(File, String, TaskList).
Add Assertions for assumptions in main
A way to archive every task and action is added. Tasks archived will be
saved in archive.txt in the folder "data". Deleted tasks will be
removed from tasks.txt but remains stored in archive.txt. User can use
command "archive" to archive a copy of the current tasks in list. This
will be saved in archiveAll.txt in folder "data". archive.txt will still
contain history of all tasks, not just tasks in current list.
* branch-BCD-Extension:
  Add a way to archive items

A way to archive every task and action is added. Tasks archived will be
saved in archive.txt in the folder "data". Deleted tasks will be
removed from tasks.txt but remains stored in archive.txt. User can use
command "archive" to archive a copy of the current tasks in list. This
will be saved in archiveAll.txt in folder "data". archive.txt will still
contain history of all tasks, not just tasks in current list.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants