[zrei] iP #44
Open
[zrei] iP #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make duke echo commands and exit when user types "bye".
Duke can now store text and display the stored text to users.
Tasks can now be marked as done or unmarked as done.
Implement Deadline class that extends from Task.
Implement Todo class that extends from Task.
Implement Event class that extends from Task and make Task an abstract class.
Implement exceptions.
Previously, Files.createDirectory(dirPath) was throwing an IOException when the directory data already existed. Creating the directory data only when it does not exist prevents the IOException from being thrown. The saved task list is now loaded correctly.
Add VS code and local storage files to .gitignore.
Add assertions
Improve code quality
When a help command is issued, Duke outputs a long response containing all commands it recognises. This is hard to read due to the text being longer than the window length, and needing the user to scroll up and down to find the command they want to execute. Let's add a separate window to contain all the commands that Duke recognises, and launch this window when a help command is issued. TODO: * Improve the GUI of the help window
Help command: launch a separate window
AngJunYang
reviewed
Feb 4, 2023
src/main/java/duke/Storage.java
Outdated
| fw.write(taskList); | ||
| fw.close(); | ||
| } catch (IOException e) { | ||
| throw new DukeException("I couldn't write to storage. I tripped past the entranceway."); |
There was a problem hiding this comment.
I like these personalized exception messages!
| package duke.command; | ||
|
|
||
| /** Enum to represent commands */ | ||
| public enum CommandType { |
There was a problem hiding this comment.
I like the use of enums in your implementation of Commands!
| import duke.gui.SpriteEmotion; | ||
| import duke.task.Task; | ||
|
|
||
| public class DeleteCommand extends Command { |
There was a problem hiding this comment.
Perhaps some descriptive header commends for this class?
| private static final float ROUNDED_CORNERS_LENGTH = 25; | ||
|
|
||
| private static final Color DUKE_COLOR = Color.CORNFLOWERBLUE; | ||
| private static final Color USER_COLOR = Color.CRIMSON; |
There was a problem hiding this comment.
Perhaps associated constants should have a constant prefix?
There was a problem hiding this comment.
Thanks for pointing this out! I didn't notice this before now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRESENTING THE ILLUSTRIOUS DUKE
If you've ever found yourself at a loss on how to keep track of your humongous, ever-increasing mountain of tasks, then Duke is perfect for you!
Duke can do many
god-like, reality-shatteringamazing things, including but not limited to:Control realityRemember your tasks in-between sessions!You, too, can get access to this awesomeness through a few simple steps.
Give up your soulStart it up!Start Duke with this simple
command:So, what are you waiting for?
And here's some random code that I have to include for some arbitrary reason. It's the classic
helloWorldfunction!Can you believe that this printsHello World?